What is wrong with this exapand / hide script?

Here's my Javascript:

<script language="JavaScript">
	function expand(param)
	{
		param.style.display=(param.style.display=="none")?"":"";
	}
</script>

<script language="JavaScript">
	function hide(param)
	{
		param.style.display=(param.style.display=="")?"none":"none";
	}
</script>

Open in new window


...and here's my HTML

<a href="#" onclick="expand(document.g<wbr ></wbr>etElementB<wbr ></wbr>yId('div1'<wbr ></wbr>));  this.innerHTML=''; return false;">read more...</a>

<div id="div1" style="display:none;"><tab<wbr ></wbr>le width="600" border="1" align="center">stuff...</table>

<a href="#" onclick="hide(document.get<wbr ></wbr>ElementByI<wbr ></wbr>d('div1'))<wbr ></wbr>; this.innerHTML='none'; return false;">hide...</a></div>

Open in new window


Everything works as far as revealing the div, but when I go to hide it again, I can't see my "read more" link. It's there when you first click on it, but when you click on "hide," you don't see it anymore.

Where am I blowing it?
brucegustPHP DeveloperAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

OriNetworksCommented:
You are setting this.innerHTML=''; which is removing the text Read More...
0
brucegustPHP DeveloperAuthor Commented:
Nuts. OK, how do I fix it? Seems like JavaScript is going to process the click that "hides" my div as something that simultaneously hides my "read more." How do I compensate for that?
0
leakim971PluritechnicianCommented:
test page : http://jsfiddle.net/s85tfdax/

	function expand(param)
	{
		param.style.display = "block";
	}

	function hide(param)
	{
		param.style.display = "none";
	}

    window.onload = function() {
        document.getElementById("readmore").onclick = function() {
            expand(document.getElementById("div1"));
        }
        document.getElementById("hide").onclick = function() {
            hide(document.getElementById("div1"));
        }
    }
    

Open in new window

0
Determine the Perfect Price for Your IT Services

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden with our free interactive tool and use it to determine the right price for your IT services. Download your free eBook now!

OriNetworksCommented:
You need to assign an id to both the read more and hide links. Then you can use document.getElementById to show/hide them.
0
OriNetworksCommented:
You can keep your existing javascript and reuse the functions to show/hide the read more link
<a href="#" id="lnkMore" onclick="expand(document.getElementById('div1')); hide(this); return false;">read more...</a>

<div id="div1" style="display:none;">stuff...

<a href="#" id="lnkHide" onclick="hide(document.getElementById('div1')); expand(document.getElementById('lnkMore')); return false;">hide...</a>
</div>

Open in new window

0
Jagadishwor DulalBraces MediaCommented:
Alternate using toggle show hide
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Untitled Document</title>
<script type="text/javascript">
<!--
    function toggle_visibility(id) {
       var e = document.getElementById(id);
       if(e.style.display == 'none')
          e.style.display = 'block';
       else
          e.style.display = 'none';
    }
//-->
</script>



</head>

<body>
<a href="#" onclick="toggle_visibility('contents');">Show/Hide Stuff</a>
<div id="contents" style="display:none"><table width="600" border="1" align="center">stuff...</table></div>
</body>
</html>

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
JavaScript

From novice to tech pro — start learning today.