Solved

How to write a C++ program for student and grades?

Posted on 2014-10-07
8
4,390 Views
Last Modified: 2014-10-13
I am trying to write a C++ program to only input 10 student last names, number of correct answers, and total number of questions.  The program will use a loop for 10 students only.  The program will print out like this.
Greater than 90 should say Excellent, 80-90 should say Well Done, 70-80 should say Good, 60-70 Needs Improvement, and under 50 Failed.

smith 83% .83333 Well Done
This is a format of the printout. Should be 10 lines of different name and so on.
0
Comment
Question by:David Weeks
  • 2
8 Comments
 

Author Comment

by:David Weeks
ID: 40367323
I cannot figure out why my program will not work correctly.

// The program will read ten names from the user's input and compute  
// the grade for each name and prints the grade and tells whether the 
// grade is excellent, well done, good, or needs improvement. 

#include <iostream>
#include <iomanip>
#include <cmath>
#include <string>

using namespace std;

int main()

{
	string studentname;
	int score;
	int studentscore;
	int totalpoints;
	int percentage;
	int count;
	float finalscore;
	count = 1;
	    while (count <= 10)
	{
		cout << "Please enter the student's name" << endl;
		cin >> studentscore;
		cout << "Please enter the student's score" << endl;
		cin >> score;
		cout << "Please enter the total points" << endl;
		cin >> totalpoints;
		count = count++
		finalscore = score / totalpoints;
		percentage = finalscore * 100;
		if (percentage >= 90)
			cout << studentname << percentage << "%" << finalscore << "Excellent" << endl;
		if (percentage >= 80 && percentage < 90)
			cout << studentname << percentage << "%" << finalscore << "Well Done" << endl;
		if (percentage >= 70 && percentage < 80)
			cout << studentname << percentage << "%" << finalscore << "Good" << endl;
		if (percentage >= 60 && percentage < 70)
			cout << studentname << percentage << "%" << finalscore << "Needs Improvement" << endl;
		if (percentage < 50 && percentage < 60)
			cout << studentname << percentage << "%" << finalscore << "Failed" << endl;
	}
	return 0;
}

Open in new window

0
 
LVL 86

Accepted Solution

by:
jkr earned 500 total points
ID: 40367341
The problem basically is this line:

finalscore = score / totalpoints;

Open in new window


The result of' 'score / totalpoints' (aka an integer division) is an integer value and will in your case most likely be zero. Try casting the values to 'float' first to avoid that, e.g.

finalscore = (float) score / (float) totalpoints;

Open in new window

0
 
LVL 86

Expert Comment

by:jkr
ID: 40372114
Do you have any further issues?
0
 
LVL 33

Expert Comment

by:sarabande
ID: 40376890
to add to jkr's solution:

there are more issues in your code:

1. the student name was asked for but you have no code to get the input from user cause you
    mixed up studentname and studentscore.

2.  you better use a for loop instead of a while loop like 'for (int count = 0; count < 10; ++count)'.
     that makes sure that the count properly was incremented after each loop cycle.
     usually in c and c++ you were using a zero-based loop counter what avoids mistakes
     when using it as index for arrays which are zero-based as well.

3. you may use 'else if' instead of 'if' statements when checking the percentage for ranges less than 90.
    that spares the check for the upper boundary (if (perc > 90) ... else if (perc > 80) ... else if (perc > 70) ...)

4. use a statement like 'getline(cin, strinput);' at end of main before return. then the program
    stops at end waiting for input and you can check the output in the console window (shell)
    if you run the program from the ide. alternatively, if running the program with debugger,
    you may set a breakpoint to the return statement.
 
note, for input you should use function call of getline(cin, strinput) instead of 'cin >> ...' . that allows to properly handle the case when a user wants to quit (for example by a statement like 'if (strinput == "quit") break;' ) .it also allows spaces for text input. the disadvantage is that you need to check and convert the string input, if a number was required. you may use a temporary stringstream for that purpose or - maybe easier - use a function like strtol or atoi.

Sara
0

Featured Post

Active Directory Webinar

We all know we need to protect and secure our privileges, but where to start? Join Experts Exchange and ManageEngine on Tuesday, April 11, 2017 10:00 AM PDT to learn how to track and secure privileged users in Active Directory.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
mapAB Challlenge 35 160
Finding Divisors 5 20
boost::uuid crashes 17 13
Coding for the first time 9 31
Having just graduated from college and entered the workforce, I don’t find myself always using the tools and programs I grew accustomed to over the past four years. However, there is one program I continually find myself reverting back to…R.   So …
This article will show, step by step, how to integrate R code into a R Sweave document
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question