not able to get the validation correct

Hi
i need some help on resolving this program

My input should  be HH:MM:SS

HH should be between 00 and 24
MM should be between 00 to 59
SS should be between 00 to 59
24:00:00 is a valid clock but not beyond 24:00:00 when HH is 24, MM and SS should be 00
Invalid inputs are listed below

-------------------------

nulll and empty input string
wrong delimiter such as 00|00|23,
should not accept AA:BB:CC
negative value -01:29:-04 should not accept


Pls find the program it is not validating that

import java.util.ArrayList;
import java.util.List;


public class Berlinclass {

	
	 
	 public String[] convertToBerlinTime(String time) {
	    
	        List<Integer> parts = new ArrayList<Integer>();
	        for (String part : time.split(":")) {
	            parts.add(Integer.parseInt(part));
	        }
	        return new String[] {
	                getSeconds(parts.get(2)),
	                getTopHours(parts.get(0)),
	                getBottomHours(parts.get(0)),
	                getTopMinutes(parts.get(1)),
	                getBottomMinutes(parts.get(1))
	        };
	    }

	    protected String getSeconds(int number) {
	        if (number % 2 == 0) return "Y";
	        else return "O";
	    }

	    protected String getTopHours(int number) {
	        return getOnOff(4, getTopNumberOfOnSigns(number));
	    }

	    protected String getBottomHours(int number) {
	        return getOnOff(4, number % 5);
	    }

	    protected String getTopMinutes(int number) {
	        return getOnOff(11, getTopNumberOfOnSigns(number), "Y").replaceAll("YYY", "YYR");
	    }

	    protected String getBottomMinutes(int number) {
	        return getOnOff(4, number % 5, "Y");
	    }

	    // Default value for onSign would be useful
	    private String getOnOff(int lamps, int onSigns) {
	        return getOnOff(lamps, onSigns, "R");
	    }
	    private String getOnOff(int lamps, int onSigns, String onSign) {
	        String out = "";
	        // String multiplication would be useful
	        for (int i = 0; i < onSigns; i++) {
	            out += onSign;
	        }
	        for (int i = 0; i < (lamps - onSigns); i++) {
	            out += "O";
	        }
	        return out;
	    }

	    private int getTopNumberOfOnSigns(int number) {
	        return (number - (number % 5)) / 5;
	    }

	}
		
		
	

Open in new window

roy_sanuAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

dpearsonCommented:
Whoa, that's a lot of code.

You should check out "SimpleDateFormat" - it's designed to do exactly what you're trying to do by hand.  It'll throw a ParseException if the inputs are invalid.

		SimpleDateFormat format = new SimpleDateFormat("HH:mm:ss");
			Calendar cal = Calendar.getInstance() ;
			String time = "14:10:20";
			cal.setTime(format.parse(time)) ;

			int hours = cal.get(Calendar.HOUR_OF_DAY) ;
			int min = cal.get(Calendar.MINUTE) ;
			int sec = cal.get(Calendar.SECOND) ;
			System.out.println(hours + ":" + min + ":" + sec) ;

Open in new window

0
Amitkumar PSr. ConsultantCommented:
24:00:00 is a valid clock but not beyond 24:00:00 when HH is 24, MM and SS should be 00

Open in new window


Does it mean 00:00:00 and 24:00:00 are same ? I believe range should be from 00:00:00 to 23:59:59.

And as mentioned by dpearson, you will need to use SimpleDateFormat. It will throw an exception if the input is not as per the specified format or invalid. You dont need to reinvent the wheel again.

Refer http://www.mkyong.com/java/how-to-check-if-date-is-valid-in-java/ to get an idea how to achieve the objective.
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
CEHJCommented:
you will need to use SimpleDateFormat. It will throw an exception if the input is not as per the specified format or invalid. You dont need to reinvent the wheel again.
I agree, but you need to know that it IS possible to get invalid data past it unless you call setLenient(false) on the DateFormat
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Java

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.