Solved

setting a inputstream to null after closing it. Bad practice? Memory leaks?

Posted on 2014-10-16
9
188 Views
Last Modified: 2014-10-20
Hi;

I have the following code and not sure whether it will create a memory leak or not? What are the risks setting a inputstream to null after closing it. Bad practice?

public void close() throws IOException {
		System.out.println("Calling Test.close()...");
		if (is != null) {
			is.close();
			is = null;
		}
		System.out.println(Thread.currentThread().getName() + ":" + Thread.currentThread().getId() + ": Test.close() called!");
	}

Open in new window

0
Comment
Question by:jazzIIIlove
9 Comments
 
LVL 86

Assisted Solution

by:CEHJ
CEHJ earned 400 total points
ID: 40384054
In theory, very little needs to be explicitly set to null in Java owing to garbage collection. Occasionally you might want to do so to 'nudge' GC if a lot of resources are involved. That isn't the case with an InputStream. Why were you worrying about memory leaks?
0
 
LVL 12

Author Comment

by:jazzIIIlove
ID: 40384073
HI;

The code consequently accumulates and fills up all the heap space. I was thinking maybe this setting null is causing this. Can it?
0
 
LVL 86

Assisted Solution

by:CEHJ
CEHJ earned 400 total points
ID: 40384084
No. Setting something to null would normally do the reverse. The cause of your problem is elsewhere

e.g. NOT calling that method could cause a memory leak
0
Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

 
LVL 27

Assisted Solution

by:dpearson
dpearson earned 100 total points
ID: 40385418
You get a memory leak in Java when you keep a reference to an object that you no longer are actively working with.

E.g. If you had:

List<InputStreams> myStreams ; // Declared in your main class

// Then later
myStreams.add(is) ;   // The list of streams builds up over time and is never cleared out - this is a memory leak

Like CEHJ said, setting something to null removes the reference to it, so it certainly won't cause the leak.  It may avoid a leak.

Doug
0
 
LVL 16

Expert Comment

by:krakatoa
ID: 40385496
// Then later
 myStreams.add(is) ;   // The list of streams builds up over time and is never cleared out - this is a memory leak

Just curious Doug - how would this differ from a regular assignment?
0
 
LVL 12

Author Comment

by:jazzIIIlove
ID: 40387619
Hi Doug,

I guess your example would give a null pointer exception, not a leak as you didn't actually create the object. Please correct me if i am wrong.
0
 
LVL 86

Assisted Solution

by:CEHJ
CEHJ earned 400 total points
ID: 40387634
Please correct me if i am wrong.
He's assuming it was created ;)
0
 
LVL 86

Accepted Solution

by:
CEHJ earned 400 total points
ID: 40387656
What you really need to do is to refrain from investigating the theory behind a hypothesis that we've said is wrong in the first place and start asking the real question, which is "I have a memory leak - how can i find its cause?".

Firstly (forgetting what we've just discussed), do you have any suspicions at all of where it might be? If not, you might look at Surviving Generations analysis:

https://netbeans.org/kb/articles/nb-profiler-uncoveringleaks_pt1.html
0
 
LVL 86

Expert Comment

by:CEHJ
ID: 40391838
:)
0

Featured Post

Free Tool: Postgres Monitoring System

A PHP and Perl based system to collect and display usage statistics from PostgreSQL databases.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
netstat -ano | find "8000" and taskkill /f /pid 2984 3 84
couple of eclipse 5 46
maven disable workspace resolution 1 24
Is there a simpler dropbox system? 10 35
This was posted to the Netbeans forum a Feb, 2010 and I also sent it to Verisign. Who didn't help much in my struggles to get my application signed. ------------------------- Start The idea here is to target your cell phones with the correct…
Are you developing a Java application and want to create Excel Spreadsheets? You have come to the right place, this article will describe how you can create Excel Spreadsheets from a Java Application. For the purposes of this article, I will be u…
Viewers learn about the third conditional statement “else if” and use it in an example program. Then additional information about conditional statements is provided, covering the topic thoroughly. Viewers learn about the third conditional statement …
Viewers learn about the scanner class in this video and are introduced to receiving user input for their programs. Additionally, objects, conditional statements, and loops are used to help reinforce the concepts. Introduce Scanner class: Importing…

820 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question