Solved

setting a inputstream to null after closing it. Bad practice? Memory leaks?

Posted on 2014-10-16
9
170 Views
Last Modified: 2014-10-20
Hi;

I have the following code and not sure whether it will create a memory leak or not? What are the risks setting a inputstream to null after closing it. Bad practice?

public void close() throws IOException {
		System.out.println("Calling Test.close()...");
		if (is != null) {
			is.close();
			is = null;
		}
		System.out.println(Thread.currentThread().getName() + ":" + Thread.currentThread().getId() + ": Test.close() called!");
	}

Open in new window

0
Comment
Question by:jazzIIIlove
9 Comments
 
LVL 86

Assisted Solution

by:CEHJ
CEHJ earned 400 total points
ID: 40384054
In theory, very little needs to be explicitly set to null in Java owing to garbage collection. Occasionally you might want to do so to 'nudge' GC if a lot of resources are involved. That isn't the case with an InputStream. Why were you worrying about memory leaks?
0
 
LVL 12

Author Comment

by:jazzIIIlove
ID: 40384073
HI;

The code consequently accumulates and fills up all the heap space. I was thinking maybe this setting null is causing this. Can it?
0
 
LVL 86

Assisted Solution

by:CEHJ
CEHJ earned 400 total points
ID: 40384084
No. Setting something to null would normally do the reverse. The cause of your problem is elsewhere

e.g. NOT calling that method could cause a memory leak
0
 
LVL 26

Assisted Solution

by:dpearson
dpearson earned 100 total points
ID: 40385418
You get a memory leak in Java when you keep a reference to an object that you no longer are actively working with.

E.g. If you had:

List<InputStreams> myStreams ; // Declared in your main class

// Then later
myStreams.add(is) ;   // The list of streams builds up over time and is never cleared out - this is a memory leak

Like CEHJ said, setting something to null removes the reference to it, so it certainly won't cause the leak.  It may avoid a leak.

Doug
0
Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

 
LVL 16

Expert Comment

by:krakatoa
ID: 40385496
// Then later
 myStreams.add(is) ;   // The list of streams builds up over time and is never cleared out - this is a memory leak

Just curious Doug - how would this differ from a regular assignment?
0
 
LVL 12

Author Comment

by:jazzIIIlove
ID: 40387619
Hi Doug,

I guess your example would give a null pointer exception, not a leak as you didn't actually create the object. Please correct me if i am wrong.
0
 
LVL 86

Assisted Solution

by:CEHJ
CEHJ earned 400 total points
ID: 40387634
Please correct me if i am wrong.
He's assuming it was created ;)
0
 
LVL 86

Accepted Solution

by:
CEHJ earned 400 total points
ID: 40387656
What you really need to do is to refrain from investigating the theory behind a hypothesis that we've said is wrong in the first place and start asking the real question, which is "I have a memory leak - how can i find its cause?".

Firstly (forgetting what we've just discussed), do you have any suspicions at all of where it might be? If not, you might look at Surviving Generations analysis:

https://netbeans.org/kb/articles/nb-profiler-uncoveringleaks_pt1.html
0
 
LVL 86

Expert Comment

by:CEHJ
ID: 40391838
:)
0

Featured Post

Highfive Gives IT Their Time Back

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Suggested Solutions

For customizing the look of your lightweight component and making it look opaque like it was made of plastic.  This tip assumes your component to be of rectangular shape and completely opaque.   (CODE)
Introduction This article is the second of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers the basic installation and configuration of the test automation tools used by…
This tutorial covers a practical example of lazy loading technique and early loading technique in a Singleton Design Pattern.
Viewers will learn how to properly install Eclipse with the necessary JDK, and will take a look at an introductory Java program. Download Eclipse installation zip file: Extract files from zip file: Download and install JDK 8: Open Eclipse and …

706 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

21 Experts available now in Live!

Get 1:1 Help Now