string concatenation challenge

Hi,

I am working on below challenge
http://codingbat.com/prob/p117334

I wrote as below
public String stringSplosion(String str) {
  String s="";
  for(int i=0;i<=str.length()-1;i++){
  return (s+str.substring(i));
  
  }
  return null;
}

Open in new window

My test cases failing as below


Expected      Run            
stringSplosion("Code") → "CCoCodCode"      "Code"      X         
stringSplosion("abc") → "aababc"      "abc"      X         
stringSplosion("ab") → "aab"      "ab"      X         
stringSplosion("x") → "x"      "x"      OK         
stringSplosion("fade") → "ffafadfade"      "fade"      X         
stringSplosion("There") → "TThTheTherThere"      "There"      X         
stringSplosion("Kitten") → "KKiKitKittKitteKitten"      "Kitten"      X         
stringSplosion("Bye") → "BByBye"      "Bye"      X         
stringSplosion("Good") → "GGoGooGood"      "Good"      X         
stringSplosion("Bad") → "BBaBad"      "Bad"      X         

How do i fix and improve my code. Please advise
LVL 7
gudii9Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

n2fcCommented:
public String stringSplosion(String str) {
  String s="";
  for(int i=0;i<str.length();i++){
     s=s+str.substring(0,i+1);
  }
  return s;
}

Open in new window

0
krakatoaCommented:
Or
public String stringSplosion(String str) {


StringBuilder sb = new StringBuilder();

for(int y=0;y<str.length()+1;y++){sb.append(str.substring(0,y));}

return sb.toString();

  }

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
n2fcCommented:
Yet another solution (a tad more arcane):

public String stringSplosion(String str) {
   String s="";
   for(int i=0; i<str.length(); s+=str.substring(0, ++i));
   return s;
}

Open in new window

0
Cloud Class® Course: CompTIA Cloud+

The CompTIA Cloud+ Basic training course will teach you about cloud concepts and models, data storage, networking, and network infrastructure.

krakatoaCommented:
And one more, slightly better incremental model :

public String stringSplosion(String str) {

StringBuilder sb = new StringBuilder();

for(int y=0;y<str.length();y++){sb.append(str.substring(0,y+1));}

return sb.toString();
  }

Open in new window

0
gudii9Author Commented:
some reason stringbuilder is not coming to mind.

Let me read these solutions more detail once i get more time
0
krakatoaCommented:
StringBuilder is useful so yes do read the lit on it.
0
awking00Commented:
gudii9,
You have asked numerous questions involving the manipulation of strings. As I have mentioned in the past a String is an object, not a primitive datatype, and is immutable (meaning it can not be changed). However, methods may be applied to a String (e.g. using charArrays, concatenation, substrings, indexesOf, etc.) to create another String with the desired affect. The StringBuilder class was developed primarily to get around this fact. You seem to have eschewed the use of StringBuilder in favor of other methods, which is fine. It points out that there is almost always more than one way of accomplishing objectives in Java. In certain cases, methods other than StringBuilder might be easier to understand and write but, in many other cases, you will find that StringBuilder offers a better means of manipulating Strings. It behooves you to understand the many tools Java provides such as StringBuilder, which krakatoa suggests, and I second, you read up on.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Java

From novice to tech pro — start learning today.