Solved

string concatenation challenge

Posted on 2014-10-18
7
222 Views
Last Modified: 2014-10-20
Hi,

I am working on below challenge
http://codingbat.com/prob/p117334

I wrote as below
public String stringSplosion(String str) {
  String s="";
  for(int i=0;i<=str.length()-1;i++){
  return (s+str.substring(i));
  
  }
  return null;
}

Open in new window

My test cases failing as below


Expected      Run            
stringSplosion("Code") → "CCoCodCode"      "Code"      X         
stringSplosion("abc") → "aababc"      "abc"      X         
stringSplosion("ab") → "aab"      "ab"      X         
stringSplosion("x") → "x"      "x"      OK         
stringSplosion("fade") → "ffafadfade"      "fade"      X         
stringSplosion("There") → "TThTheTherThere"      "There"      X         
stringSplosion("Kitten") → "KKiKitKittKitteKitten"      "Kitten"      X         
stringSplosion("Bye") → "BByBye"      "Bye"      X         
stringSplosion("Good") → "GGoGooGood"      "Good"      X         
stringSplosion("Bad") → "BBaBad"      "Bad"      X         

How do i fix and improve my code. Please advise
0
Comment
Question by:gudii9
7 Comments
 
LVL 20

Assisted Solution

by:n2fc
n2fc earned 167 total points
ID: 40389342
public String stringSplosion(String str) {
  String s="";
  for(int i=0;i<str.length();i++){
     s=s+str.substring(0,i+1);
  }
  return s;
}

Open in new window

0
 
LVL 16

Accepted Solution

by:
krakatoa earned 166 total points
ID: 40389364
Or
public String stringSplosion(String str) {


StringBuilder sb = new StringBuilder();

for(int y=0;y<str.length()+1;y++){sb.append(str.substring(0,y));}

return sb.toString();

  }

Open in new window

0
 
LVL 20

Expert Comment

by:n2fc
ID: 40389372
Yet another solution (a tad more arcane):

public String stringSplosion(String str) {
   String s="";
   for(int i=0; i<str.length(); s+=str.substring(0, ++i));
   return s;
}

Open in new window

0
Master Your Team's Linux and Cloud Stack

Come see why top tech companies like Mailchimp and Media Temple use Linux Academy to build their employee training programs.

 
LVL 16

Expert Comment

by:krakatoa
ID: 40389386
And one more, slightly better incremental model :

public String stringSplosion(String str) {

StringBuilder sb = new StringBuilder();

for(int y=0;y<str.length();y++){sb.append(str.substring(0,y+1));}

return sb.toString();
  }

Open in new window

0
 
LVL 7

Author Comment

by:gudii9
ID: 40390039
some reason stringbuilder is not coming to mind.

Let me read these solutions more detail once i get more time
0
 
LVL 16

Expert Comment

by:krakatoa
ID: 40390078
StringBuilder is useful so yes do read the lit on it.
0
 
LVL 32

Assisted Solution

by:awking00
awking00 earned 167 total points
ID: 40392213
gudii9,
You have asked numerous questions involving the manipulation of strings. As I have mentioned in the past a String is an object, not a primitive datatype, and is immutable (meaning it can not be changed). However, methods may be applied to a String (e.g. using charArrays, concatenation, substrings, indexesOf, etc.) to create another String with the desired affect. The StringBuilder class was developed primarily to get around this fact. You seem to have eschewed the use of StringBuilder in favor of other methods, which is fine. It points out that there is almost always more than one way of accomplishing objectives in Java. In certain cases, methods other than StringBuilder might be easier to understand and write but, in many other cases, you will find that StringBuilder offers a better means of manipulating Strings. It behooves you to understand the many tools Java provides such as StringBuilder, which krakatoa suggests, and I second, you read up on.
0

Featured Post

MIM Survival Guide for Service Desk Managers

Major incidents can send mastered service desk processes into disorder. Systems and tools produce the data needed to resolve these incidents, but your challenge is getting that information to the right people fast. Check out the Survival Guide and begin bringing order to chaos.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
How to get all the API from website? 11 105
Error in @AspectJ Based AOP with Spring 2 18
login form jsp example 2 37
eclipse console opening separately 2 29
Introduction This article is the second of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers the basic installation and configuration of the test automation tools used by…
Whether you’re a college noob or a soon-to-be pro, these tips are sure to help you in your journey to becoming a programming ninja and stand out from the crowd.
This tutorial explains how to use the VisualVM tool for the Java platform application. This video goes into detail on the Threads, Sampler, and Profiler tabs.
The goal of the video will be to teach the user the concept of local variables and scope. An example of a locally defined variable will be given as well as an explanation of what scope is in C++. The local variable and concept of scope will be relat…

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question