Solved

Adding formula to range is taking too long using Access VBA syntax.

Posted on 2014-10-23
5
422 Views
Last Modified: 2014-10-23
Please note the following code.  At about the line:  For j = 2 To lLastRow I start to change the formulas for rows 2- 2000 in under column AR.   Please note I need to have the formula sum of AI through AP for each row under AR.   So I build this formula using for / each.  The problem is that it takes a little long to have the formula update for 2,000 rows - it can take 2-3 minutes to run.    Is there another syntax I can try that will update the range quicker?

  Dim xlApp As Object
  Dim xlBook As Object
  Dim xlSheet  As Object
  Dim sFormula As String  
  Dim rs As DAO.Recordset
  Dim j As Long
  Dim lLastRow As Long
 
  Set xlApp = CreateObject("Excel.Application")
  Set xlBook = xlApp.Workbooks.Open(sFile)
  
  Set xlSheet = xlBook.Worksheets(1)
  xlSheet.Activate
  xlSheet.Application.Visible = False
  
  Set rs = Application.CurrentProject.Application.CurrentDb.OpenRecordset(sSQLExcel)
  With xlSheet
    .Range(sRange).copyfromrecordset rs
    .Range("AR:AZ").NumberFormat = "$#,##0.00;$-#,##0.00;"""""
    lLastRow = 2000
    
    For j = 2 To lLastRow
      sFormula = "=SUM(AI" & j & ":AP" & j & ")"
      sFormula = Replace(sFormula, " ", "")
      .Range("AR" & j).Formula = sFormula
    Next j
    
  End With
  rs.Close
  Set rs = Nothing

  Set xlSheet = Nothing
  xlBook.Save
  xlBook.Close
  Set xlBook = Nothing
  Set xlApp = Nothing

Open in new window

0
Comment
Question by:stephenlecomptejr
  • 4
5 Comments
 
LVL 15

Accepted Solution

by:
Haris Djulic earned 500 total points
ID: 40400680
I added the code to disable calculations and screen updates until the code is completed then the calculation is turned on.


can you try the code now:

  Dim xlApp As Object
  Dim xlBook As Object
  Dim xlSheet  As Object
  Dim sFormula As String  
  Dim rs As DAO.Recordset
  Dim j As Long
  Dim lLastRow As Long
 
  Set xlApp = CreateObject("Excel.Application")
  Set xlBook = xlApp.Workbooks.Open(sFile)
  
  Set xlSheet = xlBook.Worksheets(1)
  xlSheet.Activate
  xlSheet.Application.Visible = False
  ' I disabled the automatic calculations and screen and status bar updates in order to speed up the process
Application.ScreenUpdating = False
Application.DisplayStatusBar = False
Application.Calculation = xlCalculationManual
  
  Set rs = Application.CurrentProject.Application.CurrentDb.OpenRecordset(sSQLExcel)
  With xlSheet
    .Range(sRange).copyfromrecordset rs
    .Range("AR:AZ").NumberFormat = "$#,##0.00;$-#,##0.00;"""""
    lLastRow = 2000
    
    For j = 2 To lLastRow
      sFormula = "=SUM(AI" & j & ":AP" & j & ")"
      sFormula = Replace(sFormula, " ", "")
      .Range("AR" & j).Formula = sFormula
    Next j
    
  End With
  rs.Close
  Set rs = Nothing


  ' I enabled the automatic calculations and screen and status bar updates in order to speed up the process
Application.ScreenUpdating = True
Application.DisplayStatusBar = FTrue
Application.Calculation = xlCalculationAutomatic

  Set xlSheet = Nothing
  xlBook.Save
  xlBook.Close
  Set xlBook = Nothing
  Set xlApp = Nothing

Open in new window

0
 
LVL 1

Author Comment

by:stephenlecomptejr
ID: 40401030
Since everything is late-binded your code does not work.

For example the debug dies at Application.ScreenUpdating = True   <--- which is at the period ScreenUpdating with a Compile error:  Method or data member not found.
0
 
LVL 1

Author Comment

by:stephenlecomptejr
ID: 40401040
Ok.  So I misspoke.  I just changed the one line of code that didn't implement late binding to this:
And I just added xlSheet. in front of the application code.

xlSheet.Application.ScreenUpdating = False
  xlSheet.Application.DisplayStatusBar = False
  xlSheet.Application.Calculation = -4135

Open in new window


xlSheet.Application.ScreenUpdating = True
  xlSheet.Application.DisplayStatusBar = True
  xlSheet.Application.Calculation = -4105

Open in new window


Thank you sincerely for your response!
0
 
LVL 1

Author Comment

by:stephenlecomptejr
ID: 40401041
I've requested that this question be closed as follows:

Accepted answer: 500 points for samo4fun's comment #a40400680
Assisted answer: 0 points for stephenlecomptejr's comment #a40401040

for the following reason:

Just needed a tweak on the code but the idea worked well.  Thank you sincerely for replying!
0
 
LVL 1

Author Closing Comment

by:stephenlecomptejr
ID: 40401042
Works great - need to give full points to this person's reply.  I appreciate it.
0

Featured Post

Enterprise Mobility and BYOD For Dummies

Like “For Dummies” books, you can read this in whatever order you choose and learn about mobility and BYOD; and how to put a competitive mobile infrastructure in place. Developed for SMBs and large enterprises alike, you will find helpful use cases, planning, and implementation.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

In a multiple monitor setup, if you don't want to use AutoCenter to position your popup forms, you have a problem: where will they appear?  Sometimes you may have an additional problem: where the devil did they go?  If you last had a popup form open…
Overview: This article:       (a) explains one principle method to cross-reference invoice items in Quickbooks®       (b) explores the reasons one might need to cross-reference invoice items       (c) provides a sample process for creating a M…
In Microsoft Access, learn the trick to repeating sub-report headings at the top of each page. The problem with sub-reports and headings: Add a dummy group to the sub report using the expression =1: Set the “Repeat Section” property of the dummy…
Access reports are powerful and flexible. Learn how to create a query and then a grouped report using the wizard. Modify the report design after the wizard is done to make it look better. There will be another video to explain how to put the final p…

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now