• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 139
  • Last Modified:

PHP Parse error: syntax error, unexpected '<' in /var/apache/lindamatthews.net/test/open.php on line 21

I get this error
Parse error: syntax error, unexpected '<' in /var/apache/lindamatthews.net/test/open.php on line 21
from the code below.

I assume that line 21 is creating the prevPicture button (though I don't really know) but I don't see a problem in the code.  Anyone else have sharper eyes than me?

<?php
ini_set("display_errors", "On");
error_reporting(E_ALL);

include("header.php");
include("menu.php");
$info=urldecode($_GET["info"]);
$info=explode("%f ", $info);
$c=$_GET["c"];
$r=$_GET["r"];

$row=explode("%i ",$info[$r]);
 
echo "<div class=\"content\">";

echo "<table><tr><td>";
echo "<img id=pic src=".$row[0]." style=height:425px><td style=width:3%;>";
echo "<td>".$row[1];
echo "<tr><td>All images copyright Linda Matthews.";
echo "<td><button onclick=\"prevPicture()\"> Previous </button>";
echo      <button onclick=\"history.go(-1);\"> Thumbnails </button>";
echo      <button onclick=\"nextPicture()\"> Next </button>";
echo "</table></div>";

include("footer.php");


echo "<script type="text/javascript">";
echo "    function prevPicture() {";
echo "        document.getElementById(\"pic\").src=\"art/zen03.jpg\";";
echo "    }";
echo "   function nextPicture() {";
echo "        document.getElementById(\"pic\").src=\"art/zen04.jpg\";";
echo "    }";
echo "</script>";

Open in new window

0
padmasambhava
Asked:
padmasambhava
  • 2
  • 2
1 Solution
 
Loganathan NatarajanLAMP DeveloperCommented:
correct this line,
echo "        document.getElementById(\'pic\').src=\'art/zen03.jpg\';";

Open in new window


also this line,
echo "        document.getElementById(\'pic\').src=\'art/zen04.jpg\';";

Open in new window

0
 
Radek BaranowskiFull-stack Java DeveloperCommented:
change after line 20 to:

echo "<td><button onclick=\"prevPicture()\"> Previous </button>
          <button onclick=\"history.go(-1);\"> Thumbnails </button>
          <button onclick=\"nextPicture()\"> Next </button>";
0
 
Loganathan NatarajanLAMP DeveloperCommented:
your entire code needs to be consistency on " and single quote
0
 
Ray PaseurCommented:
You can make this a lot easier if you learn about heredoc notation.

This kluge can be replaced...
echo "<div class=\"content\">";

echo "<table><tr><td>";
echo "<img id=pic src=".$row[0]." style=height:425px><td style=width:3%;>";
echo "<td>".$row[1];
echo "<tr><td>All images copyright Linda Matthews.";
echo "<td><button onclick=\"prevPicture()\"> Previous </button>";
echo      <button onclick=\"history.go(-1);\"> Thumbnails </button>";
echo      <button onclick=\"nextPicture()\"> Next </button>";
echo "</table></div>";

Open in new window


... by this, and you get free from all the fiddly punctuation and escape sequences.  You can line up the code, correct the markup, and get PHP variable substitution in HEREDOC.  It makes the programming much, much easier and far less error-prone! (I am not sure if this is the markup you want - I'm just trying to code it correctly for illustrative purposes.  Please treat this as untested code.)

$htm = <<<EOD
<div class="content">
<table>
  <tr>
    <td>
      <img id="pic" src="$row[0]" style="height:425px;" />
    </td>
    <td style="width:3%;">
    </td>
    <td>
      $row[1]
    </td>
  </tr>
  <tr>
    <td>
      All images copyright Linda Matthews
    </td>
    <td>
      <button onClick="prevPicture();"> Previous </button>
      <button onClick="history.go(-1);"> Thumbnails </button>
      <button onClick="nextPicture();"> Next </button>
    </td>
  </tr>
</table>
</div>
EOD;
echo $htm;

Open in new window


Sidebar note: You may also want to learn about the W3 validator.  The document at http://LindaMatthews.net cannot be validated because it starts with an HTML error!
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
<html>
<head>

Open in new window

0
 
Ray PaseurCommented:
This is kind of a different issue, but I noticed that one of the images in the site is 2995 x 1445 pixels - over 12 megabytes.  I have a lightning fast internet connection and it was slow even for my connection! Since it's being rendered as a 636 x 307 pixel element, it would make sense to create a separate copy of the original image and prepare it for use on the web.  This JPG version is only 21K, suggesting that it will load 590 times faster.
http://iconoun.com/demo/storage/art_img_0063.jpg

E-E has an Expert Testing "bugfinder" where you can submit a web site and the experts will look it over for things like this.  You might find it helpful.
http://www.experts-exchange.com/Expert_Testing/
0

Featured Post

Hire Technology Freelancers with Gigs

Work with freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely, and get projects done right.

  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now