Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 187
  • Last Modified:

.csv To .txt Follow Up

Hi Experts,

I have piece of code which import all .csv data in to one .csv file (import.csv) and create import.txt file from import.csv file. All is working well just need to add one more procedure while creating import.txt. Need to sort data in A to Z except header.
here is the code
Sub csvTotxt()
    Dim strData As String
    Dim oRE As Object
    Dim oMatches As Object
    Dim oM As Object
    Dim oSM As Object
    Dim oWsh As Object
    Const ForReading = 1, ForWriting = 2, ForAppending = 3
    Dim oFS As Object, oTS As Object
    Dim lngSM As Long
    Dim vOutput As Variant
    Const cPath As String = "C:\Test\"
    Const cHeader As String = "<ticker>,<per>,<date>,<open>,<high>,<low>,<close>,<vol>,<o/i>"
    
    Set oWsh = CreateObject("wscript.shell")
    Set oFS = CreateObject("Scripting.FileSystemObject")

    Set oRE = CreateObject("vbscript.regexp")
    oRE.Global = True
    oRE.Pattern = "(\w[^,]*),[^,]*,(\d[^,]*),([^,]*),([^,]*),([^,]*),[^,]*,[^,]*,([^,]*),[^,]*,([^,]*).*?,\n"
    
    'combine csv files
    oWsh.Run "cmd /c copy " & cPath & "*.csv " & cPath & "import.csv", 0, True
    
    Set oTS = oFS.OpenTextFile(cPath & "import.csv", ForReading, False, False)
    strData = oTS.readall
    oTS.Close
    Set oTS = oFS.OpenTextFile(cPath & "import.txt", ForWriting, True, False)
    oTS.writeline cHeader
    
    If oRE.test(strData) Then
        ReDim vdata(1 To 9)
        Set oMatches = oRE.Execute(strData)
        For Each oM In oMatches
            With oM
                vdata(1) = .submatches(0)
                vdata(2) = "D"
                vdata(3) = Format(.submatches(6), "yyyymmdd")
                vdata(4) = .submatches(1)
                vdata(5) = .submatches(2)
                vdata(6) = .submatches(3)
                vdata(7) = .submatches(4)
                vdata(8) = .submatches(5)
                vdata(9) = 0
                oTS.writeline Join(vdata, ",")
            End With
        Next
        oTS.Close
    End If
    
End Sub

Open in new window


Prior related question: http:Q_28526105.html

Please Help Me.

Thank you
0
Naresh Patel
Asked:
Naresh Patel
  • 10
  • 8
1 Solution
 
aikimarkCommented:
What about sorting the CSV file in Excel?
0
 
aikimarkCommented:
What fields are your sort keys?
0
 
Naresh PatelTraderAuthor Commented:
Column A I.e. Ticker

Thanks
0
Veeam Disaster Recovery in Microsoft Azure

Veeam PN for Microsoft Azure is a FREE solution designed to simplify and automate the setup of a DR site in Microsoft Azure using lightweight software-defined networking. It reduces the complexity of VPN deployments and is designed for businesses of ALL sizes.

 
aikimarkCommented:
Are you going to open the CSV file in Excel or use it some other way?
0
 
Naresh PatelTraderAuthor Commented:
I don't do any thing with CSV file ...I use only .txt file.

so expecting final result like this Final output  I not sure about how it will be done but logically I think this way, I may be completely wrong on this Assumption
i need only .txt file in sorted A to Z.

Thanks
0
 
aikimarkCommented:
If you can open the txt file in Excel, that is the most logical place to sort the data.
0
 
Naresh PatelTraderAuthor Commented:
Can't we done that automated ? I.e. sorted data in .import.txt ?

Thank you
0
 
Naresh PatelTraderAuthor Commented:
As I don't open any file ...I run my charting software add in which update data from this import.txt file ..if I go via unsorted data it will take 5 min and if I go via sorted data in import.txt file it will take for same amount of data only 30 sec.

Thanks
0
 
aikimarkCommented:
Do you have Notepad++?  Use it to sort the file
(already stated) Use Excel to sort the file
Can you run Powershell?  If so, use it to sort the file
0
 
aikimarkCommented:
Here is a quick and dirty attempt at doing the sort.
Sub csvTotxt()
    Dim strData As String
    Dim oRE As Object
    Dim oMatches As Object
    Dim oM As Object
    Dim oSM As Object
    Dim oWsh As Object
    Const ForReading = 1, ForWriting = 2, ForAppending = 3
    Dim oFS As Object, oTS As Object
    Dim lngSM As Long
    Dim vOutput As Variant
    Const cPath As String = "C:\Test\"
    
    '                          <ticker>
    Const cHeader As String = "!!!!!!!!,<per>,<date>,<open>,<high>,<low>,<close>,<vol>,<o/i>"
    
    Set oWsh = CreateObject("wscript.shell")
    Set oFS = CreateObject("Scripting.FileSystemObject")

    Set oRE = CreateObject("vbscript.regexp")
    oRE.Global = True
    oRE.Pattern = "(\w[^,]*),[^,]*,(\d[^,]*),([^,]*),([^,]*),([^,]*),[^,]*,[^,]*,([^,]*),[^,]*,([^,]*).*?,\n"
    
    'combine csv files
    oWsh.Run "cmd /c copy " & cPath & "*.csv " & cPath & "import.csv", 0, True
    
    Set oTS = oFS.OpenTextFile(cPath & "import.csv", ForReading, False, False)
    strData = oTS.readall
    oTS.Close
    
    Set oTS = oFS.OpenTextFile(cPath & "import.txt", ForWriting, True, False)
    oTS.writeline cHeader
    
    If oRE.test(strData) Then
        ReDim vdata(1 To 9)
        Set oMatches = oRE.Execute(strData)
        For Each oM In oMatches
            With oM
                vdata(1) = .submatches(0)
                vdata(2) = "D"
                vdata(3) = Format(.submatches(6), "yyyymmdd")
                vdata(4) = .submatches(1)
                vdata(5) = .submatches(2)
                vdata(6) = .submatches(3)
                vdata(7) = .submatches(4)
                vdata(8) = .submatches(5)
                vdata(9) = 0
                oTS.writeline Join(vdata, ",")
            End With
        Next
        oTS.Close
    End If
    
    oWsh.Run "cmd /c sort " & cPath & "import.txt /o " & cPath & "sortedimport.txt", 0, True
    
    Set oTS = oFS.OpenTextFile(cPath & "sortedimport.txt", ForReading, False, False)
    strData = oTS.readall
    oTS.Close
    
    strData = Replace(strData, "!!!!!!!!", "<ticker>")  'restore header
    
    Set oTS = oFS.OpenTextFile(cPath & "import.txt", ForWriting, True, False)
    oTS.write strData
    oTS.Close
    
    oFS.deletefile cPath & "sortedimport.txt"
End Sub

Open in new window

0
 
aikimarkCommented:
@David

The problem isn't as simple as that.  Visit the prior related question and look at the posted code for a better understanding.
0
 
David Johnson, CD, MVPOwnerCommented:
powershell script change as required
$infile = "F:\Downloads\cm01OCT2014bhav.csv"
$outfile = "C:\temp\outfile.txt"
$csv = import-csv -Path $infile  
$csv | sort-object  {$_.Symbol}|convertto-csv -NoTypeInformation | Out-File $outfile

Open in new window

0
 
aikimarkCommented:
as required
All the csv files in a directory have to be processed as described in the prior related question, not just a single file.  Moreover, only certain columns should be included in the output (one added and one formatted), and a new header supplied.
0
 
Naresh PatelTraderAuthor Commented:
M I missing something ....I had run this Code
and it is working fine.....please suggest may I close this question?

Thanks
0
 
Naresh PatelTraderAuthor Commented:
Mr.David Johnson, CD, MVP,

Your solution I dint tried as it is above my understanding.

Thank You
0
 
aikimarkCommented:
Sure.  If it solves the problem (answers the question), then accept that comment as the solution.
0
 
Naresh PatelTraderAuthor Commented:
Awesome ....Thank you very much.
0
 
Naresh PatelTraderAuthor Commented:
Mr.aikimark,

one request need to change path "C - Test" to "D:\AmiBroker Data\NSEeq".
I had change this path in code but getting error. please let me know what changes need to done.

Thanks
0
 
aikimarkCommented:
Did you follow the same pattern of the string constant file path in the accepted solution comment?

What does your code look like, specifically the const line?
0

Featured Post

Veeam Task Manager for Hyper-V

Task Manager for Hyper-V provides critical information that allows you to monitor Hyper-V performance by displaying real-time views of CPU and memory at the individual VM-level, so you can quickly identify which VMs are using host resources.

  • 10
  • 8
Tackle projects and never again get stuck behind a technical roadblock.
Join Now