Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 241
  • Last Modified:

array challenge error

hi

When i am trying below
http://codingbat.com/prob/p136041

as

public boolean array123(int[] nums) {
for(int num : nums){
if (num==1 || num==2|| num ==3){
return true;
}
}
  
}

Open in new window

getting error


Compile problems:


Error:      public boolean array123(int[] nums) {
                     ^^^^^^^^^^^^^^^^^^^^
This method must return a result of type boolean

Possible problem: the if-statement structure may theoretically
allow a run to reach the end of the method without calling return.
Consider adding a last line in the method return some_value;
so a value is always returned.


How to fix and improve. please advise
0
gudii9
Asked:
gudii9
  • 7
  • 3
  • 2
  • +1
3 Solutions
 
ozoCommented:
The compile error can be avoided by adding a
 return true;
at the end of the function after the if block

You will still need to improve the actual result.
0
 
dpearsonCommented:
I think you are not fully understanding what they are asking for in that question.

You need to check if the sequence 1,2,3 appears in the array.

Not if there is a 1 or a 2 or a 3 in the array.

Here's some code that checks for a sequence...but I've left it so it doesn't fully solve the problem.
Can you see how to adapt it to solve the problem?

You can add 2 lines to this and get the solution to the question, if you can figure out what 2 lines are needed...

Doug

public boolean array123(int[] nums) {
int target = 1 ;
for(int num : nums){
   if (num != target)
      target = 1 ;
      
   if (num == target)
     target++ ;
}

return false; 
}

Open in new window

0
 
ozoCommented:
Interestingly, for the purpose of passing the tests at http://codingbat.com/prob/p136041, the
   if (num != target)
      target = 1 ;
does not seem to be necessary.
Although it could have been necessary if certain other examples had been used in those tests.
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
gudii9Author Commented:
public boolean array123(int[] nums) {
for(int num : nums){
if (num==1 || num==2|| num ==3){
return true;
}
}
  
}

Open in new window


by adding return i pass some tests and failing on some other as below

Expected      Run            
array123({1, 1, 2, 3, 1}) → true      true      OK         
array123({1, 1, 2, 4, 1}) → false      true      X         
array123({1, 1, 2, 1, 2, 3}) → true      true      OK         
array123({1, 1, 2, 1, 2, 1}) → false      true      X         
array123({1, 2, 3, 1, 2, 3}) → true      true      OK         
array123({1, 2, 3}) → true      true      OK         
array123({1, 1, 1}) → false      true      X         
array123({1, 2}) → false      true      X         
array123({1}) → false      true      X         
array123({}) → false      false      OK         


But they seem not mentioned about the sequence any where in challenge though. I wonder why,

How i improve my code to pass other tests too.
Please advise
0
 
gudii9Author Commented:
how to solve usinjg simple for loop and if condition rather than foreach loop. please advise
0
 
awking00Commented:
I can see how you're getting confused about typical for loops and for-each loops as they are sometimes interchangeable and sometimes they are not, which is the case with this problem  In order to see if there is a 1 in the array followed by a 2 followed by a 3, you need to check 3 consecutive indexes of the array -
public boolean array123(int[] nums) {
  for (int j = 0; j < nums.length - 2; j++) {
    if (nums[j]==1 && nums[j+1]==2 && nums[j+2]==3) {
      return true;
    } else {
    return false;
    }
  }
}
0
 
gudii9Author Commented:
as they are sometimes interchangeable and sometimes they are not,

Can you please advise when they are not interchangeable?
0
 
gudii9Author Commented:
public boolean array123(int[] nums) {
  for (int j = 0; j < nums.length - 2; j++) {
    if (nums[j]==1 && nums[j+1]==2 && nums[j+2]==3) {
      return true;
    } else {
    return false;
    }
  }
}

Open in new window


when i ran above code getting below error in the site
Compile problems:


Error:      public boolean array123(int[] nums) {
                     ^^^^^^^^^^^^^^^^^^^^
This method must return a result of type boolean

Possible problem: the if-statement structure may theoretically
allow a run to reach the end of the method without calling return.
Consider adding a last line in the method return some_value;
so a value is always returned.
0
 
gudii9Author Commented:
public boolean array123(int[] nums) {
  for (int j = 0; j < nums.length - 2; j++) {
    if (nums[j]==1 && nums[j+1]==2 && nums[j+2]==3) {
      return true;
    } 
  }
  return false;
}

Open in new window

All tests passed when i ran as above
0
 
ozoCommented:
when they are not interchangeable?
Within a loop like
  for (int j = 0; j < nums.length - 2; j++) {
You can use j refer to an index into nums
Within a loop with
  for(int num : nums){
you can use num to refer to an element of nums

With a for(initialization; termination; increment) loop structure, you can change the initialization, the termination, and the increment.
If you want to change some of those things, this form may be preferable.
If you do not want to change those things, using the other form can help avoid mistakenly changing them.
0
 
gudii9Author Commented:
If you do not want to change those things, using the other form can help avoid mistakenly changing them.

can you please elaborate on this
0
 
awking00Commented:
I believe what ozo is trying to tell you is that with the example loop -
for (int j = 0; j < nums.length - 2; j++)
You don't have to start at index 0, you don't have to stop at any particular event, and you can increment (or decrement) by something other than one. With a for-each loop like (for (int num : nums), you are going to loop through every num that belongs in the group (array) of nums. You can't start or stop in the middle and you can't skip members of the group, but sometimes that's precisely what you want to occur and this format insures that. Note that is also insures no indexOutOfBounds exceptions.
0
 
gudii9Author Commented:
Note that is also insures no indexOutOfBounds exceptions.
I love this as i got it so many times :)
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 7
  • 3
  • 2
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now