Solved

Unix script to PING a list of devices and output the result to a txt file

Posted on 2014-11-04
8
502 Views
Last Modified: 2014-12-08
Hi

Im very new to Unix scripting and I'm having trouble running a basic script.  Id like to create a Unix script to PING a list of devices and output the result to a txt file.

Im trying to pull the list of devices from a txt file and then output the result to a txt file.

here is what I have so far.
--------------------------------------------------------------------------------------------------------------------------------------------------
#! /bin/bash

for $i in 'cat serverlist'
do
ping $i >> output.txt
done
----------------------------------------------------------------------------------------------------------------------------------------------------

I have tested this on a Cygwin installed on my windows box but i get the following error.

$ ./_Ping.sh
./_Ping.sh: line 2: $'\r': command not found
./.sh: line 4: syntax error near unexpected token `$'do\r''
'/.sh: line 4: `do

Any ideas?
0
Comment
Question by:tjoconnor
  • 4
  • 2
  • 2
8 Comments
 
LVL 23

Accepted Solution

by:
savone earned 500 total points
Comment Utility
You need backticks (not single quotes) to execute a command.  Also ping will continue forever in linux unless you put a count on it.

#!/bin/bash
for i in `cat serverlist`;
do
ping -c 2 $i >> ping
done
0
 
LVL 68

Expert Comment

by:woolmilkporc
Comment Utility
Several: problems:

1) Use backticks or $( ) around the "cat" command and don't use "$i" (that's the content of the variable "i") in the "for" line, use "i" alone:

for i in $(cat serverlist)
do
ping -c 1 $i >> output.txt
done

2) Your script file contains "carriage return + line feed" at the line ends. This is DOS standard and is wrong in Unix, which uses "linefeed" alone.
If you transferred the script file from Windows via FTP transfer it again using the "ASCII" transfer method, or edit the file in Unix and remove the extra carriage return characters.

3) Limit the number of ping attempts, so it will not run endlessly (see above)
0
 
LVL 23

Expert Comment

by:savone
Comment Utility
To explain further:

To execute a command in the for loop you have to use backticks (under the tilde on the keyboard) not single quotes.

The command "ping -c 2" tells the system to only ping it twice, otherwise it will go on forever and the script will never stop.
0
 
LVL 68

Expert Comment

by:woolmilkporc
Comment Utility
Note:

If you expect error messages from the "ping" command take care to store these messages in the log file or in a separate error log file instead of displaying them on your terminal:

1) One file:

ping -c 1 $i >> output.txt 2>&1

2) Separate error log:

ping -c 1 $i >> output.txt 2>>errors.txt
0
Highfive Gives IT Their Time Back

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 

Author Comment

by:tjoconnor
Comment Utility
Thanks for the responses. I seem to be ok with the file now as there is no error on the command line.

However my output file looks like this

Bad option -c.

Usage: ping [-t] [-a] [-n count] [-l size] [-f] [-i TTL] [-v TOS]
            [-r count] [-s count] [[-j host-list] | [-k host-list]]
            [-w timeout] [-R] [-S srcaddr] [-4] [-6] target_name
0
 
LVL 68

Expert Comment

by:woolmilkporc
Comment Utility
Your ping command does not support the "-c" flag. Which is your OS? HPUX?
It seems that you'll have to use "-n" instead:

ping -n 1 $i >> output.txt 2>>errors.txt
0
 

Author Comment

by:tjoconnor
Comment Utility
Hi

Yes I used -n 3 $I>>..... and it worked

Thanks a million for your help today guys, really appreciated it
0
 
LVL 68

Expert Comment

by:woolmilkporc
Comment Utility
You're always welcome!
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
change time in cron 4 37
Auto channel for WiFi (Access Point) 3 47
linux boot fsck problem 3 43
linux ssh 4 26
Using libpcap/Jpcap to capture and send packets on Solaris version (10/11) Library used: 1.      Libpcap (http://www.tcpdump.org) Version 1.2 2.      Jpcap(http://netresearch.ics.uci.edu/kfujii/Jpcap/doc/index.html) Version 0.6 Prerequisite: 1.      GCC …
I. Introduction There's an interesting discussion going on now in an Experts Exchange Group — Attachments with no extension (http://www.experts-exchange.com/discussions/210281/Attachments-with-no-extension.html). This reminded me of questions tha…
Learn how to navigate the file tree with the shell. Use pwd to print the current working directory: Use ls to list a directory's contents: Use cd to change to a new directory: Use wildcards instead of typing out long directory names: Use ../ to move…
This video shows how to set up a shell script to accept a positional parameter when called, pass that to a SQL script, accept the output from the statement back and then manipulate it in the Shell.

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now