Unix script to PING a list of devices and output the result to a txt file

Posted on 2014-11-04
Last Modified: 2014-12-08

Im very new to Unix scripting and I'm having trouble running a basic script.  Id like to create a Unix script to PING a list of devices and output the result to a txt file.

Im trying to pull the list of devices from a txt file and then output the result to a txt file.

here is what I have so far.
#! /bin/bash

for $i in 'cat serverlist'
ping $i >> output.txt

I have tested this on a Cygwin installed on my windows box but i get the following error.

$ ./
./ line 2: $'\r': command not found
./.sh: line 4: syntax error near unexpected token `$'do\r''
'/.sh: line 4: `do

Any ideas?
Question by:tjoconnor
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 2
  • 2
LVL 23

Accepted Solution

savone earned 500 total points
ID: 40421430
You need backticks (not single quotes) to execute a command.  Also ping will continue forever in linux unless you put a count on it.

for i in `cat serverlist`;
ping -c 2 $i >> ping
LVL 68

Expert Comment

ID: 40421432
Several: problems:

1) Use backticks or $( ) around the "cat" command and don't use "$i" (that's the content of the variable "i") in the "for" line, use "i" alone:

for i in $(cat serverlist)
ping -c 1 $i >> output.txt

2) Your script file contains "carriage return + line feed" at the line ends. This is DOS standard and is wrong in Unix, which uses "linefeed" alone.
If you transferred the script file from Windows via FTP transfer it again using the "ASCII" transfer method, or edit the file in Unix and remove the extra carriage return characters.

3) Limit the number of ping attempts, so it will not run endlessly (see above)
LVL 23

Expert Comment

ID: 40421433
To explain further:

To execute a command in the for loop you have to use backticks (under the tilde on the keyboard) not single quotes.

The command "ping -c 2" tells the system to only ping it twice, otherwise it will go on forever and the script will never stop.
Quiz: What Do These Organizations Have In Common?

Hint: Their teams ended up taking quizzes, too.

LVL 68

Expert Comment

ID: 40421445

If you expect error messages from the "ping" command take care to store these messages in the log file or in a separate error log file instead of displaying them on your terminal:

1) One file:

ping -c 1 $i >> output.txt 2>&1

2) Separate error log:

ping -c 1 $i >> output.txt 2>>errors.txt

Author Comment

ID: 40421507
Thanks for the responses. I seem to be ok with the file now as there is no error on the command line.

However my output file looks like this

Bad option -c.

Usage: ping [-t] [-a] [-n count] [-l size] [-f] [-i TTL] [-v TOS]
            [-r count] [-s count] [[-j host-list] | [-k host-list]]
            [-w timeout] [-R] [-S srcaddr] [-4] [-6] target_name
LVL 68

Expert Comment

ID: 40421517
Your ping command does not support the "-c" flag. Which is your OS? HPUX?
It seems that you'll have to use "-n" instead:

ping -n 1 $i >> output.txt 2>>errors.txt

Author Comment

ID: 40421540

Yes I used -n 3 $I>>..... and it worked

Thanks a million for your help today guys, really appreciated it
LVL 68

Expert Comment

ID: 40421585
You're always welcome!

Featured Post

The Orion Papers

Are you interested in becoming an AWS Certified Solutions Architect?

Discover a new interactive way of training for the exam.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Every server (virtual or physical) needs a console: and the console can be provided through hardware directly connected, software for remote connections, local connections, through a KVM, etc. This document explains the different types of consol…
Utilizing an array to gracefully append to a list of EmailAddresses
In a recent question ( here at Experts Exchange, a member asked how to run an AutoHotkey script (.AHK) directly from Notepad++ (aka NPP). This video…
How to Install VMware Tools in Red Hat Enterprise Linux 6.4 (RHEL 6.4) Step-by-Step Tutorial

705 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question