Solved

Removing an absolute value.  Folder path.

Posted on 2014-11-05
7
72 Views
Last Modified: 2014-11-07
I the following code I am checking to see if a specific file is open, if it is? Close it, if not? carry on.
Ln7 concerns me because it is an absolute folder location.  Is there a way to write that part out?
I have another procedure that uses that file and it needs to be closed in order to process correctly.
Please advise and thanks.

PS:  Will consider other re-writes too.  It shows my lack of VBA writing skills.


Sub IsSalesOrderDownloadTemplateOpen()
 
 Dim I As Integer
 Dim bIsOpened
    For I = 1 To Application.Workbooks.Count
        If (Application.Workbooks(I).Name = "SALESORDERDOWNLOAD.XML" _
            And Application.Workbooks(I).Path = "C:\_SAP\Extracts\SalesOrd") Then
            bIsOpened = True
            Exit For
        End If
    Next I

 
'  For i = 1 To Application.Workbooks.Count
'   bIsOpened = bIsOpened Or (Application.Workbooks(i).Name = "SALESORDERDOWNLOAD.XML" _
'   And Application.Workbooks(i).Path = "C:\_SAP\Extracts\SalesOrd")
'  Next i

  If bIsOpened Then
    MsgBox "Target save file is open, Closing file so process can use it.", vbOKOnly + vbInformation, "Cannot have: C:\_SAP\EXTRACTS\SALESORD\SALESORDERDOWNLOAD.xml open and run this process.  Close it and try again."
    Application.DisplayAlerts = False
    Windows("SALESORDERDOWNLOAD.XML").Activate
    ActiveWorkbook.Close
    bIsOpened = False
    Application.DisplayAlerts = True
    GoTo 100  'Removed Exit Sub
  Else
   GoTo 100
  End If
100  'Continue knowing that file is not open.
End Sub

Open in new window

0
Comment
Question by:RWayneH
  • 4
  • 2
7 Comments
 

Author Comment

by:RWayneH
ID: 40424100
I may have to leave that in.  I am assuming that I can use a network path like:
\\na\Global-Groups\etc.\etc.\   or even better a sharepoint site?:  
http://departments.haworthinc.com/PLM/data/Lists/IPL%20Data/DispForm.aspx?ID=38&Source=http%3A%2F%2Fdepartments%2Ehaworthinc%2Ecom%2FPLM%2Fdata%2FLists%2FIPL%2520Data%2FIPL%2520data%2Easpx

I do not know how to point to a specific sharepoint file... and how to add the code if a user does not even have access to the particular site.   I am good with leaving it in, and need to change that Ln7 to point to sharepoint location.
0
 
LVL 32

Assisted Solution

by:Rob Henson
Rob Henson earned 50 total points
ID: 40425910
If a Workbook is open then you may be able to use the Windows.Activate(FileName) command to show it.

I believe this would only need the filename.

Therefore, if the file is not open the above command would generate an error. An error handler would then skip the step or carry on with the close.

Thanks
Rob H
0
 

Author Comment

by:RWayneH
ID: 40425984
So what you are saying is it would be something like:?

If  Windows("SALESORDERDOWNLOAD.XML").Activate = False
    continue
End if

If  Windows("SALESORDERDOWNLOAD.XML").Activate = True
   Close it without saving changes.
   Continue
End if
0
Does Powershell have you tied up in knots?

Managing Active Directory does not always have to be complicated.  If you are spending more time trying instead of doing, then it's time to look at something else. For nearly 20 years, AD admins around the world have used one tool for day-to-day AD management: Hyena. Discover why

 
LVL 32

Accepted Solution

by:
Robberbaron (robr) earned 450 total points
ID: 40426015
my versions of RobH idea...

dim OrderFileName as string, isOpen as boolean
OrderSheetName = "SALESORDERDOWNLOAD.XML"

on error resume next  '<<turn on error trap
isOpen = false
Windows(OrderSheetName ).Activate
if Err.Number = 0 then
   isOpen=True
 else
  isOpen = False
end if
on error goto 0  '<<turn off error trap

Open in new window

0
 

Author Comment

by:RWayneH
ID: 40426167
How would we add a if true, close file without saving changes...  I do not want alerts to stop and ask user if it is ok ....  Looks like this will work much better than the original one I had.  Thanks!!
0
 
LVL 32

Assisted Solution

by:Robberbaron (robr)
Robberbaron (robr) earned 450 total points
ID: 40428146
if IsOpen then
   ActiveWorkbook.Close SaveChanges:=False
end if

Open in new window

0
 

Author Closing Comment

by:RWayneH
ID: 40429381
Thanks for the help.
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Workbook link problems after copying tabs to a new workbook? David Miller (dlmille) Intro Have you either copied sheets to a new workbook, and after having saved and opened that workbook, you find that there are links back to the original sou…
Do you use a spreadsheet like Microsoft's Excel?  Have you ever wanted to link out to a non excel file on your computer or network drive?  This is the way I found to do it!
This Micro Tutorial demonstrates how to create Excel charts: column, area, line, bar, and scatter charts. Formatting tips are provided as well.
This Micro Tutorial demonstrates using Microsoft Excel pivot tables, how to reverse engineer competitors' marketing strategies through backlinks.

803 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question