?
Solved

Removing an absolute value.  Folder path.

Posted on 2014-11-05
7
Medium Priority
?
79 Views
Last Modified: 2014-11-07
I the following code I am checking to see if a specific file is open, if it is? Close it, if not? carry on.
Ln7 concerns me because it is an absolute folder location.  Is there a way to write that part out?
I have another procedure that uses that file and it needs to be closed in order to process correctly.
Please advise and thanks.

PS:  Will consider other re-writes too.  It shows my lack of VBA writing skills.


Sub IsSalesOrderDownloadTemplateOpen()
 
 Dim I As Integer
 Dim bIsOpened
    For I = 1 To Application.Workbooks.Count
        If (Application.Workbooks(I).Name = "SALESORDERDOWNLOAD.XML" _
            And Application.Workbooks(I).Path = "C:\_SAP\Extracts\SalesOrd") Then
            bIsOpened = True
            Exit For
        End If
    Next I

 
'  For i = 1 To Application.Workbooks.Count
'   bIsOpened = bIsOpened Or (Application.Workbooks(i).Name = "SALESORDERDOWNLOAD.XML" _
'   And Application.Workbooks(i).Path = "C:\_SAP\Extracts\SalesOrd")
'  Next i

  If bIsOpened Then
    MsgBox "Target save file is open, Closing file so process can use it.", vbOKOnly + vbInformation, "Cannot have: C:\_SAP\EXTRACTS\SALESORD\SALESORDERDOWNLOAD.xml open and run this process.  Close it and try again."
    Application.DisplayAlerts = False
    Windows("SALESORDERDOWNLOAD.XML").Activate
    ActiveWorkbook.Close
    bIsOpened = False
    Application.DisplayAlerts = True
    GoTo 100  'Removed Exit Sub
  Else
   GoTo 100
  End If
100  'Continue knowing that file is not open.
End Sub

Open in new window

0
Comment
Question by:RWayneH
  • 4
  • 2
7 Comments
 

Author Comment

by:RWayneH
ID: 40424100
I may have to leave that in.  I am assuming that I can use a network path like:
\\na\Global-Groups\etc.\etc.\   or even better a sharepoint site?:  
http://departments.haworthinc.com/PLM/data/Lists/IPL%20Data/DispForm.aspx?ID=38&Source=http%3A%2F%2Fdepartments%2Ehaworthinc%2Ecom%2FPLM%2Fdata%2FLists%2FIPL%2520Data%2FIPL%2520data%2Easpx

I do not know how to point to a specific sharepoint file... and how to add the code if a user does not even have access to the particular site.   I am good with leaving it in, and need to change that Ln7 to point to sharepoint location.
0
 
LVL 34

Assisted Solution

by:Rob Henson
Rob Henson earned 200 total points
ID: 40425910
If a Workbook is open then you may be able to use the Windows.Activate(FileName) command to show it.

I believe this would only need the filename.

Therefore, if the file is not open the above command would generate an error. An error handler would then skip the step or carry on with the close.

Thanks
Rob H
0
 

Author Comment

by:RWayneH
ID: 40425984
So what you are saying is it would be something like:?

If  Windows("SALESORDERDOWNLOAD.XML").Activate = False
    continue
End if

If  Windows("SALESORDERDOWNLOAD.XML").Activate = True
   Close it without saving changes.
   Continue
End if
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
LVL 33

Accepted Solution

by:
Robberbaron (robr) earned 1800 total points
ID: 40426015
my versions of RobH idea...

dim OrderFileName as string, isOpen as boolean
OrderSheetName = "SALESORDERDOWNLOAD.XML"

on error resume next  '<<turn on error trap
isOpen = false
Windows(OrderSheetName ).Activate
if Err.Number = 0 then
   isOpen=True
 else
  isOpen = False
end if
on error goto 0  '<<turn off error trap

Open in new window

0
 

Author Comment

by:RWayneH
ID: 40426167
How would we add a if true, close file without saving changes...  I do not want alerts to stop and ask user if it is ok ....  Looks like this will work much better than the original one I had.  Thanks!!
0
 
LVL 33

Assisted Solution

by:Robberbaron (robr)
Robberbaron (robr) earned 1800 total points
ID: 40428146
if IsOpen then
   ActiveWorkbook.Close SaveChanges:=False
end if

Open in new window

0
 

Author Closing Comment

by:RWayneH
ID: 40429381
Thanks for the help.
0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Freeze panes is an option within all variants of Excel to enable parts of a sheet to remain stationary when the cursor is in another part of the sheet. This is a very useful feature which is overlooked or under used.
You need to know the location of the Office templates folder, so that when you create new templates, they are saved to that location, and thus are available for selection when creating new documents.  The steps to find the Templates folder path are …
Many functions in Excel can make decisions. The most simple of these is the IF function: it returns a value depending on whether a condition you describe is true or false. Once you get the hang of using the IF function, you will find it easier to us…
Enter Foreign and Special Characters Enter characters you can't find on a keyboard using its ASCII code ... and learn how to make a handy reference for yourself using Excel ~ Use these codes in any Windows application! ... whether it is a Micr…

578 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question