HP L3 Switch, SHoretel Voip and QOS/Prioritisation best practices

Im stuck on how best to achieve a reliable qos on our voice network.

HQ Overview:
Cisco Router (managed)
Cisco ASA 5505 (managed)
HP 2910al Poe L3 Switch (ours) - vlan1 - data & vlan20 - voice,            /         2x HP 1910s - vlan1 only
ingate siparator                                                                                       /           printers/computers
Shoretel kit, switches, director, etc..

My issue now is with regard to quality, so looking at deploying QOS.  I have added a prioritisation rule but not sure if the answer..
The phones are configured: 802.1q, tagging on, vlanid20.
Should i tag all vlan20 ports?  Currently all are untagged.  Phone direct in switch, not daisy chained.
Should i enabled voice on the vlan20 or is the rule sufficient?
vlan1 or primary, correct?

The current switch L3 config:
Running configuration:

; J9148A Configuration Editor; Created on release #W.15.08.0012
; Ver #02:11.05:16
hostname "HP-E2910al-48G-PoE"
module 1 type j9148a
mirror-port 5
power-over-ethernet pre-std-detect
qos type-of-service diff-services
timesync sntp
sntp unicast
sntp server priority 1
sntp server priority 2
time timezone 60
ip authorized-managers access manager
ip authorized-managers access manager
ip authorized-managers access manager
ip authorized-managers access manager
ip authorized-managers access manager
ip authorized-managers access manager
ip authorized-managers access manager
ip default-gateway
no ip icmp redirects
ip route
ip routing
interface 1
   name "to HP1910 (top)"
   no power-over-ethernet
interface 2
   name "tp HP1910 (bottom)"
   no power-over-ethernet
interface 3
   name "to ASA 5505 fe01"
   no power-over-ethernet
interface 4
   name "Cisco_AP_172.19.3.20"
interface 5
   no power-over-ethernet
interface 6
   no power-over-ethernet
interface 7
   name "Shoretel E1k"
   speed-duplex 100-full
interface 8
   name "Shoretel SG90"
   speed-duplex 100-full
interface 9
   name "Shoretel SG90Bri"
   speed-duplex 100-full
interface 10
   name "chi-Oaisys"
interface 11
   name "Shoretel HQ"
interface 12
   name "Ingate"
interface 14
   name "Test Phone"
snmp-server community "public" unrestricted
snmp-server contact "IT"
vlan 1
   name "DEFAULT_VLAN"
   no untagged 7-48
   untagged 1-6
   ip address
vlan 20
   name "Voice"
   untagged 7-48
   ip address
   ip helper-address
   ip helper-address
   qos dscp 101110
no autorun
password manager

Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Your configuration should be fine.  If the phones and Shortel gear are connected to the same physical switch and running in the same VLAN untagged, QoS should not be needed at all on VLAN 20 and is only adding complexity you don't need.

Do your calls go in/out via PRI/s or VOIP trunks?  If VOIP, then you need to prioritize (QoS) at the WAN edge for traffic between your VOIP trunk provider and your Shoretel system.  (I think this would just be the siparotor, but I'd need some additional clarification about your config, like a drawing.)

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
CHI-LTDAuthor Commented:
others on here are saying we need qos regardless...

calls go over sip trunks.  yes we use a siperator.

internet - cisco router - cisco firewall - ingate and l3 hp switch - phones and shoretel kit

everything gatewaying through the switch.
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Switches / Hubs

From novice to tech pro — start learning today.