Link to home
Start Free TrialLog in
Avatar of Dead_Eyes
Dead_EyesFlag for United Kingdom of Great Britain and Northern Ireland

asked on

powershell joinging strings without a space

Hi, I am still learning PowerShell and attempting to resolve a problem I found when exploring the functionality of the ForEach-Object Cmdlet. When I attempt to join the 2 variables a space appears in between them and I can't seem to get rid of it no matter what I try. I think its something to do with the Output field separator but after trying several different tactics to change it I am at a loss. I have noticed if I use a txt file instead of a .csv & Get-Content the problem does not occur but using .txt files would limit the use's I am envisioning for ForEach-Object. Can anyone offer a solution preferably with an explanation of why and how to manipulate variables in the loop? thanks in advance

$var1 = Import-Csv -Path D:\Book1.csv
$Ending = "@Domain.com"
$Var1 | ForEach-Object {
Write-Host $_.Name,$Ending
}
Avatar of Raheman M. Abdul
Raheman M. Abdul
Flag of United Kingdom of Great Britain and Northern Ireland image

use the following instead: ( 2 single quotes with no space in between)

write-host $_.Name,$Ending -Separator ''
ASKER CERTIFIED SOLUTION
Avatar of Neil Russell
Neil Russell
Flag of United Kingdom of Great Britain and Northern Ireland image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Avatar of Dead_Eyes

ASKER

Hi, thanks for the quick response unfortunately both suggestions did not work and just errored out :(
Sorry, a TYPO in mine.

write-host "$($_.name)$ending"

. not ,
Sorry take that back I just made a school boy syntax error. Thanks for the response's. Neilsr I like your phrasing but  Raheman Mohammed Abdul's answer looks far more easy to understand when learning. Could you point me to the how and why of your syntax? thanks
OK, using $variables inside a string is normally just a case of doing "$variablename" and the contents of the variable will be used in the string.

However when you are using an object property, i.e.  $_.name ,  where $_ is an object and .name is a property of the object, you need to use the "$($variable.property)" method.  the $() around the variable and property just instruct powershell to treat the contents between the $(  and the  )  as a whole variable expression.

Without the $() around it, "$variable.property"  would be evaluated as $variable followed by the litteral text of ".property"

Hope thats clear?
Sorry and finally would this work in a loop like this:
$var1 = Import-Csv -Path D:\Book1.csv
$Ending = "@Domain.com"
$Var1 | ForEach-Object {
New-ADUser -Name $_.Name -UserPrincipalName $_.Name,$Ending -Separator ''
}
# Or using the 2nd example
$var1 = Import-Csv -Path D:\Book1.csv
$Ending = "@Domain.com"
$Var1 | ForEach-Object {
New-ADUser -Name $_.Name -UserPrincipalName "$($_.name)$ending"
}
The first would not no but the second yes.
Once you understand the concept of using "$($var.prop)" you can build complex strings quick and easily.
Thanks for the great explanation and the extra help Neilsr. I am getting it now
You could have an object called $User with properties of firstname, lastname and Domain for example and the email address would be.....

"$($User.firstname).$($User.lastname)@$($User.Domain)"

The . and the @ between the $($) pairs are literal chars so will get, for example.

Fred.Blogs@SomeDomain.com
Oops zero points even I posted the correct answer and the first one to post
Sorry Raheman I know your answer was correct but Neilsr really went the extra mile with a great explanation and his way is far more flexible