Azure has a changed a lot since it was originally introduce by adding new services and features. Do you know everything you need to about Azure? This course will teach you about the Azure App Service, monitoring and application insights, DevOps, and Team Services.
2 workbooks but vba routine to keep current workbook open but close saveas copy
I have a vba routine that is not working properly.
I have a current workbook: I need to keep open
I have a second workbook i'm opening...getting additional string for saveas and then I just need to close the saveas workbook.
Current workbook "MyExcel1.xlsx"
In the code below i'm opening another workbook , doing a SaveAs and Then closing it.
but keeping my current workbook open.
THIS CODE IS CLOSING MY CURRENT WORKBOOK ALSO ?
Thanks
fordraiders
I have a current workbook: I need to keep open
I have a second workbook i'm opening...getting additional string for saveas and then I just need to close the saveas workbook.
Current workbook "MyExcel1.xlsx"
In the code below i'm opening another workbook , doing a SaveAs and Then closing it.
but keeping my current workbook open.
THIS CODE IS CLOSING MY CURRENT WORKBOOK ALSO ?
Public Sub CmeSaveAs()
Dim oldwkbk As String
Dim excelwrk As Excel.Application
Dim newdate As String
Dim sInput As String
Set excelwrk = Excel.Application
excelwrk.Workbooks.Open "C:\Program Files\Cme\Template_DoNot_Open\Export_Cme_Template.xlsx"
excelwrk.Visible = False
sInput = InputBox("Enter File name here")
' saveas and then close please
excelwrk.ActiveWorkbook.SaveAs "C:\Program Files\Cme\Cme_Export\" & sInput & "_" & newdate
excelwrk.ActiveWorkbook.Close
End Sub
Thanks
fordraiders
Asked:
Who is Participating?
You should use these to variables:
Dim currentwb As Workbook
Dim NewBook As Workbook
Assign currentwb to Current workbook "MyExcel1.xlsx"
then open the other one using
Set newbook = excelwrk.Workbooks.Open "C:\Program Files\Cme\Template_DoNot_O
Now you have these seperated and closing and opening and saving is much more clear!
In this case, NewBook.SaveAs and NewBook.Close
As you can see, you fixed currentwb and newbook. With Activeworkbook, it keeps changing almost out of your control (while possible, it's much harder to keep track of).
Dim currentwb As Workbook
Dim NewBook As Workbook
Assign currentwb to Current workbook "MyExcel1.xlsx"
then open the other one using
Set newbook = excelwrk.Workbooks.Open "C:\Program Files\Cme\Template_DoNot_O
Now you have these seperated and closing and opening and saving is much more clear!
In this case, NewBook.SaveAs and NewBook.Close
As you can see, you fixed currentwb and newbook. With Activeworkbook, it keeps changing almost out of your control (while possible, it's much harder to keep track of).
kimcomputer,
error on this line ?
Set newbook = excelwrk.Workbooks.Open "C:\Program Files\Cme\Template_DoNot_O
error on this line ?
Set newbook = excelwrk.Workbooks.Open "C:\Program Files\Cme\Template_DoNot_O
Set newbook = excelwrk.Workbooks.Open("C
ok,
profesor jim,
I commented out
' excelwrk.Visible = False
'added
excelwrk.ActiveWorkbook.Cl
now it works.?
profesor jim,
I commented out
' excelwrk.Visible = False
'added
excelwrk.ActiveWorkbook.Cl
now it works.?
Thanks for the points. Though a bit sad you didn't apply the code, as not only do you make less mistakes (using clearly defined workbooks as opposed to activeworkbook), it's also easier to read the code much later when you forgot about it (or someone else reads it).
Question has a verified solution.
Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.
Have a better answer? Share it in a comment.
All Courses
From novice to tech pro — start learning today.
Open in new window
toOpen in new window
also remove the line activeworkbook.clsoe