Solved

Excel - variable to apply to active workbook?

Posted on 2014-12-04
2
73 Views
Last Modified: 2014-12-04
Hello Experts,

I have two workbooks - one with a macro and a button to trigger it (wkbk1), and one with data (wkbk2 - it's actually a csv file).  The following works just fine when I run it from within wkbk2:

Dim LR As Long
LR = Range("A" & Rows.Count).End(xlUp).Row
'open the csv file and begin formatting the data
'the following line is commented out when running it from within the csv file
'but is un-commented when I run it from the external workbook
'Workbooks.Open Filename:="F:\Folder\File.csv"

'shift column M to the right
Columns("M:M").Select
Selection.Insert Shift:=xlToRight, CopyOrigin:=xlFormatFromLeftOrAbove

'insert formula into M2
Range("M2").Select
ActiveCell.FormulaR1C1 = "=IF(RC[-1]=0,""No"",""Yes"")"

'paste the formula down column M to the last populated cell
Range("M2").AutoFill Destination:=Range("M2:M" & LR)

'copy header from L1 to M1
Range("L1").Select
Selection.Copy
Range("M1").Select
ActiveSheet.Paste
Range("A2").Select

'turn off alerts to save over the existing file
Application.DisplayAlerts = False

'save the csv file as an xlsx file
ChDir "F:\Folder"
ActiveWorkbook.SaveAs Filename:="F:\Folder\File.xlsx", _
FileFormat:=xlOpenXMLWorkbook, CreateBackup:=False

'turn on alerts again
Application.DisplayAlerts = True

'close the workbook
Workbooks("File.xlsx").Close

'exit Excel
Application.Quit

Open in new window


But I need it to run from another workbook (wkbk1).  However, it places the formula in M2, copies it to M1, and then moves on to the next step (copying the column header from L1 to M1) without pasting the formula down column M.  It appears that LR is based on column A of wkbk1 and not wkbk2.  I need LR to be based on column A in wkbk2, the active workbook, not wkbk1.  

Any help would be greatly appreciated.

I am using Excel 2010 on Windows 7.

Thanks,
J
0
Comment
Question by:ferguson_jerald
2 Comments
 
LVL 18

Accepted Solution

by:
Simon earned 500 total points
ID: 40481204
Move line 2 of your code to just below line 6, so that the row count isn't done until the csv file is opened.

Like this:
Dim LR As Long

'open the csv file and begin formatting the data
'the following line is commented out when running it from within the csv file
'but is un-commented when I run it from the external workbook
Workbooks.Open Filename:="F:\Folder\File.csv"
LR = Range("A" & Rows.Count).End(xlUp).Row --Count the used rows in the newly opened file.

'shift column M to the right
Columns("M:M").Select
Selection.Insert Shift:=xlToRight, CopyOrigin:=xlFormatFromLeftOrAbove

Open in new window

0
 

Author Closing Comment

by:ferguson_jerald
ID: 40481217
Excellent!  Thanks!
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Drop Down List with Unique/Distinct Values (enhancing the Combo-Box with a few steps and a little code) David miller (dlmille) Intro Have you ever created a data validation list from a database field or spreadsheet column (e.g., Zip Codes or Co…
This article will guide you to convert a grid from a picture into Excel format using Microsoft OneNote and no other 3rd party application.
The viewer will learn how to use the =DISCRINV command to create a discrete random variable, use this command to model a set of probabilities and outcomes in a Monte Carlo simulation, and learn how to find the standard deviation of a set of probabil…
This Micro Tutorial will demonstrate in Google Sheets how to use the HYPERLINK function to create live links inside your spreadsheet.

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

23 Experts available now in Live!

Get 1:1 Help Now