multiple definition of method

class Shape
{

public:
    BLOCK blocks[4];
    SHAPE_TYPE whoami;
    friend Table;
    Table *tbl;
    // Default constructor
    Shape() {};
    //Shape(Table *tbl) { this->tbl = tbl;}
public:
    // non-virtual
    void DrawSingleBlock(BLOCK block)
    {
        RECT rect;
        HBRUSH brush = CreateSolidBrush(RGB(0, 255, 0));

        rect.top    = (*tbl).initial_point.y + block.Y * (*tbl).cell.height;
        rect.left   = (*tbl).initial_point.x + block.X * (*tbl).cell.width;
        rect.bottom = rect.top + tbl->cell.height;
        rect.right  = rect.left + tbl->cell.width;

        FillRect(tbl->hdc, &rect, brush);
    }

    // virtual
    virtual void Draw(void) {};
    virtual void Rotate(ROTATE_DIR rdir){ return; };
    virtual bool isRotatable(ROTATE_DIR rdir){ return false;};
};

class LineShape : public Shape
{
public:
    LineShape();
    LineShape(Table *tbl, BLOCK start_block)
    {
        this->tbl = tbl;
    for (int i = 0; i < 4; i++)
    {
        this->blocks[i].X = start_block.X;
        this->blocks[i].Y = start_block.Y + i;
    }
    }

public:
    bool isRotatable(ROTATE_DIR rdir) { return false; };
    void Rotate(ROTATE_DIR rdir) { return; };

    void Draw(void); // {     }
};

/*
LineShape::LineShape(Table *tbl, BLOCK start_block) : Shape(tbl)
{

}

*/
void LineShape::Draw(void)
{
for (int i = 0; i < 4; i++)
        {
            DrawSingleBlock(blocks[i]);
        }
}

Open in new window





||=== Build: Debug in Tetris (compiler: GNU GCC Compiler) ===|
obj\Debug\Table.o||In function `ZN9LineShape4DrawEv':|
C:\codeblocks\Tetris\Table.h|128|multiple definition of `LineShape::Draw()'|
obj\Debug\main.o:C:\codeblocks\Tetris\table.h|128|first defined here|
||=== Build failed: 2 error(s), 0 warning(s) (0 minute(s), 1 second(s)) ===|


Where is that "multiple" definition?
Nusrat NuriyevAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

HooKooDooKuCommented:
The parent class 'Shape' has a Draw function that is declared as virtual.
The child class 'LineShape' has a Draw function this is not declared as virtual.  
Since LineShape inherited the virtual Draw of Shape, you have two different definitions of Draw in LineShape.

Simply add the virtual key word to your Draw function in LineShape.  That way, the Draw function in LineShape will "over-ride" the Draw function it inherited from Shape.
0
Nusrat NuriyevAuthor Commented:
nope


class Shape
{

public:
    BLOCK blocks[4];
    SHAPE_TYPE whoami;
    friend Table;
    Table *tbl;
    // Default constructor
    Shape() {};
    //Shape(Table *tbl) { this->tbl = tbl;}
public:
    // non-virtual
    void DrawSingleBlock(BLOCK block)
    {
        RECT rect;
        HBRUSH brush = CreateSolidBrush(RGB(0, 255, 0));

        rect.top    = (*tbl).initial_point.y + block.Y * (*tbl).cell.height;
        rect.left   = (*tbl).initial_point.x + block.X * (*tbl).cell.width;
        rect.bottom = rect.top + tbl->cell.height;
        rect.right  = rect.left + tbl->cell.width;

        FillRect(tbl->hdc, &rect, brush);
    }

    // virtual
    virtual void Draw(void) {};
    virtual void Rotate(ROTATE_DIR rdir){ return; };
    virtual bool isRotatable(ROTATE_DIR rdir){ return false;};
};

class LineShape : public Shape
{
public:
    LineShape();
    LineShape(Table *tbl, BLOCK start_block)
    {
        this->tbl = tbl;
    for (int i = 0; i < 4; i++)
    {
        this->blocks[i].X = start_block.X;
        this->blocks[i].Y = start_block.Y + i;
    }
    }

public:
    bool isRotatable(ROTATE_DIR rdir) { return false; };
    void Rotate(ROTATE_DIR rdir) { return; };

    virtual void Draw(void); // {     }
};

/*
LineShape::LineShape(Table *tbl, BLOCK start_block) : Shape(tbl)
{

}

*/
void LineShape::Draw(void)
{
    for (int i = 0; i < 4; i++)
            {
                DrawSingleBlock(blocks[i]);
            }
}

Open in new window


this does not work.
0
Nusrat NuriyevAuthor Commented:
However,

class Shape
{

public:
    BLOCK blocks[4];
    SHAPE_TYPE whoami;
    friend Table;
    Table *tbl;
    // Default constructor
    Shape() {};
    //Shape(Table *tbl) { this->tbl = tbl;}
public:
    // non-virtual
    void DrawSingleBlock(BLOCK block)
    {
        RECT rect;
        HBRUSH brush = CreateSolidBrush(RGB(0, 255, 0));

        rect.top    = (*tbl).initial_point.y + block.Y * (*tbl).cell.height;
        rect.left   = (*tbl).initial_point.x + block.X * (*tbl).cell.width;
        rect.bottom = rect.top + tbl->cell.height;
        rect.right  = rect.left + tbl->cell.width;

        FillRect(tbl->hdc, &rect, brush);
    }

    // virtual
    virtual void Draw(void) {};
    virtual void Rotate(ROTATE_DIR rdir){ return; };
    virtual bool isRotatable(ROTATE_DIR rdir){ return false;};
};

class LineShape : public Shape
{
public:
    LineShape();
    LineShape(Table *tbl, BLOCK start_block)
    {
        this->tbl = tbl;
    for (int i = 0; i < 4; i++)
    {
        this->blocks[i].X = start_block.X;
        this->blocks[i].Y = start_block.Y + i;
    }
    }

public:
    bool isRotatable(ROTATE_DIR rdir) { return false; };
    void Rotate(ROTATE_DIR rdir) { return; };

    virtual void Draw(void)  {   for (int i = 0; i < 4; i++)
            {
                DrawSingleBlock(blocks[i]);
            } }
};

Open in new window


this does work.

Again, what is the problem?
0
CompTIA Security+

Learn the essential functions of CompTIA Security+, which establishes the core knowledge required of any cybersecurity role and leads professionals into intermediate-level cybersecurity jobs.

HooKooDooKuCommented:
It works for me.

The following code was compiled using Microsoft Visual Stdio 2010.  I created a new project.  I added a file "Shape.cpp" to the project, and inserted the following code (note the dummy classes I had to create to account for the "missing" source code your sample didn't include).
#include "stdafx.h"

class BLOCK
{
public:
	int X;
	int Y;
};

class Cell
{
public:
	int height;
	int width;
};

#define SHAPE_TYPE int
#define ROTATE_DIR int

class Table
{
public:
	Table(){};
	POINT initial_point;
	Cell cell;
	HDC hdc;
};

class Shape
{
public:
    BLOCK blocks[4];
    SHAPE_TYPE whoami;
    friend Table;
    Table *tbl;
    // Default constructor
    Shape() {};
    //Shape(Table *tbl) { this->tbl = tbl;}
public:
    // non-virtual
    void DrawSingleBlock(BLOCK block)
    {
        RECT rect;
        HBRUSH brush = CreateSolidBrush(RGB(0, 255, 0));

        rect.top    = (*tbl).initial_point.y + block.Y * (*tbl).cell.height;
        rect.left   = (*tbl).initial_point.x + block.X * (*tbl).cell.width;
        rect.bottom = rect.top + tbl->cell.height;
        rect.right  = rect.left + tbl->cell.width;

        FillRect(tbl->hdc, &rect, brush);
    }

    // virtual
    virtual void Draw(void) {};
    virtual void Rotate(ROTATE_DIR rdir){ return; };
    virtual bool isRotatable(ROTATE_DIR rdir){ return false;};
};

class LineShape : public Shape
{
public:
    LineShape();
    LineShape(Table *tbl, BLOCK start_block)
    {
        this->tbl = tbl;
    for (int i = 0; i < 4; i++)
    {
        this->blocks[i].X = start_block.X;
        this->blocks[i].Y = start_block.Y + i;
    }
    }

public:
    bool isRotatable(ROTATE_DIR rdir) { return false; };
    void Rotate(ROTATE_DIR rdir) { return; };

    virtual void Draw(void); // {     }
};

/*
LineShape::LineShape(Table *tbl, BLOCK start_block) : Shape(tbl)
{

}

*/
void LineShape::Draw(void)
{
    for (int i = 0; i < 4; i++)
            {
                DrawSingleBlock(blocks[i]);
            }
}

Open in new window


Logically, your latest two samples are the same.  The only difference is the 2nd didn't define the Draw() function 'in-line'.  But that shouldn't matter.
0
sarabandeCommented:
if you put the implementation of a non-template function into a header file, and don't make it inline, the compiler would generate a copy of the function for each cpp file where you included the header file and put the compiled code to the object file (*.o) which was the output (file) of the compilation.

the linker than complains a duplicate implementation when it tries to bind both object files to one executable.

to solve the issue, you have a few choices:

(1) move the implementation of LineShape::Draw to a new cpp file
     and add the cpp to project file or makefile.
(2) implement the function directly in the class definition (what makes it inline)
(3) declare the function as inline in the class
(4) make the class a template class. then the compiler will compile the
     functions inline when they were used rather than when the header was compiled.

Sara
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Nusrat NuriyevAuthor Commented:
or.
(5) declare the function as inline in header file but not in the class.

I have used  (1).
About (5).
Are the all function  inline in template class?
0
sarabandeCommented:
no, the functions are not really 'inline' but the compilation of the function happens in the calling function when a concrete template type was known and the template was instantiated with that type.

for example if you have class MyContainer<T> with member function 'void insert(const T & t)', the MyContainer<short::insert(const short & t)  was compiled if you do like

...
MyContainer<short> mys;  // here the class was instantiated
mys.insert(-1);                       // here the insert function was compiled (if 1st call)

Open in new window


but, different to an inline function, the compiler doesn't embed the code into the calling function but adds a new function and a call. if the same function was called again, it uses the same function module (while an inline function would be embedded again)  

(5) declare the function as inline in header file but not in the class.
where do you see a difference to (3) ?

Sara
0
Nusrat NuriyevAuthor Commented:
Thanks,
where do you see a difference to (3) ?
Nowhere, it was an illusion.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
C++

From novice to tech pro — start learning today.