Solved

SQL Server Query sum case

Posted on 2014-12-10
10
181 Views
Last Modified: 2014-12-10
I have a problem with a particular query that I am working on.  The following two queries work fine:

SELECT
    sum(case when ((r3000+r4000+r6000) / 3) < '26' then 1 else 0 end) as 'NORMAL',
    sum(case when ((r3000+r4000+r6000) / 3) between '26' and '40' then 1 else 0 end) as 'MILD',
    sum(case when ((r3000+r4000+r6000) / 3) between '41' and '55' then 1 else 0 end) as 'MODERATE',
    sum(case when ((r3000+r4000+r6000) / 3) between '56' and '70' then 1 else 0 end) as 'MODERATELY-SEVERE',
    sum(case when ((r3000+r4000+r6000) / 3) between '71' and '90' then 1 else 0 end) as 'SEVERE',
    sum(case when ((r3000+r4000+r6000) / 3) > '90' then 1 else 0 end) as 'PROFOUND'
FROM Audio

SELECT
    sum(case when ((l3000+l4000+l6000) / 3) < '26' then 1 else 0 end) as 'NORMAL',
    sum(case when ((l3000+l4000+l6000) / 3) between '26' and '40' then 1 else 0 end) as 'MILD',
    sum(case when ((l3000+l4000+l6000) / 3) between '41' and '55' then 1 else 0 end) as 'MODERATE',
    sum(case when ((l3000+l4000+l6000) / 3) between '56' and '70' then 1 else 0 end) as 'MODERATELY-SEVERE',
    sum(case when ((l3000+l4000+l6000) / 3) between '71' and '90' then 1 else 0 end) as 'SEVERE',
    sum(case when ((l3000+l4000+l6000) / 3) > '90' then 1 else 0 end) as 'PROFOUND'
FROM Audio

But, I want to combine these two into one, with a condition, so that the sums are performed on the larger of r3000+r4000+r6000 or l3000+l4000+l6000

I cant seem to fine the right query to do this.  Below is what I want, but I am getting an error..
Msg 156, Level 15, State 1, Line 3
Incorrect syntax near the keyword 'as'.


SELECT
      case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
      sum(case when ((r3000+r4000+r6000) / 3) < '26' then 1 else 0 end) as 'NORMAL',
        sum(case when ((r3000+r4000+r6000) / 3) between '26' and '40' then 1 else 0 end) as 'MILD',
        sum(case when ((r3000+r4000+r6000) / 3) between '41' and '55' then 1 else 0 end) as 'MODERATE',
        sum(case when ((r3000+r4000+r6000) / 3) between '56' and '70' then 1 else 0 end) as 'MODERATELY-SEVERE',
        sum(case when ((r3000+r4000+r6000) / 3) between '71' and '90' then 1 else 0 end) as 'SEVERE',
        sum(case when ((r3000+r4000+r6000) / 3) > '90' then 1 else 0 end) as 'PROFOUND'
else             
      sum(case when ((l3000+l4000+l6000) / 3) < '26' then 1 else 0 end) as 'NORMAL',
        sum(case when ((l3000+l4000+l6000) / 3) between '26' and '40' then 1 else 0 end) as 'MILD',
        sum(case when ((l3000+l4000+l6000) / 3) between '41' and '55' then 1 else 0 end) as 'MODERATE',
        sum(case when ((l3000+l4000+l6000) / 3) between '56' and '70' then 1 else 0 end) as 'MODERATELY-SEVERE',
        sum(case when ((l3000+l4000+l6000) / 3) between '71' and '90' then 1 else 0 end) as 'SEVERE',
        sum(case when ((l3000+l4000+l6000) / 3) > '90' then 1 else 0 end) as 'PROFOUND'
end
FROM Audio
0
Comment
Question by:dpinchot
  • 4
  • 3
  • 2
  • +1
10 Comments
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 40491849
>< '26'

must be
< 26

otherwise you are doing a implicit data type conversion ...
the quotes is ONLY for text values, not for numerical values

as 'NORMAL',

must be either
as [NORMAL],
as NORMAL,
as "NORMAL",

again, the single quotes are for string values
the double quotes or [ ] is for names (identifiers), and they are optional unless you have special characters/reserved keywords etc...
0
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 40491865
also, you cannot build 2 column lists with a included CASE construct like this:::

so you must restructure like this:
SELECT
        sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
                           case when ((r3000+r4000+r6000) / 3) < 26  then 1 else 0 end
                   else case when ((l3000+l4000+l6000) / 3) < 26 then 1 else 0 end
              )
        as [NORMAL]

FROM Audio
0
 

Author Comment

by:dpinchot
ID: 40491885
Guy, Thanks for the assistance on the syntax issues.  I modifies the query, but I am getting the same error.

Incorrect syntax near the keyword 'as'.
0
PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

 
LVL 51

Expert Comment

by:HainKurt
ID: 40491887
try this

with x as (
select a.*, case when r3000+r4000+r6000 >= l3000+l4000+l6000 then r3000+r4000+r6000/3 else l3000+l4000+l6000/3 end as average
from audio a
)
select *,
case 
when average between 0 and 25 then 'NORMAL'
when average between 26 and 40 then 'MODERATE'
...
end as Status
from x

Open in new window

0
 
LVL 51

Expert Comment

by:HainKurt
ID: 40491895
or if you just need counts

with x as (
select case when r3000+r4000+r6000 >= l3000+l4000+l6000 then r3000+r4000+r6000/3 else l3000+l4000+l6000/3 end as average
from audio a
)
select 
sum(case when average between 0 and 25 then 1 else 0 end ) as 'NORMAL',
sum(case when average between 26 and 40 then 1 else 0 end) as 'MODERATE',
...
from x

Open in new window

0
 

Author Comment

by:dpinchot
ID: 40491905
Guy,

I made a slight modification to your solution, and it ran just fine. t needed an extra end before the last )

SELECT
        sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
              case when ((r3000+r4000+r6000) / 3) < 26 then 1 else 0 end
              else
            case when ((l3000+l4000+l6000) / 3) < 26 then 1 else 0 end
              end ) as NORMAL
FROM Audio
0
 

Author Comment

by:dpinchot
ID: 40491936
The final solution with Guy's code looks like this, and it works great. Thanks for the help on this.

SELECT
        sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
              case when ((r3000+r4000+r6000) / 3) < 26 then 1 else 0 end
              else
                    case when ((l3000+l4000+l6000) / 3) < 26 then 1 else 0 end
              end ) as [NORMAL],
        sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
              case when ((l3000+l4000+l6000) / 3) between 26 and 40 then 1 else 0 end
              else
                    case when ((l3000+l4000+l6000) / 3) between 26 and 40 then 1 else 0 end
              end ) as [MILD],
            sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
              case when ((l3000+l4000+l6000) / 3) between 41 and 55 then 1 else 0 end
              else
                    case when ((l3000+l4000+l6000) / 3) between 41 and 55 then 1 else 0 end
              end ) as [MODERATE],
            sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
              case when ((l3000+l4000+l6000) / 3) between 56 and 70 then 1 else 0 end
              else
                    case when ((l3000+l4000+l6000) / 3) between 56 and 70 then 1 else 0 end
              end ) as [MODERATELY-SEVERE],
            sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
              case when ((l3000+l4000+l6000) / 3) between 71 and 90 then 1 else 0 end
              else
                    case when ((l3000+l4000+l6000) / 3) between 71 and 90 then 1 else 0 end
              end ) as [SEVERE],
            sum(case when r3000+r4000+r6000 >= l3000+l4000+l6000 then
              case when ((l3000+l4000+l6000) / 3) > 90 then 1 else 0 end
              else
                    case when ((l3000+l4000+l6000) / 3) > 90 then 1 else 0 end
              end ) as [PROFOUND]
FROM Audio
0
 
LVL 51

Expert Comment

by:HainKurt
ID: 40491943
the one I posted above (ID: 40491895) should do the same and it is very simple & readable...

did you try that?
0
 

Author Comment

by:dpinchot
ID: 40492296
I am  boarding a flight, but I will try it out when I can get back to my laptop.
0
 
LVL 48

Expert Comment

by:PortletPaul
ID: 40493272
I agree with HainKurt, I think the use of case within case leads to overly complex code.

Just as a tip however you don't have to use WITH AS (...) instead you can use CROSS APPLY like this:
SELECT
      SUM(CASE
            WHEN ca.average BETWEEN 0 AND 25 THEN 1
            ELSE 0
      END) AS 'NORMAL'
    , SUM(CASE
            WHEN ca.average BETWEEN 26 AND 40 THEN 1
            ELSE 0
      END) AS 'MODERATE'--,
FROM audio
      CROSS APPLY (
            SELECT
                  CASE
                        WHEN r3000 + r4000 + r6000 >= l3000 + l4000 + l6000 THEN r3000 + r4000 + r6000 / 3
                        ELSE l3000 + l4000 + l6000 / 3
                  END AS average
      ) AS ca

Open in new window

0

Featured Post

Networking for the Cloud Era

Join Microsoft and Riverbed for a discussion and demonstration of enhancements to SteelConnect:
-One-click orchestration and cloud connectivity in Azure environments
-Tight integration of SD-WAN and WAN optimization capabilities
-Scalability and resiliency equal to a data center

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

     When we have to pass multiple rows of data to SQL Server, the developers either have to send one row at a time or come up with other workarounds to meet requirements like using XML to pass data, which is complex and tedious to use. There is a …
Ever needed a SQL 2008 Database replicated/mirrored/log shipped on another server but you can't take the downtime inflicted by initial snapshot or disconnect while T-logs are restored or mirror applied? You can use SQL Server Initialize from Backup…
Two types of users will appreciate AOMEI Backupper Pro: 1 - Those with PCIe drives (and haven't found cloning software that works on them). 2 - Those who want a fast clone of their boot drive (no re-boots needed) and it can clone your drive wh…
This video shows how to quickly and easily add an email signature for all users on Exchange 2016. The resulting signature is applied on a server level by Exchange Online. The email signature template has been downloaded from: www.mail-signatures…

856 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question