Change my ASP Function

Public Function Logic

IF WarehouseID = 1 Then Len(ProductID) < 8 Then ProductID = Right(String(8, "0") & ProductID, 8)
    FormatTEDProductID = "ARP" & ProductID
elseif

   WarehouseID = 2 Then Len(ProductID) < 8 Then ProductID = Right(String(8, "0") & ProductID, 8)
    FormatTEDProductID = "ELI" & ProductID

My current fuction is just

Public Function FormatTEDProductID (ProductID)
    If Len(ProductID) < 8 Then ProductID = Right(String(8, "0") & ProductID, 8)
    FormatTEDProductID = "ARP" & ProductID
End Function

Open in new window


The table has both ProductID and WarehouseID


How would I go about doing this?
FreerToolAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
try:

Public Function FormatTEDProductID (ProductID, WarehouseID)
    If WarehouseID = 1 and Len(ProductID) < 8  Then 
           ProductID = Right(String(8, "0") & ProductID, 8)
           FormatTEDProductID = "ARP" & ProductID
    elseif WarehouseID = 2 and Len(ProductID) < 8 Then 
           ProductID = Right(String(8, "0") & ProductID, 8)
           FormatTEDProductID = "ELI" & ProductID
   end if    
End Function

Open in new window


note the 2nd parameter of WarehouseID in your function
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
this assumes both of your values are of valid INT types. You may want to check that before the if statement:

Public Function FormatTEDProductID (ProductID, WarehouseID)
    if not isNumeric( ProductID ) then
         ProductID = 0
    else
         ProductID = CInt( ProductID )
    end if
    if not isNumeric( WarehouseID ) then
         WarehouseID = 0
    else
         WarehouseID = CInt( WarehouseID )
    end if


    If WarehouseID = 1 and Len(ProductID) < 8  Then
           ProductID = Right(String(8, "0") & ProductID, 8)
           FormatTEDProductID = "ARP" & ProductID
    elseif WarehouseID = 2 and Len(ProductID) < 8 Then
           ProductID = Right(String(8, "0") & ProductID, 8)
           FormatTEDProductID = "ELI" & ProductID
   end if    
End Function
0
FreerToolAuthor Commented:
Getting error  An error occurred on the server when processing the URL. Please contact the system administrator

with both and yes they are both  integers.
0
Newly released Acronis True Image 2019

In announcing the release of the 15th Anniversary Edition of Acronis True Image 2019, the company revealed that its artificial intelligence-based anti-ransomware technology – stopped more than 200,000 ransomware attacks on 150,000 customers last year.

Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
post your updated code
0
Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
I just stuck the code below in a blank asp page and got the appropriate results. If you're getting  an error, it has to do with the values you're passing into the function

<%
Public Function FormatTEDProductID (ProductID, WarehouseID)
    if not isNumeric( ProductID ) then 
         ProductID = 0
    else
         ProductID = CInt( ProductID )
    end if
    if not isNumeric( WarehouseID ) then 
         WarehouseID = 0
    else
         WarehouseID = CInt( WarehouseID )
    end if

    If WarehouseID = 1 and Len(ProductID) < 8  Then 
           ProductID = Right(String(8, "0") & ProductID, 8)
           FormatTEDProductID = "ARP" & ProductID
    elseif WarehouseID = 2 and Len(ProductID) < 8 Then 
           ProductID = Right(String(8, "0") & ProductID, 8)
           FormatTEDProductID = "ELI" & ProductID
   end if    
End Function

    Response.Write FormatTEDProductID( 4, 1 ) & "<br/></br>"
    Response.Write FormatTEDProductID( 4, 2 )

    
%>

Open in new window

0
HainKurtSr. System AnalystCommented:
here it is:

Public Function FormatTEDProductID (WarehouseID , ProductID)
    If Len(ProductID) < 8 Then ProductID = Right(String(8, "0") & ProductID, 8)
    FormatTEDProductID = iif(WarehouseID = 1, "ARP", "ELI") & ProductID
End Function

Open in new window


pass WarehouseID , ProductID to the function...
0
FreerToolAuthor Commented:
I think thats my problem is that i am not passing the warehouseID properly to the function.


<p class="listProductPartNumber"><b>Product Number:</b> <%=FormatTEDProductID(RsProduct("ProductID").Value)%>

Is where I am Formatting my ProductID   I am just trying to figure how i pass it to the function here.
0
HainKurtSr. System AnalystCommented:
use function i posted above with this:

<p class="listProductPartNumber"><b>Product Number:</b> <%=FormatTEDProductID(RsProduct("WarehouseID").Value, RsProduct("ProductID").Value)%>
0
HainKurtSr. System AnalystCommented:
remember, the function I posted above assumes, you have only 1 or 2 as WarehouseID

Logic is this: Add "ARP" if warehouse=1 or add "ELI" otherwise...
0
Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
assuming WarehouseID is from your recordset, you would do:

<p class="listProductPartNumber"><b>Product Number:</b> <%=FormatTEDProductID(RsProduct("ProductID").Value, RsProduct("WarehouseID").Value)%> 

Open in new window


Using the function I gave does an error check for you, if your ProductIDs and WarehouseID's are empty, or not int values, it makes sure no error is produced.

also, sometimes values from a recordset are treated as strings, even if they are numbers, so it's a good idea to convert them (using CInt()) to make sure the if statement works properly
0
FreerToolAuthor Commented:
Yeah i have troubleshoot some more but neither of your guys code is working for me.  I must not be passing the WarehouseID properly. I get a blank white page when i update.
0
Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
where is WarehouseID coming from, the recordset? can you confirm there is ALWAYS a WarehouseID in the data set coming back from the database?

if you hard code values in the function, does it work then?
0
HainKurtSr. System AnalystCommented:
this should work fine

<p class="listProductPartNumber"><b>Product Number:</b> <%=FormatTEDProductID(RsProduct("WarehouseID").Value, RsProduct("ProductID").Value)%>

with this code

Public Function FormatTEDProductID (WarehouseID , ProductID)
    If Len(ProductID) < 8 Then ProductID = Right(String(8, "0") & ProductID, 8)
    FormatTEDProductID = iif(WarehouseID = 1, "ARP", "ELI") & ProductID
End Function

Open in new window


what do you get here?

Product Number: ??????

if you do not get any error, warehouseid is not coming from db correctly, o/w you get error!

try passing 1 as hardcoded value and try

<p class="listProductPartNumber"><b>Product Number:</b> <%=FormatTEDProductID(1, RsProduct("ProductID").Value)%>
0
FreerToolAuthor Commented:
so I am checking all my pages that have the warehouseID  that i need to pass.  for example.

http://www.automationrecovery.com/categories/Automation-Surplus/
0
Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
and did you try hard coding the IDs like I suggested? are there ALWAYS productIDs as well?
0
Big MontySenior Web Developer / CEO of ExchangeTree.org Commented:
it looks like product number is displaying properly as I see it shown in your page.

it looks like your link is not correct, can you post the code for it and what you expect to happen on the next page along with its code?
0
FreerToolAuthor Commented:
sorry take a look at it now.
0
FreerToolAuthor Commented:
Its working fine now, thanks for your assistance Big Monty
0
HainKurtSr. System AnalystCommented:
and what is the solution & why I did not get any share?
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
ASP

From novice to tech pro — start learning today.