Solved

Transitioning to PDO/MySQL.  Need assistance with if/else statement

Posted on 2014-12-21
5
297 Views
Last Modified: 2014-12-21
Are changes necessary for if/else statements in PHP/PDO?

I am getting the following error:
Parse error: syntax error, unexpected 'catidexp1' (T_STRING)

(Script works fine without if/else statement)



$query3 = $conn->query('SELECT DISTINCT cat1, catidexp1 FROM download ORDER BY catidexp1);

while ($row3 = $query3->fetch(PDO::FETCH_ASSOC))
{

 if $row3['catidexp1']==0 {      //error here
continue; 
} else {



$statement = $conn->prepare('INSERT INTO category (category_id) VALUES(:catid)');
$params = array(':catid'=>$row3['catidexp1']);
$statement->execute($params); 

}

Open in new window

0
Comment
Question by:lawrence_dev
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
5 Comments
 
LVL 58

Accepted Solution

by:
Gary earned 450 total points
ID: 40512197
Is that your real code?
You are missing the closing apostrophe
$query3 = $conn->query('SELECT DISTINCT cat1, catidexp1 FROM download ORDER BY catidexp1');

Open in new window


Also don't put prepared statements inside a loop, put them before you loop - their purpose is to tell MySQL what to expect, not keep telling it what is coming...

$statement = $conn->prepare('INSERT INTO category (category_id) VALUES(:catid)');
0
 
LVL 17

Assisted Solution

by:Chris Millard
Chris Millard earned 50 total points
ID: 40512199
Change line 6 to:-

 if ($row3['catidexp1']==0) {
0
 
LVL 110

Expert Comment

by:Ray Paseur
ID: 40512208
Parse error: syntax error, unexpected ...
always means something is wrong "upstream" from the line with the error.  It may be the line above or a line many lines above.  Typically this is due to missing or unmatched parentheses, quotes, etc.

This has nothing to do with PDO, per se -- it's a PHP syntax error that may have been introduced by a conversion from MySQL to a current SQL extension, but looking to PDO for an answer is a red herring.  Instead, go back to the basic PHP syntax and you'll find the error through that process.
0
 

Author Closing Comment

by:lawrence_dev
ID: 40512231
Agreed Gary!  Thanks for your help!  Thanks Chris!
0
 

Author Comment

by:lawrence_dev
ID: 40512264
Take 30 seconds to look at the code to see the mistake and point it out. ---  100% Agree!  Thanks again for your help!!
0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Part of the Global Positioning System A geocode (https://developers.google.com/maps/documentation/geocoding/) is the major subset of a GPS coordinate (http://en.wikipedia.org/wiki/Global_Positioning_System), the other parts being the altitude and t…
Many old projects have bad code, but the budget doesn't exist to rewrite the codebase. You can update this code to be safer by introducing contemporary input validation, sanitation, and safer database queries.
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn how to count occurrences of each item in an array.

739 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question