php string comparison, why the same?

Hi all,

When I test the string comparison functions, I do not understand why they are equal.

This is the script:
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Comparaison de chaînes de caractères</title>
</head>
<body>
<?php
$str1 = "033123456789";
$str2 = "+33456789087";

$sub1 = substr($str1, 0, 3);
$sub2 = substr($str2, 0, 3);

echo $sub1 . " -- " . $sub2 . "<br>";

if (strcmp($sub1, $sub2) !== 0) {
	echo "The strings are equal.<br>";
} else {
	echo "The strings are not equal.<br>";
}

?>
</body>
</html>

Open in new window


And this is what I have in my browser:
033 -- +33
The strings are equal.

Open in new window


My version of PHP is 5.2.17
LVL 1
Richard Coffree-commerce Product ManagerAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

FarWestCommented:
it looks like treating '+' as 0

I think you can do work around by comparing sha1 output
if (strcmp(sha1($sub1), sha1($sub2)) !== 0) {
	echo "The strings are equal.<br>";
} else {
	echo "The strings are not equal.<br>";
}

Open in new window

0
Brian TaoSenior Business Solutions ConsultantCommented:
Because you're echoing "The strings are equal.<br>" when they are not!
Change the !== to == in line 17.
0
Richard Coffree-commerce Product ManagerAuthor Commented:
Oups,

The weird code is:
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Comparaison de chaînes de caractères</title>
</head>
<body>
<?php
$str1 = "033123456789";
$str2 = "+33456789087";

$sub1 = substr($str1, 0, 3);
$sub2 = substr($str2, 0, 3);

echo $sub1 . " -- " . $sub2 . "<br>";

if ($sub1 == $sub2) {
	echo "The strings are equal.<br>";
} else {
	echo "The strings are not equal.<br>";
}

?>
</body>
</html>

Open in new window


The output is:
033 -- +33
The strings are equal.

Open in new window

0
CompTIA Network+

Prepare for the CompTIA Network+ exam by learning how to troubleshoot, configure, and manage both wired and wireless networks.

GaryCommented:
Use === for a type and value comparison else PHP will just see them as numbers.
i.e.
033 becomes 33
+33 becomes 33

Using === 033 and +33 are compared exactly as that.

if ($sub1 === $sub2) {
...

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Brian TaoSenior Business Solutions ConsultantCommented:
According to http://php.net/manual/en/language.operators.comparison.php, when using "==", it evaluates to TRUE if $a is equal to $b after type juggling, meaning that:
If you compare a number with a string or the comparison involves numerical strings, then each string is converted to a number and the comparison performed numerically.

So you should use either strcmp() or the identical operator "===" to compare possible numerical strings.
0
GaryCommented:
Congratulations for repeating what I already said
0
Brian TaoSenior Business Solutions ConsultantCommented:
@Gary,
Come on! I think you've seen some of my comments to other questions.  I don't repeat what other people already said.
And you have posted some comments regarding that people may have opened the page, enter their comments, but didn't realize that their answers are very similar to others' until they hit the Submit button.
Plus that if it were not for my previous comment (45 minutes before yours), the author would not even know he had pasted the wrong script.
Anyway, I'll try to send you some congratulations next time when I see you posting similar answers following others. ^^

Cheers!
0
GaryCommented:
My answer was based on his real code.
You repeated the exact same analogy of my comment
If someone comes up with the same answer within a few minutes then I won't bitch about it unless it is a 10 word comment that consists of a link and copy/paste which your comment barely passes

Anyway, I'll try to send you some congratulations next time when I see you posting similar answers following others
Invariably (99%) where I post a similar comment to what has already been posted in the time it took to write the comment then I will delete unless it adds something else to the discussion/answer

The author posting the wrong code is irrelevant - many times authors post a synopsis of their code that is irrelevant as they have removed the important parts or thought this 3 line version of their code is enough.
0
Brian TaoSenior Business Solutions ConsultantCommented:
unless it adds something else to the discussion/answer
Yes, that's why I didn't delete mine.  I thought an explanation from PHP official site would be worth referencing.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
PHP

From novice to tech pro — start learning today.