Solved

php string comparison, why the same?

Posted on 2014-12-23
9
105 Views
Last Modified: 2014-12-23
Hi all,

When I test the string comparison functions, I do not understand why they are equal.

This is the script:
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Comparaison de chaînes de caractères</title>
</head>
<body>
<?php
$str1 = "033123456789";
$str2 = "+33456789087";

$sub1 = substr($str1, 0, 3);
$sub2 = substr($str2, 0, 3);

echo $sub1 . " -- " . $sub2 . "<br>";

if (strcmp($sub1, $sub2) !== 0) {
	echo "The strings are equal.<br>";
} else {
	echo "The strings are not equal.<br>";
}

?>
</body>
</html>

Open in new window


And this is what I have in my browser:
033 -- +33
The strings are equal.

Open in new window


My version of PHP is 5.2.17
0
Comment
Question by:Richard Coffre
9 Comments
 
LVL 12

Expert Comment

by:FarWest
ID: 40515050
it looks like treating '+' as 0

I think you can do work around by comparing sha1 output
if (strcmp(sha1($sub1), sha1($sub2)) !== 0) {
	echo "The strings are equal.<br>";
} else {
	echo "The strings are not equal.<br>";
}

Open in new window

0
 
LVL 9

Expert Comment

by:Brian Tao
ID: 40515053
Because you're echoing "The strings are equal.<br>" when they are not!
Change the !== to == in line 17.
0
 
LVL 1

Author Comment

by:Richard Coffre
ID: 40515101
Oups,

The weird code is:
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Comparaison de chaînes de caractères</title>
</head>
<body>
<?php
$str1 = "033123456789";
$str2 = "+33456789087";

$sub1 = substr($str1, 0, 3);
$sub2 = substr($str2, 0, 3);

echo $sub1 . " -- " . $sub2 . "<br>";

if ($sub1 == $sub2) {
	echo "The strings are equal.<br>";
} else {
	echo "The strings are not equal.<br>";
}

?>
</body>
</html>

Open in new window


The output is:
033 -- +33
The strings are equal.

Open in new window

0
Active Directory Webinar

We all know we need to protect and secure our privileges, but where to start? Join Experts Exchange and ManageEngine on Tuesday, April 11, 2017 10:00 AM PDT to learn how to track and secure privileged users in Active Directory.

 
LVL 58

Accepted Solution

by:
Gary earned 500 total points
ID: 40515139
Use === for a type and value comparison else PHP will just see them as numbers.
i.e.
033 becomes 33
+33 becomes 33

Using === 033 and +33 are compared exactly as that.

if ($sub1 === $sub2) {
...

Open in new window

0
 
LVL 9

Expert Comment

by:Brian Tao
ID: 40515153
According to http://php.net/manual/en/language.operators.comparison.php, when using "==", it evaluates to TRUE if $a is equal to $b after type juggling, meaning that:
If you compare a number with a string or the comparison involves numerical strings, then each string is converted to a number and the comparison performed numerically.

So you should use either strcmp() or the identical operator "===" to compare possible numerical strings.
0
 
LVL 58

Expert Comment

by:Gary
ID: 40515166
Congratulations for repeating what I already said
0
 
LVL 9

Expert Comment

by:Brian Tao
ID: 40515944
@Gary,
Come on! I think you've seen some of my comments to other questions.  I don't repeat what other people already said.
And you have posted some comments regarding that people may have opened the page, enter their comments, but didn't realize that their answers are very similar to others' until they hit the Submit button.
Plus that if it were not for my previous comment (45 minutes before yours), the author would not even know he had pasted the wrong script.
Anyway, I'll try to send you some congratulations next time when I see you posting similar answers following others. ^^

Cheers!
0
 
LVL 58

Expert Comment

by:Gary
ID: 40515997
My answer was based on his real code.
You repeated the exact same analogy of my comment
If someone comes up with the same answer within a few minutes then I won't bitch about it unless it is a 10 word comment that consists of a link and copy/paste which your comment barely passes

Anyway, I'll try to send you some congratulations next time when I see you posting similar answers following others
Invariably (99%) where I post a similar comment to what has already been posted in the time it took to write the comment then I will delete unless it adds something else to the discussion/answer

The author posting the wrong code is irrelevant - many times authors post a synopsis of their code that is irrelevant as they have removed the important parts or thought this 3 line version of their code is enough.
0
 
LVL 9

Expert Comment

by:Brian Tao
ID: 40516068
unless it adds something else to the discussion/answer
Yes, that's why I didn't delete mine.  I thought an explanation from PHP official site would be worth referencing.
0

Featured Post

Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Developers of all skill levels should learn to use current best practices when developing websites. However many developers, new and old, fall into the trap of using deprecated features because this is what so many tutorials and books tell them to u…
Build an array called $myWeek which will hold the array elements Today, Yesterday and then builds up the rest of the week by the name of the day going back 1 week.   (CODE) (CODE) Then you just need to pass your date to the function. If i…
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question