Javascript stopped working?

Hi
On this page I have a form that works out some values for you
http://www.petenetlive.com/KB/Article/0000903.htm

Its stopped working and I dont know why? (I know nothing about Javascript). Can anyone see why its not working?


Pete
LVL 58
Pete LongTechnical ConsultantAsked:
Who is Participating?
 
Alexandre SimõesManager / Technology SpecialistCommented:
And I just realized another major error... why are you overriding the $ sign with a function to return an element by id?
Replace the whole block by this:
<script language="JavaScript">
function conv(GB){
    var bytes = GB.value * Math.pow(1024,3);
    $("#ex10").val(bytes / 32);
    $("#ex07").val(bytes / 8);
}
</script>

Open in new window

0
 
Pete LongTechnical ConsultantAuthor Commented:
0
 
Alexandre SimõesManager / Technology SpecialistCommented:
I don't know what exactly isn't working but from the dev tools I see that you have a couple of errors.

I would recommend you to remove the async attribute from the jquery and lightbox script blocks.
Using async will not guarantee the scripts dependency so in this case, lightbox apparently loads faster than jquery causing unexpected behavior.

I see that you use async later on for google ads and there is a perfect scenario to use it as it's a stand alone script.
0
Ultimate Tool Kit for Technology Solution Provider

Broken down into practical pointers and step-by-step instructions, the IT Service Excellence Tool Kit delivers expert advice for technology solution providers. Get your free copy now.

 
Alexandre SimõesManager / Technology SpecialistCommented:
Also you have this script block:
<script language="JavaScript">
<!--
function $(id) { return document.getElementById(id); };

function conv(GB){
    var bytes = GB.value * Math.pow(1024,3);
    $("ex10").value = bytes / 32;
    $("ex07").value = bytes / 8;
}
//-->
</script>

Open in new window

What are those html comment tags doing inside a script block?
Remove them so it becomes like:
<script language="JavaScript">
function $(id) { return document.getElementById(id); };

function conv(GB){
    var bytes = GB.value * Math.pow(1024,3);
    $("ex10").value = bytes / 32;
    $("ex07").value = bytes / 8;
}
</script>

Open in new window

0
 
Pete LongTechnical ConsultantAuthor Commented:
Hi Alexandre Simões

Thanks for your responses, I've duplicated the page and changed the code as per your last post, it appears to be working  :)
http://www.petenetlive.com/KB/Article/0000903test.htm
0
 
Alexandre SimõesManager / Technology SpecialistCommented:
Yep, looks better :)

Still you didn't remove the async attribute from the jquery and lightbox script blocks. I strongly suggest you to do it.
0
 
Pete LongTechnical ConsultantAuthor Commented:
I did that because Google Analytics was complaining that I needed to put that in as the code was slowing down the page?
0
 
Alexandre SimõesManager / Technology SpecialistCommented:
I saw that you don't know javascript but to understand this it requires a bit of knowledge...

So as Google Analytics says, it kind of is because javascript is a blocking task.
When the HTML parser reaches a script block the HTML rendering stops and the contents of the script block (or the referenced file) is sent to be processed by the javascript engine.
The HTML parsing will only resume when the javascript engine processing is finished.
This means that if you're referencing a javascript file (like jquery) you need to wait for it to be downloaded and parsed, only after the HTML can continue to be parsed.

Async attribute kind of mitigates this problem but only by the time it takes to load the file. The javascript processing time will still block the HTML parsing.

Now the main problem in using async with jquery is that other javascript files (like lightbox) deppend on jquery and they should only be loaded and executed after jquery is already loaded and executed.
If this doesn't happen, you'll be presented with kind of intermitent errors. They are intermitent because some times one file might load faster, others slower due to different factors causing the error or not.

Another thing to consider is that the browser will only load them once, after that the browser will cache them and it will be super fast to use them.

So bottom line, if you want to optimize this page, there's a lot more to consider than these two script blocks.
Drop the async from jquery and lightbox just to avoid unexpected and/or intermitent errors :)
0
 
Pete LongTechnical ConsultantAuthor Commented:
Hi Alexandre

Thanks for the explanation, and taking the time to point that out, I will remove the async from those two :)

Pete
0
 
Alexandre SimõesManager / Technology SpecialistCommented:
Just as a final note and if you have to deal with javascript, take the time to learn it.
Not only the language itself but also (and very importantly) how it interacts with its surroundings.

It's really easy to start with javascript but very hard to master it.

The following books will put you in the right track.
After mastering javascript you can use any of the "fancy" javascript frameworks actually knowing what and how they do it.

Javascript: The good parts
High performance javascript

Cheers!
0
 
Jason C. LevineNo oneCommented:
This is a great answer.  Nicely done, Alexandre.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.