• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 270
  • Last Modified:

Mysql Search for contact

I am trying to find the best way to create a global search of contacts. To have one search box and search within multiple fields at once. Im using mysql with InnoDB engine.

$wherestm = "
WHERE (people.peopleFirstName LIKE {$search1}%) OR
      (people.peopleLastName LIKE {$search1}%) OR
      (company LIKE {$search1}%) OR
        (people.peopleTel LIKE {$search1}%) OR
        (people.peopleEmail LIKE {$search1}%)";
}
$sql =
"
SELECT
people.peopleId,
people.peopleFirstName,
people.peopleLastName,
people.peopleCompanyId,
company.companyName As company,
people.peopleTel,
people.peopleCel,
people.peopleEmail
FROM
people
LEFT JOIN company ON people.peopleCompanyId = company.companyId
{$wherestm}
0
ido90
Asked:
ido90
1 Solution
 
Ray PaseurCommented:
That approach seems reasonable.  It may not be syntactically exact, but it appears to be conceptually sound.  How many rows are in the people table?  Which columns are indexed?
0
 
ido90Author Commented:
Its a large data set, 30k of data. I have indexed Id, PeopleFirstName, PeopleLastName, peopleTel and peopleEmail. The issue Im running into with this approach is that for some reason Im getting results which have nothing todo with the search term.
0
 
Ray PaseurCommented:
My initial guess is that this might be the culprit:

 (company LIKE {$search1}%) OR ...

However when you search for:

(people.peopleTel LIKE {$search1}%) OR
(people.peopleEmail LIKE {$search1}%)

if the $search1 value is NULL or very short, you may get a lot of results that are unwanted.

To understand this better it would be helpful if you can post some sample data - a few rows from the data set that reflect both the wanted and unwanted results.  Then we can work to refine the query so that unwanted results are not returned.  Let the SSCCE be your guide.
0
Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

 
GaryCommented:
Where you have a multi column search with variable input then you are always going to have rows returned that are not what is being looked for.


Instead of some random global search why not have a radio button field to select what you want to search by - people id, first name, company name etc.


Would make your sql significantly smaller and more on point as to what peple are searching by - even Google has various options to narrow your search by what you really want.


This is a common practice - it certainly isn't expected that you enter a search term and the whole database is searched - it puts unnecessary strain on the db.


You could even narrow it down to just ID, name, phone or email


Doesn't need to be unneccesarily complicated for the user to select the correct criteria to search by
0
 
Olaf DoschkeSoftware DeveloperCommented:
I don't know why you tagged this as Foxpro database, maybe just in error, but nevertheless I also do some PHP/mysql.

peopleFirstName LIKE {$search1}%
If $search1 would be 'Ray' that would be substituted as in
peopleFirstName LIKE Ray%

Open in new window

Which is wrong syntax, you need
peopleFirstName LIKE 'Ray%'

Open in new window


Maybe my MySQL is rusted and this works, but I'm quite sure you only can make a more generic approach with parametrization with the questionmark, see mysqli_stmt_bind_param - http://php.net/manual/de/mysqli-stmt.bind-param.php, you'd write the query parameterized with
peopleFirstName LIKE ?+'%'

Open in new window

And more such parameters and bind the $search1 variable multiple times.
Or you add the % to the variable value and simplify the sql to clauses using LIKE ? and let your frontend application make the decision, whether to add % to the user input or not. For example % doesn't work at all for numeric fields, as LIKE only is a string comparison operator.

Bye, Olaf.
0
 
CaptainCyrilFounder, Software Engineer, Data ScientistCommented:
I would check to see if the input has alphanumeric characters. If it does then exclude telephone and if it does not then search telephone columns and exclude names. It will impact performance.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now