Solved

Mysql Search for contact

Posted on 2014-12-27
6
231 Views
Last Modified: 2015-05-19
I am trying to find the best way to create a global search of contacts. To have one search box and search within multiple fields at once. Im using mysql with InnoDB engine.

$wherestm = "
WHERE (people.peopleFirstName LIKE {$search1}%) OR
      (people.peopleLastName LIKE {$search1}%) OR
      (company LIKE {$search1}%) OR
        (people.peopleTel LIKE {$search1}%) OR
        (people.peopleEmail LIKE {$search1}%)";
}
$sql =
"
SELECT
people.peopleId,
people.peopleFirstName,
people.peopleLastName,
people.peopleCompanyId,
company.companyName As company,
people.peopleTel,
people.peopleCel,
people.peopleEmail
FROM
people
LEFT JOIN company ON people.peopleCompanyId = company.companyId
{$wherestm}
0
Comment
Question by:ido90
6 Comments
 
LVL 108

Expert Comment

by:Ray Paseur
Comment Utility
That approach seems reasonable.  It may not be syntactically exact, but it appears to be conceptually sound.  How many rows are in the people table?  Which columns are indexed?
0
 

Author Comment

by:ido90
Comment Utility
Its a large data set, 30k of data. I have indexed Id, PeopleFirstName, PeopleLastName, peopleTel and peopleEmail. The issue Im running into with this approach is that for some reason Im getting results which have nothing todo with the search term.
0
 
LVL 108

Expert Comment

by:Ray Paseur
Comment Utility
My initial guess is that this might be the culprit:

 (company LIKE {$search1}%) OR ...

However when you search for:

(people.peopleTel LIKE {$search1}%) OR
(people.peopleEmail LIKE {$search1}%)

if the $search1 value is NULL or very short, you may get a lot of results that are unwanted.

To understand this better it would be helpful if you can post some sample data - a few rows from the data set that reflect both the wanted and unwanted results.  Then we can work to refine the query so that unwanted results are not returned.  Let the SSCCE be your guide.
0
Complete Microsoft Windows PC® & Mac Backup

Backup and recovery solutions to protect all your PCs & Mac– on-premises or in remote locations. Acronis backs up entire PC or Mac with patented reliable disk imaging technology and you will be able to restore workstations to a new, dissimilar hardware in minutes.

 
LVL 58

Accepted Solution

by:
Gary earned 500 total points
Comment Utility
Where you have a multi column search with variable input then you are always going to have rows returned that are not what is being looked for.


Instead of some random global search why not have a radio button field to select what you want to search by - people id, first name, company name etc.


Would make your sql significantly smaller and more on point as to what peple are searching by - even Google has various options to narrow your search by what you really want.


This is a common practice - it certainly isn't expected that you enter a search term and the whole database is searched - it puts unnecessary strain on the db.


You could even narrow it down to just ID, name, phone or email


Doesn't need to be unneccesarily complicated for the user to select the correct criteria to search by
0
 
LVL 29

Expert Comment

by:Olaf Doschke
Comment Utility
I don't know why you tagged this as Foxpro database, maybe just in error, but nevertheless I also do some PHP/mysql.

peopleFirstName LIKE {$search1}%
If $search1 would be 'Ray' that would be substituted as in
peopleFirstName LIKE Ray%

Open in new window

Which is wrong syntax, you need
peopleFirstName LIKE 'Ray%'

Open in new window


Maybe my MySQL is rusted and this works, but I'm quite sure you only can make a more generic approach with parametrization with the questionmark, see mysqli_stmt_bind_param - http://php.net/manual/de/mysqli-stmt.bind-param.php, you'd write the query parameterized with
peopleFirstName LIKE ?+'%'

Open in new window

And more such parameters and bind the $search1 variable multiple times.
Or you add the % to the variable value and simplify the sql to clauses using LIKE ? and let your frontend application make the decision, whether to add % to the user input or not. For example % doesn't work at all for numeric fields, as LIKE only is a string comparison operator.

Bye, Olaf.
0
 
LVL 27

Expert Comment

by:CaptainCyril
Comment Utility
I would check to see if the input has alphanumeric characters. If it does then exclude telephone and if it does not then search telephone columns and exclude names. It will impact performance.
0

Featured Post

How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

Join & Write a Comment

Suggested Solutions

Microsoft Visual FoxPro (short VFP) is a programming language with it’s own IDE and database, ranking somewhat between Access and VB.NET + SQL Server (Express). Product Description: http://msdn.microsoft.com/en-us/vfoxpro/default.aspx (http://msd…
Since pre-biblical times, humans have sought ways to keep secrets, and share the secrets selectively.  This article explores the ways PHP can be used to hide and encrypt information.
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.
The viewer will learn how to create and use a small PHP class to apply a watermark to an image. This video shows the viewer the setup for the PHP watermark as well as important coding language. Continue to Part 2 to learn the core code used in creat…

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now