Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 143
  • Last Modified:

Which is better WithEvents or AddHandler?

I have a timer control in a windows app and was wondering what is more accepted...declaring a variable as

     Private WithEvents tmr As New Timer

Open in new window


or

AddHandler tmr.Tick, AddressOf tmr_Tick

Open in new window


Thanks!
0
BlakeMcKenna
Asked:
BlakeMcKenna
2 Solutions
 
sirbountyCommented:
Unless you're going to add and remove (using removehandler) your reference, go with the withevents setup and the framework will manage it for you.
Also, if you were using shared events, you would need to use add/remove handler.
See http://msdn.microsoft.com/en-us/library/stf7ebaz(v=vs.90).aspx
and http://msdn.microsoft.com/en-us/library/6yyk8z93(v=vs.90).aspx for the MS doci on it.
0
 
it_saigeDeveloperCommented:
WithEvents allows for you to specify the handler directly on the method,  i.e. -
Imports System.Windows.Forms

Module Module1
	Private WithEvents tmr1 As New Timer()
	Private tmr2 As New Timer()

	Sub Main()
		AddHandler tmr2.Tick, AddressOf OnTick
	End Sub

	Private Sub OnTick(ByVal sender As Object, ByVal e As EventArgs) Handles tmr1.Tick

	End Sub
End Module

Open in new window

Shows in the designer as such:Capture.JPGNotice how tmr2 does not appear as a selectable timer object after we type Handles.  Adding WithEvents to tmr2, i.e. -
Imports System.Windows.Forms

Module Module1
	Private WithEvents tmr1 As New Timer()
	Private WithEvents tmr2 As New Timer()

	Sub Main()
	End Sub

	Private Sub OnTick(ByVal sender As Object, ByVal e As EventArgs) Handles 

	End Sub
End Module

Open in new window

Changes that behaviour:Capture.JPGWithout WithEvents, you have to specify AddHandler in order to capture the events raised by methods/controls.

-saige-
0
 
BlakeMcKennaAuthor Commented:
Thanks for the explanations!
0
 
it_saigeDeveloperCommented:
More on WithEvents and the Handles clause:

http://msdn.microsoft.com/en-us/library/stf7ebaz%28v=vs.90%29.aspx

-saige-
0
 
Jacques Bourgeois (James Burger)Commented:
WithEvents is a little easier to use, but AddHandler is often better because it enables you to do a few things that WithEvents cannot do. The same goes for the Handles clause that Visual Studio automatically adds when you create an event procedure in the "usual" way. The Handles can be deleted and replaced by AddHandler, to be able to profit from the following.

You can decide at which point you activate the event. I have often seen programmers having performance problems when loading or refreshing a DataGridView. This is because the validation events are called on each cell, even if you do it with one line of code by setting the Datasource property. If you have tight validations in the grid, this can be a lot of code to run. Most of the time, this is useless, because you are feeding the grid with data that comes from a source where it has already been validated, such as a database. Validation is then necessary only when the user types. Working with AddHandler, you can delay the activation of the events. The grid fills a lot faster if you wait after it is full before calling AddHandler. Same thing when you fill a ComboBox or a ListBox.

You are not limited to use AddHandler with variables defined at the class scope as is the case with WithEvents. It can be useful sometimes to handle events on a local variable, something that you cannot do with WithEvents
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now