Downloading Index

Hi Experts,

I have WB which download data from Web. I just have to put start date  and end date & it will download files for that time range & save to active WB path. I need little modification.
1 Save Path changes to "D:\AmiBroker Data\NSE\Index\"
2 Before downloading it clears all file from above location.
3 start downloading
4 print last date of available  file in Start date.
5 End

See attached file.

Naresh PatelTraderAsked:
Who is Participating?
I had to use byundt file as yours was pass protected.

Made necessary modification in sub delete files and in Macro as per your request.
Naresh PatelTraderAuthor Commented:
Apology I won't be able to here 4:00 AM. Feeling sleepy.
I wish you had not password protected the VBA code, as I had to remove the protection prior to seeing what needed to be changed.

The code can really only be tested by you, given its dependence on certain data being available, but I believe the required changes are in the two subs below:
Sub DeleteFiles(flPath As String)       'Deletes all files from this folder
Dim fl As String
fl = Dir(flPath & "*.*")
Do Until fl = ""
    Kill flPath & fl
    fl = Dir
End Sub

Sub Macro1()
Dim flPath As String
Dim rgStart As Range
Dim WkBk As Excel.Workbook
Dim lastDate As Date
txtFileName As String

Application.ScreenUpdating = False
flPath = "D:\AmiBroker Data\NSE\Index\"
DeleteFiles flPath

Set rgStart = Range("C2")
startDate = Range("C2").Value
stopdate = Range("C3").Value

For xx = startDate To stopdate

    If HttpExists("" & Format(xx, "ddmmyyyy") & ".csv") Then
        txtFileName = Format(xx, "ddmmyyyy")
        lastDate = xx
        Set WkBk = Workbooks.Add
        With ActiveSheet.QueryTables.Add(Connection:="URL;" & Format(xx, "ddmmyyyy") & ".csv", Destination:=Range("$A$1"))
            .FieldNames = True
            .RowNumbers = False
            .FillAdjacentFormulas = False
            .PreserveFormatting = True
            .RefreshOnFileOpen = False
            .BackgroundQuery = True
            .RefreshStyle = xlInsertDeleteCells
            .SavePassword = False
            .SaveData = True
            .AdjustColumnWidth = True
            .RefreshPeriod = 0
            .WebSelectionType = xlEntirePage
            .WebFormatting = xlWebFormattingNone
            .WebPreFormattedTextToColumns = True
            .WebConsecutiveDelimitersAsOne = True
            .WebSingleBlockTextImport = False
            .WebDisableDateRecognition = False
            .WebDisableRedirections = False
            .Refresh BackgroundQuery:=False
        End With
        Columns("A:A").TextToColumns Destination:=Range("A1"), DataType:=xlDelimited, _
            TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=False, Tab:=False, _
            Semicolon:=False, Comma:=True, Space:=False, Other:=False
        Application.DisplayAlerts = False
        WkBk.SaveAs Filename:=flPath & "\" & txtFileName & ".csv", FileFormat:=xlCSV, CreateBackup:=False
        WkBk.Close (False)
        Application.DisplayAlerts = True
    End If

Next xx

rgStart.Value = lastDate
Application.ScreenUpdating = True

MsgBox "Done"

End Sub

Open in new window

Ultimate Tool Kit for Technology Solution Provider

Broken down into practical pointers and step-by-step instructions, the IT Service Excellence Tool Kit delivers expert advice for technology solution providers. Get your free copy now.

Naresh PatelTraderAuthor Commented:
Sir.Byundt,i got this error meassage.Thanks
That statement is missing the "Dim" keyword. I should have caught that, even without being able to test.
Sub Macro1()
Dim flPath As String
Dim rgStart As Range
Dim WkBk As Excel.Workbook
Dim lastDate As Date
Dim txtFileName As String

Open in new window

Naresh PatelTraderAuthor Commented:

Downloading files - Perfect. But when I clicked button it wont clear (Delete) Files from directory. Apology for delay in reply & please one favor - as start date print at the end of process is = last file available date, just need to add one day i.e. last date of file available = 1 jan 2015 then print date is +1 day which is 2 jan 2015.
I required in this manner  
1 when I clicked it clears all files from "D:\AmiBroker Data\NSE\Index" this directory.
2 Download files from start date to End date.
3 Print start date as last available file date plus one day.
4 End

Thank You
Naresh PatelTraderAuthor Commented:
Naresh PatelTraderAuthor Commented:
May I ask Follow Up?
yes but pls no protected workbook
Naresh PatelTraderAuthor Commented:
Here it is.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.