Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 149
  • Last Modified:

powershell Multiple parameters

I have this data in a file.
Located at C:\Temp\UCounts.txt (first row is Blank in file)

Enviornment,SQLInstance,UTMServer,Database,2
Enviornment,SQLInstance,UTMServer,Database,3
Enviornment,SQLInstance,UTMServer,Database,1

Open in new window


How would I iterate thru the lines of Ucounts.txt file and pass it thru the code below and append the results to a CSV file.
Right now the my out put file is blank now sure why. The query returns results when ran in SQL Studio.

Param([string]$Enviornment,[string]$SQLInstance,[string]$UTMServer,[string]$Database, [string]$Count)

add-pssnapin sqlserverprovidersnapin100 -ErrorAction SilentlyContinue
add-pssnapin sqlservercmdletsnapin100 -ErrorAction SilentlyContinue
cls 

$Qry = "USE [UTM_SITE]

    select '$Enviornment' as Enviornment,'$SQLInstance' as [Server Name], CNAME, CDBNAME,CTSINSTNAM 
    from dbo.NTI_master
	WHERE CDBNAME IN ('$Database' )
	ORDER BY CDBNAME"

Write-Host $Qry

$Packages =  Invoke-Sqlcmd -MaxCharLength 10000000 -ServerInstance $SQLInstance -Query $Qry

foreach ( $item in $Packages) { 
    
  $item |  Export-Csv -path "C:\temp\Powershell\UTM_Report\UTMReport.csv" -Force -NoTypeInformation -Append 
  }
 
$Packages | ForEach-Object { $_ }

Open in new window

0
Leo Torres
Asked:
Leo Torres
  • 3
  • 2
  • 2
  • +1
2 Solutions
 
AntyraelCommented:
Hello,

Have you tried escaping the single quotes in your query? It looks like your variables are not being expanded.
Try like this:
$Qry = "USE [UTM_SITE]

    select `'$Enviornment`' as Enviornment, `'$SQLInstance`' as [Server Name], CNAME, CDBNAME,CTSINSTNAM 
    from dbo.NTI_master
	WHERE CDBNAME IN (`'$Database`' )
	ORDER BY CDBNAME"

Open in new window


PS: You have a typo "enviornment" instead of "environment", not that it breaks the script though.
0
 
Leo TorresSQL DeveloperAuthor Commented:
NO nothing. Tried it.
0
 
AntyraelCommented:
I'm sorry, I wasn't very sharp earlier and misread the question slightly.

Your script doesn't get any parameters from the csv-file as it is now.

I changed it into this, could you see if it works for you?
$csv = Import-Csv C:\Temp\UCounts.txt -Header @("Environment","SQLInstance","UTMServer","Database","Count")

add-pssnapin sqlserverprovidersnapin100 -ErrorAction SilentlyContinue
add-pssnapin sqlservercmdletsnapin100 -ErrorAction SilentlyContinue
cls

foreach ($Line in $csv) {

	$Qry = "USE [UTM_SITE]

			SELECT '$($Line.Environment)' as Environment,'$($Line.SQLInstance)' as [Server Name], CNAME, CDBNAME,CTSINSTNAM 
			FROM dbo.NTI_master
			WHERE CDBNAME IN ('$($Line.Database)')
			ORDER BY CDBNAME"

	Write-Host $Qry

	$Packages =  Invoke-Sqlcmd -MaxCharLength 10000000 -ServerInstance $SQLInstance -Query $Qry

	foreach ( $item in $Packages) { 
		$item |  Export-Csv -path "C:\temp\Powershell\UTM_Report\UTMReport_$($Line.UTMServer).csv" -Force -NoTypeInformation -Append 
	}

	$Packages | ForEach-Object { $_ }
}

Open in new window

0
Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

 
QlemoC++ DeveloperCommented:
As shown above I would not call the script for each line but integrate the CSV processing into the script, in particular because the export is also done in the script itself. As general rule: either you read data and pipe them thru cmdlets/scripts, then process the output in a pipeline again, or you do all in one script.

I strongly recommend to NOT call Export-CSV for each package line, as your original code does. Instead, the output should be collected and exported at once. Anyway, as I see it, the inner foreach is superfluous.
add-pssnapin sqlserverprovidersnapin100 -ErrorAction SilentlyContinue
add-pssnapin sqlservercmdletsnapin100 -ErrorAction SilentlyContinue
cls

foreach ($Line in Import-Csv C:\Temp\UCounts.txt -Header 'Environment','SQLInstance','UTMServer','Database','Count')) {

  $Qry = "USE [UTM_SITE]

      SELECT '$($Line.Environment)' as Environment,'$($Line.SQLInstance)' as [Server Name], CNAME, CDBNAME,CTSINSTNAM 
      FROM dbo.NTI_master
      WHERE CDBNAME IN ('$($Line.Database)')
      ORDER BY CDBNAME"

  Write-Host $Qry

  $Packages =  Invoke-Sqlcmd -MaxCharLength 10000000 -ServerInstance $SQLInstance -Query $Qry
  $Packages | Export-CSV -NoType "C:\temp\Powershell\UTM_Report\UTMReport_$($Line.UTMServer).csv" -Force 
  $Packages 
}

Open in new window

0
 
footechCommented:
You could keep you code as is and just save it as a .PS1 file, or convert it to function, then you can just pass it the info for the parameters.  The following should work.
Import-Csv C:\Temp\UCounts.txt -Header @("Environment","SQLInstance","UTMServer","Database","Count") | ForEach { .\yourscript.ps1 $_.Environment $_.SQLInstance $_.UTMServer $_.Database $_.Count }

Open in new window

If you adjusted the parameters you could even make it accept pipeline input directly by parameter name.  But I agree with Qlemo, that with the script itself doing the export it's probably best to just modify the script to include the reading of the input file.
0
 
Leo TorresSQL DeveloperAuthor Commented:
Well now i see data going to file.

But a few things its trying to Query Header Data.

Second its only entering 1 entry by second Query.
This is the print out of first 2 Queries

I am only getting one line.

USE [UTM_SITE]

      SELECT 'Enviornment' as Environment,'SiteServer' as [Server Name], CNAME, CDBNAME,CTSINSTNAM 
      FROM dbo.NTI_master
      WHERE CDBNAME IN ('Database')
      ORDER BY CDBNAME
USE [UTM_SITE]

      SELECT 'ATL E1 UTM' as Environment,'MyserverHere' as [Server Name], CNAME, CDBNAME,CTSINSTNAM 
      FROM dbo.NTI_master
      WHERE CDBNAME IN ('TEMP_UTM_28E88_09282014')
      ORDER BY CDBNAME


Environment : ATL E1 UTM
Server Name : MyserverHere
CNAME       : 
CDBNAME     : TEMP_UTM_28E88_09282014
CTSINSTNAM  :

Open in new window


Running Code
add-pssnapin sqlserverprovidersnapin100 -ErrorAction SilentlyContinue
add-pssnapin sqlservercmdletsnapin100 -ErrorAction SilentlyContinue

cls
$File = "C:\temp\Powershell\UTM_Report\UTMCounts.txt"

Clear-Content "C:\temp\Powershell\UTM_Report\UTMReport.csv"

foreach ($Line in Import-Csv $File -Header 'Environment','SQLInstance','UTMServer','Database','Count'){

  $Qry = "USE [UTM_SITE]

      SELECT '$($Line.Environment)' as Environment,'$($Line.SQLInstance)' as [Server Name], CNAME, CDBNAME,CTSINSTNAM 
      FROM dbo.NTI_master
      WHERE CDBNAME IN ('$($Line.Database)')
      ORDER BY CDBNAME"

  Write-Host $Qry

  $Packages = Invoke-Sqlcmd -MaxCharLength 10000000 -ServerInstance $SQLInstance -Query $Qry
  $Packages | Export-CSV -NoType -append "C:\temp\Powershell\UTM_Report\UTMReport.csv" -Force  #_$($Line.UTMServer).csv" -Force 
  $Packages 
}
                                          

Open in new window

0
 
QlemoC++ DeveloperCommented:
its trying to Query Header Data
you told us that the input file does not contain header info, but starts with an empty line. If that is no longer true, we have to change the import command, of course.


Your code modification will now export all data to a single CSV file. That's fine, but UTMServer looses its meaning and is superfluous then.


its only entering 1 entry by second Query.
Are you certain the first query results in rows at all? What you see on the screen is exactly what you should have in your CSV file, and what is retrieved from SQL Server.
0
 
Leo TorresSQL DeveloperAuthor Commented:
I was not passing parameters correctly. Now I am and its working.

Thank you.
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 3
  • 2
  • 2
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now