• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 573
  • Last Modified:

VBA - Remove all dashes in cells when dash does not have a number before and after it.

I have this code where i replace all dashes with an empty space.

Columns("C").Replace " - ", " ", xlPart, xlByRows, True

Open in new window


Now, I would like to replace dashes when the character before AND after are not numbers.
(Format NUMBER & DASH & NUMBER)

Ex:
If I have in the cell:
St-Mary  1234-56

Open in new window


I see 2 dashes in the same cell. But one of them as a number before and after the dash. So the macro would only replace the St-Mary to St Mary.

If for example i have in the cell:
10234 Saint-John auto parc-0234

Open in new window


In this cell, Saint-John dash would be removed as i see a letter before and after the dash, and parc-0234 dash also would be removed as i don't have a combination of a Number before and after the dash.
So it would return to: 10234 Saint John auto parc 0234.

If i have in the cell:
1234 -123456

Open in new window


Since before the dash, there is an empty space, it would remove the dash as only format Number & dash & number needs to stay the same. So the result would be: 1234 123456

I need to specify that the text in each cells of column C may have different characters length.

How can i do that.

Thanks again.
0
Wilder1626
Asked:
Wilder1626
  • 4
  • 3
  • 2
1 Solution
 
Michael FowlerSolutions ConsultantCommented:
Add VBA reference to "Microsoft VBScript Regular Expressions 5.5" and then use the following function

Function RegexReplace(str As String) As String

    Dim regEx As New RegExp
    Dim matchPattern As String, replacePattern As String
    Dim match As Boolean
    
    matchPattern = "(\D+)(-)(\D+)?"
    replacePattern = "$1 $3"
    
    With regEx
        .Global = True
        .MultiLine = True
        .IgnoreCase = False
        .Pattern = matchPattern
    End With
        
    match = regEx.test(str)
       
    While match
        str = regEx.Replace(str, replacePattern)
        match = regEx.test(str)
    Wend
    
    RegexReplace = str

End Function

Open in new window

Replace-Example.xlsm
0
 
QlemoC++ DeveloperCommented:
I would not define the dash as an own capture group, as we don't want to keep or work with it. Further the regex shown will work only if there is no digit on either side. I.e.:
    matchPattern = "(\D+)-(.*)|(.*)-(\D+)"
    replacePattern = "$1 $3"

Open in new window

0
 
Wilder1626Author Commented:
It looks like it work as a formula, but i will just need to transfer that into a macro.

I need to be able to replace actual cell, and not use another cell to give me the results needed.
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
Michael FowlerSolutions ConsultantCommented:
@Wilder1626 the function provided will happily replace the cell contents I just implemented it this way to give a demo.

eg

Range("A1").Text = RegexReplace(Range("A1").Text)

Open in new window

0
 
Wilder1626Author Commented:
That was one of the thing i jtested using your file, but i was getting an runtime error 424: Object required.

Range("A1").Text = RegexReplace(Range("A1").Text)

Open in new window

0
 
Michael FowlerSolutions ConsultantCommented:
Sorry use

Range("A2").Value = RegexReplace(Range("A2").Text)

Open in new window

0
 
Wilder1626Author Commented:
Thanks for your help

I was able to tweak it to:

Dim i As Integer
Dim LastRow As Integer

LastRow = [A65536].End(xlUp).Row
 For i = LastRow To 2 Step -1

If Cells(i, 1) <> "" Then
 Cells(i, 1).Value = RegexReplace(Cells(i, 1).Text)
End If

Next i
0
 
Michael FowlerSolutions ConsultantCommented:
Cool. Just a hint

The following will find the last row and work on all versions of excel. Just replace the "A" for the column you want to use.

lastrow = Range("A" & rows.count).end(xlup).row

Open in new window

0
 
QlemoC++ DeveloperCommented:
Using which regex?
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 4
  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now