Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 3275
  • Last Modified:

How to CREATE TEMP TABLE in VBA

I have a simple Excel VBA that I use ADODB to query against an Excel sheet. In the VBA, I also create a temp table. But it seems that one line has problem.

Here is the code:

Sub Test_Data()
'
Dim abc As String
Dim Conn As New ADODB.Connection
Dim xyz As New ADODB.Recordset
Dim DBPath As String, sconnect As String
DBPath = ThisWorkbook.FullName
sconnect = "Provider=MSDASQL.1;DSN=Excel Files;DBQ=" & DBPath & ";HDR=Yes';"

'****************
Conn.Open sconnect
'*****************


abc = "CREATE TABLE #test(tmpa int, tmpb int)"

'abc = "SELECT [Table_Exposures_Input].[IdxName], [Table_Exposures_Input].[Price] " & _
"INTO #TempPrices"
'
'****************
xyz.Open abc, Conn

Worksheets("Test").Cells(2, 2).CopyFromRecordset xyz

xyz.Close

'****************


Conn.Close
'******************

End Sub
0
jfz2004
Asked:
jfz2004
  • 21
  • 9
  • 5
  • +1
1 Solution
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Possibly could be:

abc = "INSERT INTO #TempPrices " & _
"SELECT [Table_Exposures_Input].[IdxName], [Table_Exposures_Input].[Price] "

or

abc = "INSERT INTO #TempPrices(tmpa, tmpb) " & _
"SELECT [Table_Exposures_Input].[IdxName], [Table_Exposures_Input].[Price] "

But if [Table_Exposures_Input] is a table, then it should be

abc = "INSERT INTO #TempPrices " & _
"SELECT [IdxName], [Price] From [Table_Exposures_Input]"

or

abc = "INSERT INTO #TempPrices(tmpa, tmpb) " & _
"SELECT [IdxName], [Price] From [Table_Exposures_Input]"
0
 
James ElliottManaging DirectorCommented:
Something like this?

Sub Test_Data()
'
Dim abc As String
Dim Conn As New ADODB.Connection
Dim xyz As New ADODB.Recordset
Dim DBPath As String, sconnect As String
DBPath = ThisWorkbook.FullName
sconnect = "Provider=MSDASQL.1;DSN=Excel Files;DBQ=" & DBPath & ";HDR=Yes';"

'****************
Conn.Open sconnect
'*****************


abc = "CREATE TABLE #test(tmpa int, tmpb int) INSERT INTO #test VALUES (1,2)"

Conn.Execute abc

abc = "SELECT * FROM #test"

xyz.Open abc, Conn

Worksheets("Test").Cells(2, 2).CopyFromRecordset xyz

xyz.Close

'****************


Conn.Close
'******************

End Sub

Open in new window

0
 
jfz2004Author Commented:
James,
Thanks. tested your code, it gives an syntax error at
Conn.Execute abc

Jennifer
0
Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

 
jfz2004Author Commented:
philip,

Thanks for the help. But TempPrices is a table I would like to create.
After creating it, I would like to select from items from another table and insert into the tempprice table.

Thanks a lot.

Jennifer
0
 
James ElliottManaging DirectorCommented:
Anything more specific in the error?

I've tested that the SQL is valid when opening an ADO connection to one of my SQL server instances. Perhaps the OLE DB provider does not allow the creation of temporary tables when connecting to Excel as a data source?
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Yes, so you create the table:

abc = "CREATE TABLE #test(tmpa int, tmpb int)"

and insert it into the tempprice table

abc = "INSERT INTO #TempPrices(tmpa, tmpb) " & _
"SELECT [IdxName], [Price] From [Table_Exposures_Input]"

You need to use INSERT INTO / SELECT instead of SELECT / INTO, as the later inserts data into a NEW table, whereas you have already created the table, and want in INSERT it into the existing table.
0
 
jfz2004Author Commented:
James,

Thanks. I am not trying to access to a SQL Server. The Query is against a Excel file.

Jennifer
0
 
jfz2004Author Commented:
Philip,
Thanks. Now my code looks like this but it still has the same error at the line xyz.Open abc, Conn (highlighted yellow) with

"Syntax error in INSERT INTO statement."


Sub Test_Data()
'
Dim abc As String
Dim Conn As New ADODB.Connection
Dim xyz As New ADODB.Recordset
Dim DBPath As String, sconnect As String
DBPath = ThisWorkbook.FullName
sconnect = "Provider=MSDASQL.1;DSN=Excel Files;DBQ=" & DBPath & ";HDR=Yes';"

'****************
Conn.Open sconnect
'*****************

abc = "CREATE TABLE #TempPrices(tmpa int, tmpb int)"

abc = "INSERT INTO #TempPrices(tmpa, tmpb) " & _
 "SELECT [IdxName], [Price] From [Table_Exposures_Input]"
 

'****************
xyz.Open abc, Conn

Worksheets("Test").Cells(2, 2).CopyFromRecordset xyz

xyz.Close

'****************


Conn.Close
'******************

End Sub
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Try adding

SET NOCOUNT ON

to the beginning of your SQL.
0
 
jfz2004Author Commented:
Thanks, Phillip,

now my code looks like this but still the same error:

Sub Test_Data()
'
Dim abc As String
Dim Conn As New ADODB.Connection
Dim xyz As New ADODB.Recordset
Dim DBPath As String, sconnect As String
DBPath = ThisWorkbook.FullName
sconnect = "Provider=MSDASQL.1;DSN=Excel Files;DBQ=" & DBPath & ";HDR=Yes';"

'****************
Conn.Open sconnect
'*****************

 
abc = "SET NOCOUNT ON CREATE TABLE #TempPrices(tmpa int, tmpb int)"

abc = "INSERT INTO #TempPrices(tmpa, tmpb) " & _
  "SELECT [IdxName], [Price] From [Table_Exposures_Input]"
'
'****************
xyz.Open abc, Conn

Worksheets("Test").Cells(2, 2).CopyFromRecordset xyz

xyz.Close

'****************


Conn.Close
'******************

End Sub
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Try SET NOCOUNT ON; with a semicolon.
0
 
jfz2004Author Commented:
Thanks. Just added the ";" but still get the same syntax error:

Sub Test_Data()
'
Dim abc As String
Dim Conn As New ADODB.Connection
Dim xyz As New ADODB.Recordset
Dim DBPath As String, sconnect As String
DBPath = ThisWorkbook.FullName
sconnect = "Provider=MSDASQL.1;DSN=Excel Files;DBQ=" & DBPath & ";HDR=Yes';"

'****************
Conn.Open sconnect
'*****************

 
abc = "SET NOCOUNT ON; CREATE TABLE #TempPrices(tmpa int, tmpb int); "

abc = "INSERT INTO #TempPrices(tmpa, tmpb) " & _
  "SELECT [IdxName], [Price] From [Table_Exposures_Input]"
'
'****************
xyz.Open abc, Conn

Worksheets("Test").Cells(2, 2).CopyFromRecordset xyz

xyz.Close

'****************


Conn.Close
'******************

End Sub
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Change

abc = "INSERT INTO #TempPrices(tmpa, tmpb) " & _
  "SELECT [IdxName], [Price] From [Table_Exposures_Input]"

to

abc = abc & "INSERT INTO #TempPrices(tmpa, tmpb) " & _
  "SELECT [IdxName], [Price] From [Table_Exposures_Input]"
0
 
jfz2004Author Commented:
Thanks! I changed according to your suggestion. The error message changed to:

[ODBC Excel Driver] Invalid SQL statement; expected 'DELETE', 'INSERT', 'PROCEDURE', 'SELECT', or 'UPDATE'.

here is the code:

Sub Test_Data()
'
Dim abc As String
Dim Conn As New ADODB.Connection
Dim xyz As New ADODB.Recordset
Dim DBPath As String, sconnect As String
DBPath = ThisWorkbook.FullName
sconnect = "Provider=MSDASQL.1;DSN=Excel Files;DBQ=" & DBPath & ";HDR=Yes';"

'****************
Conn.Open sconnect
'*****************

 
abc = "SET NOCOUNT ON; CREATE TABLE #TempPrices(tmpa int, tmpb int); "


abc = abc & "INSERT INTO #TempPrices(tmpa, tmpb) " & _
   "SELECT [IdxName], [Price] From [Table_Exposures_Input]"
'
'****************
xyz.Open abc, Conn

Worksheets("Test").Cells(2, 2).CopyFromRecordset xyz

xyz.Close

'****************


Conn.Close
'******************

End Sub
0
 
leonstrykerCommented:
You may want to try creating a Global temp table (use ## in the name). You can also try debugging your code by creating a regular table and then go to a temp table.
0
 
jfz2004Author Commented:
I just checked my references and found that it is using 6.1 library. So I switched it to ADO 2.8. Then I got compile error at Dim Conn As New ADODB.Connection.
0
 
jfz2004Author Commented:
Thanks, leonstryker.

How to create a global temp table? I am not very familiar with VBA.
0
 
leonstrykerCommented:
Use ## in the table name instead of #.
0
 
jfz2004Author Commented:
Do you mean like these?
abc = "SET NOCOUNT ON; CREATE TABLE ##TempPrices(tmpa int, tmpb int); "
abc = abc & "INSERT INTO ##TempPrices(tmpa, tmpb) " & _
   "SELECT [IdxName], [Price] From [Table_Exposures_Input]"

Just tried the above, got the same syntax error.

Thanks.

Jennifer
0
 
jfz2004Author Commented:
So? Is there no solution?
0
 
leonstrykerCommented:
Have you tried to create a regular table?
0
 
jfz2004Author Commented:
What do you mean "regular table"?
0
 
jfz2004Author Commented:
Any other suggestions? Anyone, please?
0
 
leonstrykerCommented:
Normal everyday SQL table. Not a temporary one.
0
 
jfz2004Author Commented:
For normal tables, I can create in SQL Server manually.
This is trying to create a temp  table in Excel.
0
 
leonstrykerCommented:
Yes, but the SQL works similarly for temp tables and regular tables. At the moment I am thinking you may not have permissions or some such thing to create tables at all.
0
 
jfz2004Author Commented:
So, is this kind of operation doable -- creating temp table in Excel?
0
 
leonstrykerCommented:
Doable, yes. But, let me ask you a different question, why do you need to create it? Why are you not using a store procedure or using the spreadsheet itself? What is it you are trying to achieve with this Temp table?
0
 
jfz2004Author Commented:
Thanks, leonstryker.
The reason for creating a temp table is that I need to put data from different tables into this temp table for later use.

Why can't I have permission to create a table in a Excel that I created myself?
How to check the permission?
0
 
jfz2004Author Commented:
Do you think I should ask this question in the database section or is there a VBA SQL section?
0
 
jfz2004Author Commented:
0
 
leonstrykerCommented:
Sorry, I thought you were working with a SQL Server as your backend and you are not. It seems you are just trying to create a temp table in memory, that is not going to happen. Not possible.
0
 
jfz2004Author Commented:
Yes, I am not working with SQLserver. Why is it not possible?
Thanks.
0
 
leonstrykerCommented:
Temp tables are a database concept. Some databases, like Access, do not even have them. With VBA you can setup arrays and its possible to access various data sources, even text files and Excel spreadsheet with ADO and query them with SQL syntax, but there is no functionality in VBA (or VB) to create an in memory table and query them with SQL syntax.
0
 
jfz2004Author Commented:
Oh, is that so?

but...but...no one mentioned this in books or anywhere.
0
 
jfz2004Author Commented:
How did you know of it?
0
 
leonstrykerCommented:
The syntax you are using is not part of VBA. Its part of ADO. Before ADO there was RDO and DAO and before that there was ODBC. What you are looking to do was never part of VBA. How do I know it? 15+ years of coding VBA tells me so.
0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

  • 21
  • 9
  • 5
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now