With PowerShell how may I record disabled accounts and export the findings to a CSV file?

Hello Expert,

I've cobbled together this script and am unable to output a CSV file with the active accounts and move the inactive accounts to the DisabledAccounts OU. Would you please review this script and offer suggestions to remedy this situation?  Wasn't sure if the issue centered around the 'filter'parameter, 'whatif' parameter or something else.

# Disable inactive user accounts in the domain that have NOT logged in since the specified date
# PowerShell 4.0
# Client OS: Windows 7, Server OS: Windows 2008 R2
# Modified: IT Staff
# Date: 20-Jan-2015

import-module activedirectory
import-module grouppolicy

# Create script variables to apply
# Create a variable for the date stamp in the log file
$LogDate = get-date -f mm-dd-yy

#Sets the OU to do the base search for all user accounts
$SearchBase = "OU=Administrators,OU=Settings,OU=TestOU,OU=AdministratorAccounts,DC=test,DC=local"

#Create an empty array for the log file
$LogArray = @()

#Sets the number of days to disable user accounts based on lastlogontimestamp and pwdlastset.
$PasswordAge = (Get-Date).adddays(-2)

#Use ForEach to loop through all users with pwdlastset and lastlogontimestamp greater than date set. Also add users with no lastlogon date set. Disables the accounts and adds to log array.

#Add the properties you will be using to ensure they are available.
$DisabledUsers = (Get-ADUser -searchbase $SearchBase -Properties samaccountname, name, distinguishedname -Filter {((lastlogondate -notlike "*") -OR (lastlogondate -le $Passwordage) -AND (enabled -eq $True))})

# Code to apply the variables
if ($DisabledUsers -ne $null -and $DisabledUsers.Count > 0) {
    ForEach ($DisabledUsers in $DisabledUsers) {

 #Set the user objects description attribute to a date stamp. Example "19JAN2015" To log only add "-whatif"
      Set-ADuser $DisabledUsers -Description ((get-date).toshortdatestring()) -WhatIf

 #Disabled user object. To log only add "-Whatif"
      Disable-ADaccount $DisabledUsers -WhatIf

 #Create new object for logging
  $obj = New-Object PSObject
  $obj | Add-Member -MemberType NoteProperty -Name "name" -Value $DisabledUsers.name
  $obj | Add-Member -MemberType NoteProperty -Name "samAccountName" -Value $DisabledUsers.samaccountname
  $obj | Add-Member -MemberType NoteProperty -Name "distinguishedname" -Value $DisabledUsers.distinguishedName
  $obj | Add-Member -MemberType NoteProperty -Name "status" -Value 'Disabled User'

 #Adds object to the log array
  $LogArray += $obj

# Move disabled users in TestOU to DisabledAccounts OU
    Search-ADAccount –userAccountControl –UsersOnly –SearchBase “OU=Administrators,OU=Settings,OU=TestOU,OU=AdministratorAccounts,DC=sleepmed,DC=md” | Move-ADObject –TargetPath “OU=DisabledAccounts,OU=TestOU,OU=AdministratorAccounts,DC=test,DC=local”   |
    Move-ADObject –TargetPath “OU=DisabledAccounts,OU=TestOU,OU=AdministratorAccounts,DC=test,DC=local”

#Exports log array to CSV file in the Scripts directory with a date and time stamp.
    $logArray | Export-Csv "C:\Scripts\User_Report.csv" -NoTypeInformation
     
 } else {
            Write-Output "No disabled users to process for $PasswordAge."

        }
}
CuriousMAUserAsked:
Who is Participating?
 
footechConnect With a Mentor Commented:
Try the following:
# Disable inactive user accounts in the domain that have NOT logged in since the specified date 
# PowerShell 4.0
# Client OS: Windows 7, Server OS: Windows 2008 R2
# Modified: IT Staff
# Date: 20-Jan-2015 

import-module activedirectory
import-module grouppolicy

# Create script variables to apply
# Create a variable for the date stamp in the log file
$LogDate = get-date -f mm-dd-yy

#Sets the OU to do the base search for all user accounts
$SearchBase = "OU=Administrators,OU=Settings,OU=TestOU,OU=AdministratorAccounts,DC=test,DC=local"

#Create an empty array for the log file
$LogArray = @()

#Sets the number of days to disable user accounts based on lastlogontimestamp and pwdlastset.
$PasswordAge = (Get-Date).adddays(-2)

#Use ForEach to loop through all users with pwdlastset and lastlogontimestamp greater than date set. Also add users with no lastlogon date set. Disables the accounts and adds to log array.

#Add the properties you will be using to ensure they are available.
$DisabledUsers = @(Get-ADUser -searchbase $SearchBase -Properties samaccountname, name, distinguishedname -Filter {((lastlogondate -notlike "*") -OR (lastlogondate -le $Passwordage) -AND (enabled -eq $True))})

# Code to apply the variables
if ($DisabledUsers -ne $null -and $DisabledUsers.Count > 0) {
    ForEach ($DisabledUser in $DisabledUsers) {

    #Set the user objects description attribute to a date stamp. Example "19JAN2015" To log only add "-whatif"
        Set-ADuser $DisabledUser -Description ((get-date).toshortdatestring()) -WhatIf

    #Disabled user object. To log only add "-Whatif"
        Disable-ADaccount $DisabledUser -WhatIf

    #Create new object for logging
        $obj = $DisabledUser | Select Name,samAccountName,distinguishedname,@{n="status";e={'Disabled User'}}

    #Adds object to the log array
        $LogArray += $obj

    # Move disabled users in TestOU to DisabledAccounts OU 
        #Search-ADAccount -AccountDisabled –UsersOnly –SearchBase “OU=Administrators,OU=Settings,OU=TestOU,OU=AdministratorAccounts,DC=sleepmed,DC=md” | Move-ADObject –TargetPath “OU=DisabledAccounts,OU=TestOU,OU=AdministratorAccounts,DC=test,DC=local”   | 
        Move-ADObject $DisabledUser –TargetPath “OU=DisabledAccounts,OU=TestOU,OU=AdministratorAccounts,DC=test,DC=local”

    }
#Exports log array to CSV file in the Scripts directory with a date and time stamp.
    $logArray | Export-Csv "C:\Scripts\User_Report.csv" -NoTypeInformation 
      
    } else {
        Write-Output "No disabled users to process for $PasswordAge."

}

Open in new window


 - Your foreach loop was referencing the same variable twice.
ForEach ($DisabledUsers in $DisabledUsers)
should be
ForEach ($DisabledUser in $DisabledUsers)
and then references after the fact should be adjusted.
 - I put in a more efficient method for creating your new object.
 - The Search-ADAccount command didn't make sense.  There is no -userAccountControl parameter, and there's no need to search for accounts when we already have the object.
 - The closing brackets for the foreach loop and If scriptblock were mixed up.
 - Moved the Export-CSV outside the foreach loop.  If it's inside you have to use the -append switch, otherwise the file will be overwritten each time through the loop.  Since you're collecting all the output in $LogArray, it's better to put this outside the loop.  This is generally also better from a perfomance perspective as you're not repeatedly opening and closing the file which is an expensive operation.
0
 
CuriousMAUserAuthor Commented:
Thank you, Footech. Appreciate the correction.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.