Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 392
  • Last Modified:

Convert VBA Code to C# - How to find a phrase in a string and then parse everything to the left of that value?

Please note the following code looks for a phase/value called (Phone: ) and once it's found in a string grabs all of the text to the left of it and returns the value:

I'm a lot more familiar with VBA than C# and was wondering if someone could help me with the code below that would be it's equivalent.   MID function does a pretty good job of identifying text in a string if you give it a start value and LEFT I know C#'s equivalent is SubString... but if someone could convert the code to actual C# - it would be much appreciated.

I tried http://www.developerfusion.com/tools/convert/vb-to-csharp and they are still stumped and have not returned a reply.  I'm not trying to be guided to articles where I can read up on how to figure it out.  I'm doing other programming stuff - this is just a little nugget that I'm stuck on and would ideally like some code to try and see if it's doing the same thing in Visual C# .NET.  

Thank you in advance.

Public Function NoPhoneNumber(sValue as String)

Dim newvalue As String
Dim i as Integer

For i = 1 to len(sValue)

If len(sValue) > 8 Then

If mid(sValue, i, 9) = "(Phone: )" Then

  newvalue = Left(sValue, i-9)
  Exit For

End if

End if

Next i

NoPhoneNumber = sValue

End Sub

Open in new window

0
stephenlecomptejr
Asked:
stephenlecomptejr
  • 3
  • 2
  • 2
2 Solutions
 
Michael FowlerSolutions ConsultantCommented:
Here is code which should achieve what you are looking for

Public string NoPhoneNumber(string input)
{
   If (input.IndexOf("(Phone: )") == -1)
   {
      return "";
   }
   
   return input.Substring(0, input.Length - input.IndexOf("(Phone: )"));
}

Open in new window

0
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
Another one:
        private string NoPhoneNumber(string phone)
        {
            return phone.Contains("(Phone: )") ? phone.Substring(0, phone.IndexOf("(Phone: )")) : "";
        }

Open in new window


That could also be written as:
        private string NoPhoneNumber(string phone)
        {
            int i;
            return (i = phone.IndexOf("(Phone: )")) != -1 ? phone.Substring(0, i) : "";
        }

Open in new window

0
 
stephenlecomptejrAuthor Commented:
Michael74

I have for my string input:  "GE Healthcare - Anesthesia Delivery  (Phone: ) CAD ID: ANE0034"
And  yet the result using your code comes out to :  "GE Healthcare - Anesthesi"

... so Anesthesia Delivery is cut off.
0
Get 10% Off Your First Squarespace Website

Ready to showcase your work, publish content or promote your business online? With Squarespace’s award-winning templates and 24/7 customer service, getting started is simple. Head to Squarespace.com and use offer code ‘EXPERTS’ to get 10% off your first purchase.

 
stephenlecomptejrAuthor Commented:
Mike Tomlinson, that code worked but what if I want to trouble shoot each character in the string and see it getting to the point of 9 characters as it moves from the beginning character to the end... that's what the VBA enables me to see.

With the above code, I can't see the result as it goes through the process of finding it.  

I guess the benefit is that it's faster than looping through each character in the string - is that correct?
0
 
Michael FowlerSolutions ConsultantCommented:
Sorry about that. Use

Public string NoPhoneNumber(string input)
{
   If (input.IndexOf("(Phone: )") == -1)
   {
      return "";
   }
   
   return input.Substring(0, input.IndexOf("(Phone: )")-1).Trim()
}

Open in new window


Note: I added trim to strip the whitespace. If this was wrong just remove the Trim() function from the call
0
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
"I guess the benefit is that it's faster than looping through each character in the string - is that correct?"

I'm not sure what the underlying code for IndexOf actually does.  It might be looping for you.

If you really want to loop, then:
        private string NoPhoneNumber(string phone)
        {
            string lookFor = "(Phone: )";
            if (phone.Length > lookFor.Length)
            {
                for(int i = 1; i <= (phone.Length - lookFor.Length); i++)
                {
                    if (phone.Substring(i, lookFor.Length).Equals(lookFor))
                    {
                        return phone.Substring(0, i);
                    }
                }
            }
            return "";
        }

Open in new window

0
 
stephenlecomptejrAuthor Commented:
Appreciate all the replies.   Mike gets more points for taking the time to give me exactly what I wanted but both deserve 'A's.  Thank you sincerely.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Easily Design & Build Your Next Website

Squarespace’s all-in-one platform gives you everything you need to express yourself creatively online, whether it is with a domain, website, or online store. Get started with your free trial today, and when ready, take 10% off your first purchase with offer code 'EXPERTS'.

  • 3
  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now