Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

SQL % Calculation

Posted on 2015-02-06
5
Medium Priority
?
140 Views
Last Modified: 2015-02-06
have a very basic qry  that counts number of active customers vs those customers that have been verified with current data and shows the percent of "verified" accounts.

The date is showing 186 verified out of 325 Active, but my percent results show 39.42 not 57.23



SELECT  COUNT(uppnverify) AS 'Verified GM Customers'
FROM CONTACT2
WHERE UPPNVERIFY like '201%'


SELECT COUNT(ACCOUNTNO)AS 'Active Customers'
FROM CONTACT2
WHERE USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL



SELECT CAST([Verified Customers] * 100.0 / [Active Customers] AS decimal(4, 2)) AS [%age of GM verified customers]
    --, [Verified Customers], [Active Customers]
FROM (
    SELECT
        --count number of GM company with verified field
        SUM(CASE WHEN UPPNVERIFY like '201%' THEN 1 ELSE 0 END) AS [Verified Customers],
        -- count number of GM company with active status (sales in last 2 yr)
        SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END) AS [Active Customers]
    FROM CONTACT2
    WHERE
        (UPPNVERIFY like '2015%') OR
        (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)
) AS subquery1
0
Comment
Question by:Jeremy Kirkbride
  • 2
  • 2
5 Comments
 
LVL 27

Expert Comment

by:Shaun Kline
ID: 40593645
Your WHERE clause uses (UPPNVERIFY like '2015%') which may be excluding results you are expecting with just (UPPNVERIFY like '201%').
0
 

Author Comment

by:Jeremy Kirkbride
ID: 40593845
Gotcha, changed the statement to 201%, the percentage is much closer but still calculating 59.6, math has never been my strong point, but I get 57% from 186 out of 325

SELECT  COUNT(uppnverify) AS 'Verified GM Customers'
FROM CONTACT2
WHERE UPPNVERIFY like '201%'


SELECT COUNT(ACCOUNTNO)AS 'Active Customers'
FROM CONTACT2
WHERE USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL



SELECT CAST([Verified Customers] * 100.0 / [Active Customers] AS decimal(4, 1)) AS [%age of GM verified customers]
    --, [Verified Customers], [Active Customers]
FROM (
    SELECT
        --count number of GM company with verified field
        SUM(CASE WHEN UPPNVERIFY like '201%' THEN 1 ELSE 0 END) AS [Verified Customers],
        -- count number of GM company with active status (sales in last 2 yr)
        SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END) AS [Active Customers]
    FROM CONTACT2
    WHERE
        (UPPNVERIFY like '201%') OR
        (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)
) AS subquery1
0
 
LVL 70

Accepted Solution

by:
Scott Pletcher earned 2000 total points
ID: 40593908
The calc will work, since computers don't mess up simple math :-).

Uncomment the other values in the outer query and you can see the actual totals SQL is using, which will differ from your expected totals of 186 and 325 somewhat, which will explain the difference in %.

SELECT CAST([Verified Customers] * 100.0 / [Active Customers] AS decimal(4, 1)) AS [%age of GM verified customers]
     , [Verified Customers], [Active Customers]


Edit: Just saw the data conflict in the query:
...
 SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END) AS [Active Customers]
     FROM CONTACT2
     WHERE
         (UPPNVERIFY like '201%') OR
         (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)
0
 
LVL 27

Expert Comment

by:Shaun Kline
ID: 40593912
Another WHERE Clause discrepancy:
SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END)

versus:
 (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)

Looks like your result set may not be returning the records you are expecting.
0
 

Author Closing Comment

by:Jeremy Kirkbride
ID: 40594062
Thanks so much. All good now
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In part one, we reviewed the prerequisites required for installing SQL Server vNext. In this part we will explore how to install Microsoft's SQL Server on Ubuntu 16.04.
One of the most important things in an application is the query performance. This article intends to give you good tips to improve the performance of your queries.
Via a live example combined with referencing Books Online, show some of the information that can be extracted from the Catalog Views in SQL Server.
Via a live example, show how to extract insert data into a SQL Server database table using the Import/Export option and Bulk Insert.

972 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question