?
Solved

SQL % Calculation

Posted on 2015-02-06
5
Medium Priority
?
144 Views
Last Modified: 2015-02-06
have a very basic qry  that counts number of active customers vs those customers that have been verified with current data and shows the percent of "verified" accounts.

The date is showing 186 verified out of 325 Active, but my percent results show 39.42 not 57.23



SELECT  COUNT(uppnverify) AS 'Verified GM Customers'
FROM CONTACT2
WHERE UPPNVERIFY like '201%'


SELECT COUNT(ACCOUNTNO)AS 'Active Customers'
FROM CONTACT2
WHERE USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL



SELECT CAST([Verified Customers] * 100.0 / [Active Customers] AS decimal(4, 2)) AS [%age of GM verified customers]
    --, [Verified Customers], [Active Customers]
FROM (
    SELECT
        --count number of GM company with verified field
        SUM(CASE WHEN UPPNVERIFY like '201%' THEN 1 ELSE 0 END) AS [Verified Customers],
        -- count number of GM company with active status (sales in last 2 yr)
        SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END) AS [Active Customers]
    FROM CONTACT2
    WHERE
        (UPPNVERIFY like '2015%') OR
        (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)
) AS subquery1
0
Comment
Question by:Jeremy Kirkbride
  • 2
  • 2
5 Comments
 
LVL 27

Expert Comment

by:Shaun Kline
ID: 40593645
Your WHERE clause uses (UPPNVERIFY like '2015%') which may be excluding results you are expecting with just (UPPNVERIFY like '201%').
0
 

Author Comment

by:Jeremy Kirkbride
ID: 40593845
Gotcha, changed the statement to 201%, the percentage is much closer but still calculating 59.6, math has never been my strong point, but I get 57% from 186 out of 325

SELECT  COUNT(uppnverify) AS 'Verified GM Customers'
FROM CONTACT2
WHERE UPPNVERIFY like '201%'


SELECT COUNT(ACCOUNTNO)AS 'Active Customers'
FROM CONTACT2
WHERE USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL



SELECT CAST([Verified Customers] * 100.0 / [Active Customers] AS decimal(4, 1)) AS [%age of GM verified customers]
    --, [Verified Customers], [Active Customers]
FROM (
    SELECT
        --count number of GM company with verified field
        SUM(CASE WHEN UPPNVERIFY like '201%' THEN 1 ELSE 0 END) AS [Verified Customers],
        -- count number of GM company with active status (sales in last 2 yr)
        SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END) AS [Active Customers]
    FROM CONTACT2
    WHERE
        (UPPNVERIFY like '201%') OR
        (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)
) AS subquery1
0
 
LVL 70

Accepted Solution

by:
Scott Pletcher earned 2000 total points
ID: 40593908
The calc will work, since computers don't mess up simple math :-).

Uncomment the other values in the outer query and you can see the actual totals SQL is using, which will differ from your expected totals of 186 and 325 somewhat, which will explain the difference in %.

SELECT CAST([Verified Customers] * 100.0 / [Active Customers] AS decimal(4, 1)) AS [%age of GM verified customers]
     , [Verified Customers], [Active Customers]


Edit: Just saw the data conflict in the query:
...
 SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END) AS [Active Customers]
     FROM CONTACT2
     WHERE
         (UPPNVERIFY like '201%') OR
         (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)
0
 
LVL 27

Expert Comment

by:Shaun Kline
ID: 40593912
Another WHERE Clause discrepancy:
SUM(CASE WHEN USALESYTD IS NOT NULL AND USALES2013 IS NOT NULL THEN 1 ELSE 0 END)

versus:
 (USALESYTD IS NOT NULL AND USALES2014 IS NOT NULL)

Looks like your result set may not be returning the records you are expecting.
0
 

Author Closing Comment

by:Jeremy Kirkbride
ID: 40594062
Thanks so much. All good now
0

Featured Post

The Lifecycle Approach to Managing Security Policy

Managing application connectivity and security policies can be achieved more effectively when following a framework that automates repeatable processes and ensures that the right activities are performed in the right order.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

In this article, we will see two different methods to recover deleted data. The first option will be using the transaction log to identify the operation and restore it in a specified section of the transaction log. The second option is simpler and c…
Here is how to restore SQL Server database to the point in time.  Follow the step by step approach to restore your database at a specific point in time and also understand its alternate approach.
Using examples as well as descriptions, and references to Books Online, show the documentation available for date manipulation functions and by using a select few of these functions, show how date based data can be manipulated with these functions.
SQL Database Recovery Software repairs the MDF & NDF Files, corrupted due to hardware related issues or software related errors. Provides preview of recovered database objects and allows saving in either MSSQL, CSV, HTML or XLS format. Ensures recov…

590 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question