• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 349
  • Last Modified:

Best way to get a unique key field value using PowerBuilder and SQL Server?

The program that I have created using PowerBuilder has a database table with a unique key field.  It is not an identity field, but just an integer field.  I have always used a system to get a new unique value of having a separate table that holds the next number to be used, and then updates that table when the next value is needed from it.  This has worked well up until now.  There are several users of the program and they are entering data quickly.  More than one user is trying to grab a unique value at the same time and in some cases they get the same value, causing a database error when trying to save the data (problem with the primary key).  
At a job a long time ago I seem to recall using a SQL Server stored procedure maybe to grab that next value, because maybe it locked the table, or somehow provided a more reliable way of insuring the value is unique.  Anyhow, I can't find that code and am not sure how to approach it.  Does that process sound familiar to anyone?
Or, what method do you recommend to solve this issue?
0
lwillford
Asked:
lwillford
2 Solutions
 
kotukunuiCommented:
The best solution is to use SQL Server's "identity" feature.

If that is completely out of the question then maintaining your own sequence table can be made to work. Just remember to enclose the whole process in a database transaction to make sure the table is locked to other users until you get your value. Maybe encapsulate it into a stored procedure:

CREATE PROCEDURE [get_next_value] 
	@NewKeyValue INT OUTPUT 
AS
BEGIN

    BEGIN TRANSACTION

		SELECT @NewKeyValue = MAX(key_value) + 1 
		FROM sequence_table

		UPDATE sequence_table
		SET key_value = @NewKeyValue

	COMMIT TRANSACTION

	RETURN 
END

Open in new window


Put in a bit of error handling code just to make sure it all goes smoothly and the job is done.
0
 
Anthony PerkinsCommented:
If you are using at least SQL Server 2012 ou may want to look into using the Sequence object.
0
 
Vitor MontalvãoMSSQL Senior EngineerCommented:
Yes, Sequence is a very good idea.
How to create it:
CREATE SEQUENCE dbo.MySeqName
    START WITH 1
    INCREMENT BY 1

Open in new window


And how to increment:
SELECT NEXT VALUE FOR dbo.MySeqName

Open in new window


And how to verify the properties of a sequence:
SELECT * FROM sys.sequences WHERE name = 'MySeqName'

Open in new window

0
Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
lwillfordAuthor Commented:
All - we are still rocking it old school here with SQL Server 2005, so Sequence would not work.  Good to know about for future work though.

kotukunui - thanks for the info.  I believe that is exactly what I used to use.  My original code is escaping me now - probably lost during job changes!  I did create a stored procedure and I can execute it successfully.  Refresh my memory on one more point... does encapsulating the process in a stored procedure put a lock on the table?    
Just wondering if there is anything else I need to do to ensure a unique value other than making the stored procedure call.
0
 
Vitor MontalvãoMSSQL Senior EngineerCommented:
does encapsulating the process in a stored procedure put a lock on the table?    
No.

I would use a solution with a simple UPDATE so it will lock the row:
UPDATE sequence_table 	SET key_value = key_value+1

Open in new window

0
 
lwillfordAuthor Commented:
Vitor - So if my stored procedure in SQL Server contains the update, I will not need to do any additional locking on the table or worry about two people getting the same value from it?
0
 
Vitor MontalvãoMSSQL Senior EngineerCommented:
UPDATE command already locks the records that are being changed so no one can update the same record at same time.
Also, during an update no one are able to read the records being changed unless they use locking hints but then they will read the old values and not the new ones.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: Certified Penetration Testing

This CPTE Certified Penetration Testing Engineer course covers everything you need to know about becoming a Certified Penetration Testing Engineer. Career Path: Professional roles include Ethical Hackers, Security Consultants, System Administrators, and Chief Security Officers.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now