On-screen guidance at the moment of need enables you & your employees to focus on the core, you can now boost your adoption rates swiftly and simply with one easy tool.
Course Of The Month
Become a Premium Member and unlock a new, free course in leading technologies each month.
Solved
sameFirstLast
Posted on 2015-02-12
hi,
I am trying below challenge
http://codingbat.com/prob/p118976
i am failing in one test case
please advise
I am trying below challenge
http://codingbat.com/prob/p118976
i am failing in one test case
public boolean sameFirstLast(int[] nums) {
int numsLen=nums.length;
int first=nums[0];
int last=nums[numsLen-1];
if(numsLen>=1&&first==last)
return true;
return false;
}
Expected Run
sameFirstLast({1, 2, 3}) → false false OK
sameFirstLast({1, 2, 3, 1}) → true true OK
sameFirstLast({1, 2, 1}) → true true OK
sameFirstLast({7}) → true true OK
sameFirstLast({}) → false Exception:java.lang.ArrayIndexOutOfBoundsException: 0 (line number:3) X
sameFirstLast({1, 2, 3, 4, 5, 1}) → true true OK
sameFirstLast({1, 2, 3, 4, 5, 13}) → false false OK
sameFirstLast({13, 2, 3, 4, 5, 13}) → true true OK
sameFirstLast({7, 7}) → true true OK
other tests
please advise
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
2
2
2- +1
8 Comments
Active 1 day ago
public boolean sameFirstLast(int[] nums) {
int numsLen=nums.length;
if(numsLen==0){
return false;
}
int first=nums[0];
int last=nums[numsLen-1];
if(numsLen>=1&&first==last)
return true;
return false;
}
Active 2 days ago
I would say your code actually looks fine.
The only part that could be written more clearly is to replace these 3 lines:
...
if(numsLen>=1&&first==last
return true;
return false;
...
With this one line:
return (first == last) ;
There's no need to check that "numsLen >= 1" because you already tested for length 0 at the top of the method - so the length here must be >= 1.
And rather than:
if (first == last)
return true ;
return false ;
you can just return whether "first == last"
return (first == last) ;
Make sense?
Whole program becomes:
The only part that could be written more clearly is to replace these 3 lines:
...
if(numsLen>=1&&first==last
return true;
return false;
...
With this one line:
return (first == last) ;
There's no need to check that "numsLen >= 1" because you already tested for length 0 at the top of the method - so the length here must be >= 1.
And rather than:
if (first == last)
return true ;
return false ;
you can just return whether "first == last"
return (first == last) ;
Make sense?
Whole program becomes:
public boolean sameFirstLast(int[] nums) {
int numsLen=nums.length;
if(numsLen==0){
return false;
}
int first=nums[0];
int last=nums[numsLen-1];
return (first == last) ;
}
numsLen>=1&& is unneccessary
and at that point, you can just
return first==last;
or, using numsLen>=1&& you can make the if(numsLen==0){ unnecessary
and at that point, you can just
return first==last;
or, using numsLen>=1&& you can make the if(numsLen==0){ unnecessary
Active 1 day ago
And rather than:
if (first == last)
return true ;
return false ;
you can just return whether "first == last"
return (first == last) ;
instead of doing in 2 steps like checking and then returning we are doing in one step in return itself comparing so that i will automatically give true false in return statement right?
please advise
Active 2 days ago
instead of doing in 2 steps like checking and then returning we are doing in one step in return itself comparing so that i will automatically give true false in return statement right?
Yes that's right. We're replacing 3 lines of code with 1 - which is good because it's simpler. And we're also removing a conditional (the "if" test) so the code always executes the same lines of code - which is also good.
Rather than:
if (first == last) {
// Sometimes we run code in here
return true ;
}
// Sometimes we run code here
return false ;
We have now:
// Always run this code
return (first == last) ;
It's best to avoid branches and conditional statements in your code where possible. It makes bugs less likely.
Doug
Active today
If you write:
When runing this piece of code, your computer will evaluate the expression first == last.
The value of an expression is a boolean. That's a variable that can hold the value 'true' or 'false'.
When the result/value of that expression is true, it will return true.
When the result/value of that expression is false, it will return false.
So, in fact, it can just return the result/value of that expression.
You write that as:
if (first == last) {
return true ;
}
return false ;
When runing this piece of code, your computer will evaluate the expression first == last.
The value of an expression is a boolean. That's a variable that can hold the value 'true' or 'false'.
When the result/value of that expression is true, it will return true.
When the result/value of that expression is false, it will return false.
So, in fact, it can just return the result/value of that expression.
You write that as:
return first == last;
Featured Post
We value your feedback.
Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
When we want to run, execute or repeat a statement multiple times, a loop is necessary. This article covers the two types of loops in Python: the while loop and the for loop.
Part One of the two-part Q&A series with MalwareTech.
This video will show you how to get GIT to work in Eclipse.
It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
In a recent question (https://www.experts-exchange.com/questions/29004105/Run-AutoHotkey-script-directly-from-Notepad.html) here at Experts Exchange, a member asked how to run an AutoHotkey script (.AHK) directly from Notepad++ (aka NPP). This video…
- Shell Scripting
- Programming Languages-Other
- Scripting Languages
- Programming
- Notepad
- *AutoHotkey, *Scripts
Suggested Courses
Earn Certification
HTML5 Specialist - Certification
Free withPremium
Course of the Month5 days, 18 hours left to enroll
626 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.