JDay2
asked on
Undefined index line 30 php code
<?php
session_start() ;
$link = mysqli_connect("", "", "","")
or die("Could not connect : " . mysqli_error() );
mysqli_select_db($link,"") or die("Could not select database");
#$printer_array = array("Oki 420 Ticket",
# "Oki 420 Report",
# "Dell 1700 Laser") ;
if(!isset($_SESSION['storeKey'])) {
?>
<html xmlns="http://www.w3.org/1999/xhtml">
<body>
You have not selected a store. Please proceed to the following page to select a store.<br>
<A href="http:///menu.php">Select Here</a>
</body>
</html>
<?php
} else {
$storeKey = $_SESSION['storeKey'] ;
# print_r($_REQUEST) ;
# print_r(array_keys($_REQUEST)) ;
# if(($_SESSION['access'] <= 2) && ($_SESSION['locked'] != 'Y')) {
if(isset($_REQUEST['submit'])) {
$entry = 1;
for($i=1; $i <= 26; $i++) {
$hidden_key = "hidden-" . $i ;
$name_key = "full_name-" . $i ;
if($_REQUEST[$name_key] != "" ||
(isset($_REQUEST[$hidden_key])))
{
$active_key = "active-" . $i ;
if(isset($_REQUEST[$active_key])) {
$active = $_REQUEST[$active_key] ;
} else {
$active = "N" ;
}
$name = $_REQUEST[$name_key];
$user_name_key = "user_name-" . $i ;
$user_name = $_REQUEST[$user_name_key];
$password_key = "password-" . $i ;
$password = $_REQUEST[$password_key];
if(isset($_REQUEST[$hidden_key])) {
$hidden = $_REQUEST[$hidden_key] ;
print "Update";
$sql = "UPDATE store_users SET full_name='$name',
user_name='$user_name',
password='$password',
active='$active'
WHERE row_id='$hidden' ; " ;
$res = mysqli_query($link,$sql) or
die("UPDATE Failed($i) : " . mysqli_error()) ;
} else {
print "insert";
$sql = "INSERT INTO store_users (store_key,
full_name, user_name, password, active)
VALUES ('$storeKey', '$name', '$user_name',
'$password', '$active');";
$res = mysqli_query($link,$sql) or
die("INSERT Failed($i) : " . mysqli_error()) ;
}
$entry++;
}
}
}
# }
$sql = "SELECT * FROM store_users WHERE store_key='$storeKey' ORDER BY full_name ;" ;
$res = mysqli_query($link,$sql) or die("Query Failed(storeKey) : " .
mysqli_error());
for($i = 1; $i <= mysqli_num_rows($res); $i++) {
$lines[$i] = mysqli_fetch_array($res);
# print "line$i" ;
}
$page = "Staging Users" ;
require 'header.php' ;
?>
<form id="form1" name="form1" method="post" action="">
</table>
<div align="center"></div>
<table width="750" height="27" border="0">
<tr>
<td width="303"><input type="submit" name="submit" value="Submit" /></td>
<td width="335"> </td>
<td width="98"><label for="Submit"></label>
<div align="left">
<input name="cancel" type="button" onClick="document.location='menu.php'" value="Cancel" />
</div></td>
</tr>
</table>
<table width="719" height="227" border="1">
<tr>
<td colspan="4"><div align="center"><strong><span class="style3">Manage Store Backroom PC Users</span></strong></div></td>
</tr>
<tr>
<td width="43"><strong>Active</strong></td>
<td width="300"><strong>Full Name </strong></td>
<td width="188"><strong>User Name </strong></td>
<td width="188"><strong>Password</strong></td>
</tr>
<?php
for($i=1 ; $i <= 15; $i++) {
?>
<tr>
<td><?php if(isset($lines[$i])) {
?><input type="hidden" name="hidden-<?php print $i ; ?>" value="<?php
print $lines[$i]['row_id'] ;
?>"><?php
}
?>
<input name="active-<?php print $i ; ?>" type="checkbox" value="Y" <?php
if(isset($lines[$i]['active']) == "Y") { print "checked=\"checked\"";
}
?>/></td>
<td><input name="full_name-<?php print $i ; ?>" type="text" size="30" maxlength="30" <?php
if(isset($lines[$i])) {
print "value=\"" . $lines[$i]['full_name'] . "\"" ;
}
?>/></td>
<td><input name="user_name-<?php print $i ; ?>" type="text" size="15" maxlength="15" <?php
if(isset($lines[$i])) {
print "value=\"" . $lines[$i]['user_name'] . "\"" ;
}
?>/></td>
<td><input name="password-<?php print $i ; ?>" type="text" size="15" maxlength="15" <?php
if(isset($lines[$i])) {
print "value=\"" . $lines[$i]['password'] . "\"" ;
}
?>/></td>
</tr>
<?php
}
?>
</table>
<div align="center"></div>
<table width="750" height="27" border="0">
<tr>
<td width="303"><input type="submit" name="submit" value="Submit" /></td>
<td width="335"> </td>
<td width="98"><label for="Submit"></label>
<div align="left">
<input name="cancel" type="button" onClick="document.location='menu.php'" value="Cancel" />
</div></td>
</tr>
</table>
<p> </p>
</form>
</body>
</html>
<?php } ?>Looking to fix the undefined index line 30 while converting from an old php to php5.6 and if there are other issues with this code
Dave Baldwin
$_REQUEST[$name_key] and the rest with variables for the index names ($_REQUEST[$hidden_key], $_REQUEST[$active_key]) are undefined in your code above. They might defined in a form on a previous page. I have never seen the indexes done with variables like that. The common format would be like $_REQUEST['firstname'] where 'firstname' is the name of a form element on the previous page.
SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
I was wondering if the previous server was supporting 'register_globals' which now obselete. http://php.net/manual/en/faq.using.php#faq.register-globals That would explain why the code used to work.