Mwvarner
asked on
Calculating Time
I'm using the following code to calculate elapsed time. It works fine until I go over 24 hours. The field is formatted as short time which also works fine until the value exceeds 24 hours. I don't want days, Hours, and Minutes. I just want hours and minutes. I believe the problem is the data type or formatting of the field, not the formula. Please help.
=(((IIf([PFT]>[PMRT],[PFT] -[PMRT],([ PFT]+1)-[P MRT])*[Pre ssOps])*14 40)\60) & Format(((IIf([PFT]>[PMRT], [PFT]-[PMR T],([PFT]+ 1)-[PMRT]) *[PressOps ])*1440) Mod 60,"\:00")
Marshall
=(((IIf([PFT]>[PMRT],[PFT]
Marshall
The time format is intended to show a point in time. That is different from elapsed time. To show elapsed time over 24 hours. Calculate the difference as minutes and then convert to hours and minutes by dividing by 60 and concatenate the results with the ":" separator.
can you give me an example of what you have now, and what you are expecting to doo?
Is it for example
12:55:00
13:55:00
14:55:00
15:55:00
16:55:00
Would equal to: 74:35
Is it for example
12:55:00
13:55:00
14:55:00
15:55:00
16:55:00
Would equal to: 74:35
You can use this function:
Public Function FormatHourMinute( _
ByVal datTime As Date, _
Optional ByVal strSeparator As String = ":") _
As String
' Returns count of days, hours and minutes of datTime
' converted to hours and minutes as a formatted string
' with an optional choice of time separator.
'
' Example:
' datTime: #10:03# + #20:01#
' returns: 30:04
'
' 2005-02-05. Cactus Data ApS, CPH.
Dim strHour As String
Dim strMinute As String
Dim strHourMinute As String
strHour = CStr(Fix(datTime) * 24 + Hour(datTime))
' Add leading zero to minute count when needed.
strMinute = Right("0" & CStr(Minute(datTime)), 2)
strHourMinute = strHour & strSeparator & strMinute
FormatHourMinute = strHourMinute
End Function
/gustav
The field is formatted as short time which also works fine until the value exceeds 24 hours.The Formatting of a data field is of no consequence when you run calculations on it, unless you first FORMAT the data, and then try to run calcs on that formatted object.
If you are actually storing ONLY the HH;MM, then you're out of luck.
If you are storing the FULL DateTime (like 01-01-2014T12:22:34) then you should be using DateDiff to get the variance:
'/ number of MInutes between the two
DateDiff("n", Date1, Date2)
See more information on DateDiff here:
https://support.office.com/en-us/article/DateDiff-Function-e6dd7ee6-3d01-4531-905c-e24fc238f85f?ui=en-US&rs=en-US&ad=US
Please have a look at the attachment.
Sum-on-time.xlsx
Sum-on-time.xlsx
ASKER
I've been doing this in a Macro, not VBA but I can change if I can figure out the proper code. This formula I'm using now compares the start time which is "PMRT" to the End Time which is "PFT" to determine if the time period crosses midnight. Then depending on that it subtracts the start time from end time in minutes, divides by 60 for hours and then shows the remaining minutes them multiplies that number by the number of people working on the job, "PressOps" and stores the results in a field which is a Short Text field. I had the field formatted as short time which I realize now will not work for values over 24 hours. What I need to know is how to format the field to show only hours and minutes when over 24 hours.
=(((IIf([PFT]>[PMRT],[PFT] -[PMRT],([ PFT]+1)-[P MRT])*[Pre ssOps])*14 40)\60) & Format(((IIf([PFT]>[PMRT], [PFT]-[PMR T],([PFT]+ 1)-[PMRT]) *[PressOps ])*1440) Mod 60,"\:00")
=(((IIf([PFT]>[PMRT],[PFT]
Use my function (copy paste into an empty module):
=FormatHourMinute(([PFT]-[ PMRT])*[Pr essOps])
The output is a string so apply no format.
/gustav
=FormatHourMinute(([PFT]-[
The output is a string so apply no format.
/gustav
ASKER
This function will return an incorrect value if the start and end times cross midnight.
Marshall
Marshall
So you have time only. Then:
=FormatHourMinute(([PFT]-[ PMRT]+Abs( [PFT]<[PMR T]))*[Pres sOps])
/gustav
=FormatHourMinute(([PFT]-[
/gustav
I don't want days, Hours, and Minutes. I just want hours and minutes.
Unlike Excel, Access has no built-in format or formula to show a time period of more than 24 hours in length as just hours and minutes.
You must create, or borrow, a VBA function to do the job for you.
And the format of the control you display your result in MUST NOT be a datetime format, or it will just undo your hard work.
You may already be fine
The field is formatted as short time
Change the format to General and see what happens.
Unlike Excel, Access has no built-in format or formula to show a time period of more than 24 hours in length as just hours and minutes.
You must create, or borrow, a VBA function to do the job for you.
And the format of the control you display your result in MUST NOT be a datetime format, or it will just undo your hard work.
You may already be fine
The field is formatted as short time
Change the format to General and see what happens.
ASKER
I've removed all formatting from the field on the form and the table. I've pasted your function into an module and I've edited the macro to the =FormatHourMinute(([PFT]-[ PMRT]+Abs( [PFT]<[PMR T]))*[Pres sOps]) After this the value still shows up as a time, 4:00 hours * 5 PressOps shows up as 8:00:00 PM which is 20:00. I don't know what is formatting the filed to show PM now.
ASKER
It also is not working on values that would exceed 24 hours or 24:00.
The function works. Here's a test:
23:00
115:00
230:00
Perhaps your values are not date/time?
Try:
=FormatHourMinute((CDate([ PFT])-CDat e([PMRT])+ Abs(CDate( [PFT])<CDa te([PMRT]) ))*[PressO ps])
/gustav
Public Sub test()
Dim PMRT As Date
Dim PFT As Date
Dim PressOps As Integer
Dim D As Integer
' Start
PMRT = #9:00:00 AM#
' End
PFT = #8:00:00 AM#
PressOps = 1
Debug.Print FormatHourMinute((PFT - PMRT + Abs(PFT < PMRT)) * PressOps)
PressOps = 5
Debug.Print FormatHourMinute((PFT - PMRT + Abs(PFT < PMRT)) * PressOps)
PressOps = 10
Debug.Print FormatHourMinute((PFT - PMRT + Abs(PFT < PMRT)) * PressOps)
End Sub
Output is:23:00
115:00
230:00
Perhaps your values are not date/time?
Try:
=FormatHourMinute((CDate([
/gustav
ASKER
I get the same results, The PMRT and PFT fields are both set as short text and format is Medium time.
ASKER
I pasted the line in the macro and I get an error that says the database can't parse the expression.
The format doesn't matter; it is for display only.
What matters are the values and the data type.
If data type is Date, the function and calculation works as is.
If data type is Text, the values must be converted using CDate before passed to the function and calculation can be performed.
The output is text because a time value of more than 24 hours cannot be displayed using a time format.
Thus, the format of the output should be none or Standard.
/gustav
What matters are the values and the data type.
If data type is Date, the function and calculation works as is.
If data type is Text, the values must be converted using CDate before passed to the function and calculation can be performed.
The output is text because a time value of more than 24 hours cannot be displayed using a time format.
Thus, the format of the output should be none or Standard.
/gustav
Could you replicate here please, what you pasted and where?
/gustav
/gustav
ASKER
See the attached PDF file.
Error.pdf
Error.pdf
ASKER
I did paste your test function into a module and it does work properly, even for values over 24 hours.
Oops, I don't do macros, so I can't tell.
Couldn't you just open the Properties panel and select Events, OnClick and Event Procedure and open the code Windows.
Then insert this code line:
Me!ManHrs.Value = FormatHourMinute((CDate([P FT])-CDate ([PMRT])+A bs(CDate([ PFT])<CDat e([PMRT])) )*[PressOp s])
/gustav
Couldn't you just open the Properties panel and select Events, OnClick and Event Procedure and open the code Windows.
Then insert this code line:
Me!ManHrs.Value = FormatHourMinute((CDate([P
/gustav
ASKER
See attached pdf file. I'm still getting an error message. Should I drop the macro and try to do it all in vba?
ASKER
File attached to this one.
Time-Calculation.pdf
Time-Calculation.pdf
> Should I drop the macro and try to do it all in vba?
I would recommend that.
/gustav
I would recommend that.
/gustav
ASKER
OK, I think I have the basics worked out for the VBA. Your test function does give the correct results. I've set the variables to read from the form already so it picks up the values from PMRT, PFT and PressOps and calculates the correct value. However I can't seem to get the code to populate the manhrs field on the form to work. I don't get any errors, just nothing seems to happen.
ASKER
Also can we get it all rolled into one function?
What does your OnClick sub function look like?
/gustav
/gustav
ASKER
I don't have anything on the onClick sub function. I have a after update function on the PressOps field.
Private Sub PressOps_Change()
Call MyFunctions.Test
End Sub
The test sub is what you sent me with a couple of modifications to pull the data from the form. Here it is. It works when I run it manually from the VBA window but I can't get the call to work. The test Sub also used your FormatHourMinute function.
Public Sub Test()
Dim PMRT As Date
Dim PFT As Date
Dim PressOps As Integer
Dim ET As String
' Start
PMRT = Forms!FrmEditPressRpt!PMRT .Value
' End
PFT = Forms!FrmEditPressRpt!PFT. Value
PressOps = Forms!FrmEditPressRpt!Pres sOps.Value
Debug.Print FormatHourMinute((PFT - PMRT + Abs(PFT < PMRT)) * PressOps)
ET = FormatHourMinute((PFT - PMRT + Abs(PFT < PMRT)) * PressOps)
Debug.Print ET
Forms!FrmEditPressRpt!ManH rs.Value = ET
DoCmd.SetProperty "forms!frmEditPressRpt!Man Hrs", acPropertyValue, ET
End Sub
Private Sub PressOps_Change()
Call MyFunctions.Test
End Sub
The test sub is what you sent me with a couple of modifications to pull the data from the form. Here it is. It works when I run it manually from the VBA window but I can't get the call to work. The test Sub also used your FormatHourMinute function.
Public Sub Test()
Dim PMRT As Date
Dim PFT As Date
Dim PressOps As Integer
Dim ET As String
' Start
PMRT = Forms!FrmEditPressRpt!PMRT
' End
PFT = Forms!FrmEditPressRpt!PFT.
PressOps = Forms!FrmEditPressRpt!Pres
Debug.Print FormatHourMinute((PFT - PMRT + Abs(PFT < PMRT)) * PressOps)
ET = FormatHourMinute((PFT - PMRT + Abs(PFT < PMRT)) * PressOps)
Debug.Print ET
Forms!FrmEditPressRpt!ManH
DoCmd.SetProperty "forms!frmEditPressRpt!Man
End Sub
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
Gustav I can't thank you enough. This is so much easier than the way I was trying to do it and I learned so much about VBA today. I have similar places in this DB where I'm working with date time fields and this will help so much. I wish I could give you 10 times the points . Thanks for sticking with me through this.
Marshall
Marshall
To be able to do a SUM in houres, you need to use format below in the cell with the formula :
Open in new window