We help IT Professionals succeed at work.

Error inserting data from record into another Table

correlate
correlate asked
on
Hi

I have a piece of code which I thought would add a new record to another table. The database has 2 main tables (People, which is where the data comes from) and PeopleOnAssignments which is where I want the data added to - this table has 4 fields in it:

ID (Autonunber)
PersonID (Number)
AssignmentID (Number)
Status (Text, but its not used in this part )

Dim PeopleID1 As String
Dim AssignmentID1 As String
PeopleID1 = Me.ID
AssignmentID1 = Me.AssLookupCombo.Value

Dim strSQL As String
strSQL = "INSERT INTO PeopleOnAssignments ([PersonID],[AssignmentID]) Values(PeopleID1 , AssignmentID1)"
CurrentDb.Execute strSQL, dbFailOnError

Open in new window


The error I keep getting is 3061 - Too few parameters. Expected 2

Can anyone help
Comment
Watch Question

Most Valuable Expert 2015
Distinguished Expert 2018
Commented:
You need to concatenate the variables:
Dim PeopleID1 As String
Dim AssignmentID1 As String
PeopleID1 = Me.ID
AssignmentID1 = Me.AssLookupCombo.Value

Dim strSQL As String
strSQL = "INSERT INTO PeopleOnAssignments ([PersonID],[AssignmentID]) Values(" & PeopleID1 & "," &  AssignmentID1 & ")"
CurrentDb.Execute strSQL, dbFailOnError

Open in new window

If the IDs really are strings, use:
strSQL = "INSERT INTO PeopleOnAssignments ([PersonID],[AssignmentID]) Values('" & PeopleID1 & "','" &  AssignmentID1 & "')"

Open in new window

/gustav

Author

Commented:
Brilliant - works a treat -  thank you very much
Most Valuable Expert 2015
Distinguished Expert 2018

Commented:
You are welcome!

/gustav