Why is this script not running from powershell

Is that all you use? Because it should not make any difference whether you run the VBS from a cmd or powershell prompt ... Doesn't it perform anything, are you getting an error message, or what happens?

Anyway, I would use a PS script here. You should have insisted on one in your prior question ;-).
This should do the same as the VBS code, it is using almost the same logic:

$FileIn = 'test.txt'
if (!(Test-Path $FileIn))
{
  Write-Error "ERROR: Input file `"$FileIn`" does not exist."
  return
}

$header = Get-Content $FileIn | select -First 2
Get-Content $FileIn | Select -Skip 2 | ? { $_ } |
  % {
    $line = $_ -replace "0:00:00", "       " 
    $Client = $line.SubString(20,50).Trim()
    if (!(Test-Path $client+'.txt')) { $line = "$header`r`n$line" }
    $line | Out-File -Append $client+'.txt'
  }

Select allOpen in new window

Olemo,

Because i tested you script i see what is the problem, i expected the output will go to c:\temp but the output files are in c:\windows\system32

There is some difference between the script from Bill Brew and yours
your output shows a + sign after the name eg Cafe Engel+, Cafe Tetra+ and there is a file
called ----------+.txt and is empty .
Can you also make that i can adjust the output directory?

Thanks

Danny

None of the scripts (natively) supplies a path, so the result files will be in the current working directory you call the script in.

One approach is to first change the current directory to the one you want the files to be created in, using set-location c:\temp (the cmdlet alias is cd).

Another approach is that we use the path info from the input file, and create the files in that path. I'll take this one:

$FileIn = 'C:\Temp\test.txt'
if (!(Test-Path $FileIn))
{
  Write-Error "ERROR: Input file `"$FileIn`" does not exist."
  return
}

$path = split-path -parent $FileIn 
$header = Get-Content $FileIn | ? { $_ } | select -First 2
Get-Content $FileIn | ? { $_ } | Select -Skip 2 | 
  % {
    $line   = $_ -replace "0:00:00", "       " 
    $FileOut= $path + $line.SubString(20,50).Trim() + '.txt'
    if (!(Test-Path $FileOut)) { $line = "$header`r`n$line" }
    $line | Out-File -Append $FileOut
  }

Select allOpen in new window

This also resolves the issue with '-------' and the added plus in the file names. (I hate PowerShell trying to do smart things with strings while I don't want it to.)

Olemo,

I don't know what i am doing wrong here? I don't get any output but also no error

 Thanks

Danny

The files are created in the Temp folder (where the input file is located). Did you check that?

Olemo

Yes i did but nothing ??

Danny

Olemo,

Works perfect thanks so much

Danny