Divide operand in if statement

Dear all,

Is there is a better way to write the below if statement.  ApplianceMap is a hash map.

double fridge = ((applianceMap.get("Fridge").doubleValue()));

		if (fridge != 0) {
			fridge = (fridge / 365) / 24;

Open in new window

Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Um...perhaps the obvious improvement to:

            if (fridge != 0) {
                  fridge = (fridge / 365) / 24;

is to replace it with just:
             fridge = (fridge / 365) / 24;

since 0 / 365 / 24 is still 0.

You can also write this as:
    fridge = fridge / (365 * 24) ;
    fridge = fridge / 8760 ;


Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
There's a more serious problem: what's going to happen if the get() call returns null? Clue: your code can be further improved if you're able to rely on auto-unboxing

You might also consider the formulation

fridge /= (365*24);

Open in new window

So your new code is what?
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today

From novice to tech pro — start learning today.