SQL Query

I want to create an update query for oinv table to update to U_ARINVTYPE = 'SD'

my query is
SELECT T0.[DocNum], T0.[DocType], T0.[CardCode], T1.[ItemCode], T0.[U_ARINVTYPE] FROM OINV T0  INNER JOIN INV1 T1 ON T0.[DocEntry] = T1.[DocEntry] WHERE T1.[ItemCode] = 'SD' or  T1.[ItemCode] = 'SDR' or  T1.[ItemCode] = 'SR' or  T1.[ItemCode]   = 'KD' or  T1.[ItemCode] = 'KDR' or   T1.[ItemCode] = 'RCR'  OR T1.[ItemCode] = 'RC'
romeiovasuAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Jim HornMicrosoft SQL Server Developer, Architect, and AuthorCommented:
Here you go.  Also cleaned up a lot of your original query
UPDATE OINV 
SET U_ARNINVITE='SD'
FROM OINV o
    JOIN INV1 i ON o.DocEntry = i.DocEntry
WHERE i.ItemCode IN ('SD', 'SDR', 'SR', 'KD', 'KDR', 'RCR', 'RC') 

Open in new window


Changed the WHERE..OR..OR to an IN, much easier to read
Removed the square brackets [ ], as they are only needed when a name does not conform to naming requirements
Changed table aliases to o and i, a little more intuitive
0
dsackerContract ERP Admin/ConsultantCommented:
Here is the update query. You can also eliminate all those OR criteria with one IN criteria:
UPDATE OINV
SET    U_ARINVTYPE = 'SD'
FROM   INV1
WHERE  INV1.DocENtry = OINV.DocEntry
AND    INV1.ItemCOde IN ('SD', 'SDR', 'SR', 'KD', 'RCR', 'RC')

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.