Link to home
Start Free TrialLog in
Avatar of desiredforsome
desiredforsome

asked on

SQL Dynamic stored procedure issue

I am writing a stored procedure to be a dynamic sql. I am not finished but am having errors so far.

Below is my code and i am getting two errors. error with syntax near ',' and incorrect syntax near the keyword 'else'

USE [med]
GO
/****** Object:  StoredProcedure [dbo].[insertupdatedem]    Script Date: 04/11/2015 16:12:14 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER procedure [dbo].[insertupdatedem]

@mrn int,
@lastname nvarchar(50) =null,
@firstname nvarchar(50)=null,
@address1 nvarchar(50)=null,
@city nvarchar(50)=null,
@state nvarchar(50)=null,
@dob datetime=null,
@ssn nvarchar(50)=null,
@marital nvarchar(50)=null,
@gender nvarchar(1)=null,
@zip nvarchar(50)=null,
@sqlquery nvarchar(500),
@sqlselect nvarchar(500)

as


begin

set nocount on


if exists(select 1 from med.dbo.demographics where lastname=@lastname and dob=@dob and ssn=@ssn)
set @sqlquery = 'update med.dbo.demographics set dob=' + @dob + ' ,ssn=' + @ssn + ',gender='+@gender+',marital='+@marital+',address1='+@address1+',city='+@city+',[state]='+,@state+',zip='+@zip
execute @sqlquery;

else

insert into med.dbo.demographics(mriid,dob,ssn,gender,marital,address1,city,[state],zip)
values(@mrn,@dob,@ssn,@gender,@marital,@address1,@city,@state,@zip)
insert into med.dbo.primarymrn(firstname,lastname)
values(@firstname, @lastname)

End

Open in new window

Avatar of Mike Eghtebas
Mike Eghtebas
Flag of United States of America image

add ; at the end of line 39

values(@mrn,@dob,@ssn,@gender,@marital,@address1,@city,@state,@zip);
ASKER CERTIFIED SOLUTION
Avatar of Scott Pletcher
Scott Pletcher
Flag of United States of America image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
desiredforsome, do you still need help with this question?