SQL Dynamic stored procedure issue

I am writing a stored procedure to be a dynamic sql. I am not finished but am having errors so far.

Below is my code and i am getting two errors. error with syntax near ',' and incorrect syntax near the keyword 'else'

USE [med]
GO
/****** Object:  StoredProcedure [dbo].[insertupdatedem]    Script Date: 04/11/2015 16:12:14 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER procedure [dbo].[insertupdatedem]

@mrn int,
@lastname nvarchar(50) =null,
@firstname nvarchar(50)=null,
@address1 nvarchar(50)=null,
@city nvarchar(50)=null,
@state nvarchar(50)=null,
@dob datetime=null,
@ssn nvarchar(50)=null,
@marital nvarchar(50)=null,
@gender nvarchar(1)=null,
@zip nvarchar(50)=null,
@sqlquery nvarchar(500),
@sqlselect nvarchar(500)

as


begin

set nocount on


if exists(select 1 from med.dbo.demographics where lastname=@lastname and dob=@dob and ssn=@ssn)
set @sqlquery = 'update med.dbo.demographics set dob=' + @dob + ' ,ssn=' + @ssn + ',gender='+@gender+',marital='+@marital+',address1='+@address1+',city='+@city+',[state]='+,@state+',zip='+@zip
execute @sqlquery;

else

insert into med.dbo.demographics(mriid,dob,ssn,gender,marital,address1,city,[state],zip)
values(@mrn,@dob,@ssn,@gender,@marital,@address1,@city,@state,@zip)
insert into med.dbo.primarymrn(firstname,lastname)
values(@firstname, @lastname)

End

Open in new window

desiredforsomeAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Mike EghtebasDatabase and Application DeveloperCommented:
add ; at the end of line 39

values(@mrn,@dob,@ssn,@gender,@marital,@address1,@city,@state,@zip);
0
Scott PletcherSenior DBACommented:
Change "+,@state" to "+@state" (remove the extra comma):

set @sqlquery = 'update med.dbo.demographics set dob=' + @dob + ' ,ssn=' + @ssn + ',gender='+@gender+',marital='+@marital+',address1='+@address1+',city='+@city+',[state]='+@state+',zip='+@zip
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Vitor MontalvãoMSSQL Senior EngineerCommented:
desiredforsome, do you still need help with this question?
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server 2005

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.