script output not proper as expected

Hi Experts,

I want to create a script for 2 hardwares dell and HP ..so if the dell hardware then nic will be em1 etc then it greps em1 IP and if HP then grep eth0 etc..and display eth0 ip.

please help



/sbin/ifconfig > /tmp/testnic

grep -q "em1" /tmp/testnic

# if not then create it
if [ $? -ne 0 ]; then
        echo -e "

Address = `/sbin/ifconfig em1 | grep 'inet addr:' | cut -d: -f2 | awk '{ print $1}'`
"

else
        echo -e "


Address = `/sbin/ifconfig eth0 | grep 'inet addr:' | cut -d: -f2 | awk '{ print $1}'`
"
fi

rm -rf /tmp/testnic
The RockAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

woolmilkporcCommented:
I think your logic is wrong. You grep for em1 and try to display the address if not found. How should this work?

Try the following which is a bit shorter than your version:

if /sbin/ifconfig | grep -q em1; then
        echo -e "

Address = $(/sbin/ifconfig em1 | awk '/inet addr:/ {print substr($2,index($2,":")+1)}')
"

else
        echo -e "


Address = $(/sbin/ifconfig eth0 | awk '/inet addr:/ {print substr($2,index($2,":")+1)}')
"
fi

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
The RockAuthor Commented:
thanks got it
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Shell Scripting

From novice to tech pro — start learning today.