using two values to find files

Hello,
I am not sure the best way to do this.  Have a need to search files , using two values.  If the files contain these two values then write the file name to a file called filenames.txt

I tried grep,   grep -e value1 -e value2 filename  

Is there another way to do this



thanks in advance for the help