Invalid Column error in where clause on stored procedure execution

I have a basic stored procedure that I created that is failing with an invalid collumn name error when executed. The only problem is that the variable being passed goes into the where clause and is not a column name.



ALTER PROCEDURE [dbo].[spSearchFirstName]
      @FirstName varchar(155)
AS

BEGIN

EXEC('Select first, last, address, address2, city, state, zip, county, [Home Phone],
      [Work Phone], [Mobile Phone],
      order, description
      FROM vwAllOrders
      WHERE first = ' + @FirstName
)
END



--EXECUTION
EXEC spSearchFirstName @FirstName = N'Thomas '
gwarcherAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Snarf0001Commented:
Don't add the '+ to the clause, the variable will take the place of a literal string value:

ALTER PROCEDURE [dbo].[spSearchFirstName]
       @FirstName varchar(155) 
 AS

 BEGIN

 EXEC('Select first, last, address, address2, city, state, zip, county, [Home Phone],
       [Work Phone], [Mobile Phone], 
       order, description
       FROM vwAllOrders
       WHERE first = @FirstName 
 )
 END

Open in new window

Vitor MontalvãoMSSQL Senior EngineerCommented:
You don't need the EXEC. Run the SELECT normally and the engine will replace the variable with the stored value.
ALTER PROCEDURE [dbo].[spSearchFirstName]
       @FirstName varchar(155) 
 AS

BEGIN
    SELECT first, last, address, address2, city, state, zip, county, [Home Phone], [Work Phone], [Mobile Phone], order,description
    FROM vwAllOrders
    WHERE first = @FirstName 
 END

Open in new window

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
gwarcherAuthor Commented:
Thanks, force of habit using EXEC.
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server

From novice to tech pro — start learning today.