Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!
variable not being used correctly by grep in shell script
I'm writing a script to resize vagrant boxes. I'm struggling with a section, which is supposed to close media. I provide the path to the vmdk file and the new size to the script.
An example path is /root/.vagrant.d/boxes/tes
The section is as follows:
for disk in `$execsudo vboxmanage list hdds | grep -B4 $1 | grep - | grep UUID | awk \ '{print $2}'`
do
$execsudo vboxmanage closemedium disk $disk
done
It is not correctly using $1. I've tried various quoting etc. I'd appreciate some assistance.
An example path is /root/.vagrant.d/boxes/tes
The section is as follows:
for disk in `$execsudo vboxmanage list hdds | grep -B4 $1 | grep - | grep UUID | awk \ '{print $2}'`
do
$execsudo vboxmanage closemedium disk $disk
done
It is not correctly using $1. I've tried various quoting etc. I'd appreciate some assistance.
Do more with
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
can you provide examples of input and add an echo of $1 to your script so we can see whats wrong with it
usage:
./resizeVmdk.sh /root/.vagrant.d/boxes/tes
An important point that I forgot to mention is that this part is in a function. It is not being picked up in the function. It is outside the function.
Here is output from the script:
+ echo input=/root/.vagrant.d/box
input=/root/.vagrant.d/box
+ echo path=/root/.vagrant.d/boxe
path=/root/.vagrant.d/boxe
+ /bin/sudo rm -f /tmp/cloned.vdi
+ echo 'Backing up vmdk file ....'
Backing up vmdk file ....
+ /bin/sudo cp /root/.vagrant.d/boxes/tes
+ echo 'Cloning vmdk file ....'
Cloning vmdk file ....
+ /bin/sudo vboxmanage clonehd /root/.vagrant.d/boxes/tes
0%...10%...20%...30%...40%
Clone hard disk created in format 'vdi'. UUID: e498adc1-490a-4580-801b-58
+ echo 'Resizing cloned file ....'
Resizing cloned file ....
+ /bin/sudo vboxmanage modifyhd /tmp/cloned.vdi --resize 81920
0%...10%...20%...30%...40%
+ close-medium
+ echo '++++++++++ Added pre loop echo here +++++++++++++'
++++++++++ Added pre loop echo here +++++++++++++
+ echo
NOTHING !!
+ echo '++++++++++ Added pre loop echo here +++++++++++++'
++++++++++ Added pre loop echo here +++++++++++++
++ /bin/sudo vboxmanage list hdds
++ grep -B4
++ grep -
++ grep UUID
++ awk ' {print $2}'
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
./resizeVmdk.sh /root/.vagrant.d/boxes/tes
An important point that I forgot to mention is that this part is in a function. It is not being picked up in the function. It is outside the function.
Here is output from the script:
+ echo input=/root/.vagrant.d/box
input=/root/.vagrant.d/box
+ echo path=/root/.vagrant.d/boxe
path=/root/.vagrant.d/boxe
+ /bin/sudo rm -f /tmp/cloned.vdi
+ echo 'Backing up vmdk file ....'
Backing up vmdk file ....
+ /bin/sudo cp /root/.vagrant.d/boxes/tes
+ echo 'Cloning vmdk file ....'
Cloning vmdk file ....
+ /bin/sudo vboxmanage clonehd /root/.vagrant.d/boxes/tes
0%...10%...20%...30%...40%
Clone hard disk created in format 'vdi'. UUID: e498adc1-490a-4580-801b-58
+ echo 'Resizing cloned file ....'
Resizing cloned file ....
+ /bin/sudo vboxmanage modifyhd /tmp/cloned.vdi --resize 81920
0%...10%...20%...30%...40%
+ close-medium
+ echo '++++++++++ Added pre loop echo here +++++++++++++'
++++++++++ Added pre loop echo here +++++++++++++
+ echo
NOTHING !!
+ echo '++++++++++ Added pre loop echo here +++++++++++++'
++++++++++ Added pre loop echo here +++++++++++++
++ /bin/sudo vboxmanage list hdds
++ grep -B4
++ grep -
++ grep UUID
++ awk ' {print $2}'
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
if [[ ! `$execsudo ls $1` ]]
then
echo "vmdk file does not exist. Exiting."
exit 1
else
path=`echo $1 | sed -e "s/\/[^\/]*$//"`
file=`echo $1 | awk -F "/" '{print $NF}'`
# - this is for test
echo input=$1
echo path=$path
# -
close-medium () {
for disk in `$execsudo vboxmanage list hdds | grep -B4 $1 | grep - | grep UUID | awk \ '{print $2}'`
do
$execsudo vboxmanage closemedium disk $disk
done
for clone in `$execsudo vboxmanage list hdds | grep -B4 cloned.vdi | grep - | grep UUID | awk \ '{print $2}'`
do
$execsudo vboxmanage closemedium disk $clone
done
}
then
echo "vmdk file does not exist. Exiting."
exit 1
else
path=`echo $1 | sed -e "s/\/[^\/]*$//"`
file=`echo $1 | awk -F "/" '{print $NF}'`
# - this is for test
echo input=$1
echo path=$path
# -
close-medium () {
for disk in `$execsudo vboxmanage list hdds | grep -B4 $1 | grep - | grep UUID | awk \ '{print $2}'`
do
$execsudo vboxmanage closemedium disk $disk
done
for clone in `$execsudo vboxmanage list hdds | grep -B4 cloned.vdi | grep - | grep UUID | awk \ '{print $2}'`
do
$execsudo vboxmanage closemedium disk $clone
done
}
What part of that script produced the output
+ /bin/sudo vboxmanage modifyhd /tmp/cloned.vdi --resize 81920
0%...10%...20%...30%...40%
+ close-medium
+ echo '++++++++++ Added pre loop echo here +++++++++++++'
++++++++++ Added pre loop echo here +++++++++++++
+ echo
?
Where was close-medium called?
+ /bin/sudo vboxmanage modifyhd /tmp/cloned.vdi --resize 81920
0%...10%...20%...30%...40%
+ close-medium
+ echo '++++++++++ Added pre loop echo here +++++++++++++'
++++++++++ Added pre loop echo here +++++++++++++
+ echo
?
Where was close-medium called?
Sorry. Following from function
# Remove any exisitng clone
$execsudo rm -f /tmp/cloned.vdi > /dev/null 2>&1
echo "Backing up files (will not overwrite original backups!) ...."
$execsudo cp $1 $1.orig > /dev/null 2>&1
$execsudo cp $path/box.ovf $path/box.ovf.orig > /dev/null 2>&1
echo "Cloning vmdk file ...."
$execsudo vboxmanage clonehd $1 /tmp/cloned.vdi --format vdi
echo "Resizing cloned file ...."
$execsudo vboxmanage modifyhd /tmp/cloned.vdi --resize $(($2*1024))
close-medium
# Remove vmdk file
$execsudo rm -f $1
# Remove any exisitng clone
$execsudo rm -f /tmp/cloned.vdi > /dev/null 2>&1
echo "Backing up files (will not overwrite original backups!) ...."
$execsudo cp $1 $1.orig > /dev/null 2>&1
$execsudo cp $path/box.ovf $path/box.ovf.orig > /dev/null 2>&1
echo "Cloning vmdk file ...."
$execsudo vboxmanage clonehd $1 /tmp/cloned.vdi --format vdi
echo "Resizing cloned file ...."
$execsudo vboxmanage modifyhd /tmp/cloned.vdi --resize $(($2*1024))
close-medium
# Remove vmdk file
$execsudo rm -f $1
Premium Content
You need an Expert Office subscription to comment.Start Free Trial