Potential Resource Leak Error in Eclipse

I changed some lines  in my code from:

                                InputStream pdfInputStream = pdDoc.getContentStream().getStream();
				byte[] tiffFile = IOUtils.toByteArray(pdfInputStream);
					pdfInputStream.close();

Open in new window


to

					byte[] tiffFile = IOUtils.toByteArray(pdDoc.getContentStream().getStream());
					pdDoc.getContentStream().getStream().close();

Open in new window


I notice that got rid of a 'Potential Resource Leak Error' that was being thrown by eclipse.

(Note: Right now my eclipse is configured to throw  an error whenever such issues arise)

My questions are:
1) Why does that change correct the error?
2) When written as in the second code snippet, is it best practice to add the following snippet in the finally block?

		}finally{
			if (pdDoc.getContentStream().getStream()!=null) {
				pdDoc.getContentStream().getStream().close();
			}
		}

Open in new window

onaled777Asked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

krakatoaCommented:
1) Why does that change correct the error?

possibly because "pdDoc.getContentStream().getStream()" was still open. Could you test that?

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
onaled777Author Commented:
Thanks Krakatoa.  Apparently the issue was due to the specifications in COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE on which the Potential Resource Leak Error is Based.
krakatoaCommented:
Ah - you found that from the vendor presumably. Anyway, glad to hear 'fixed'.
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Java

From novice to tech pro — start learning today.