Method SaveAS ofobject_Workbook failed

Jagwarman
Jagwarman used Ask the Experts™
on
Can an expert throw any light on this.

I use the below to save files without any problems.

Other colleagues also use without problems.

But some colleagues get the Methd SaveAs error.

I have noted that if the year [2015] file is in the folder it works for everyone every time

If the year is not in the folder it falls over with the error, so it is not creating the Year Folder.


Sub MonthFolder()
    Dim sFilename As String
    Dim sPath As String
     
    sFilename = "Test File " 'Set filename
 
    sPath = "C:\ABC\XYZ"       'Set base path"
   
    If Right(sPath, 1) <> "\" Then sPath = sPath & "\" 'Check for "\"
   
    sPath = sPath & Format(Date, "yyyy\\m mmm yyyy\\")
   
    If Dir(sPath, vbDirectory) = "" Then             'If folder doesn't exist, create it
        Shell "cmd /c mkdir """ & sPath & """"
    End If
    ActiveWorkbook.SaveAs sPath & sFilename & Format(Date - 1, " ddmmmyy") & ".xls"

End Sub
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
View Solution Only
Commented:
You can't create nested folders at once.
You should create Year folder and then Date folder:
Sub MonthFolder()
    Dim sFilename As String
    Dim sPath As String
     
    sFilename = "Test File " 'Set filename
  
    sPath = "C:\ABC\XYZ"       'Set base path"
    
    If Right(sPath, 1) <> "\" Then sPath = sPath & "\" 'Check for "\"
    
    sPath = sPath & Format(Date, "yyyy")
   
    If Dir(sPath, vbDirectory) = "" Then             'If folder doesn't exist, create it
        Shell "cmd /c mkdir """ & sPath & """"
    End If

    sPath = sPath & Format(Date, "\\m mmm yyyy\\")  
    If Dir(sPath, vbDirectory) = "" Then             'If folder doesn't exist, create it
        Shell "cmd /c mkdir """ & sPath & """"
    End If

 ActiveWorkbook.SaveAs sPath & sFilename & Format(Date - 1, " ddmmmyy") & ".xls"

End Sub

Open in new window

Jagwarman

Author

Commented:
so simple when you know what your looking for... Thanks

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial