I need to perform worksheet TRIM function on all the columns of the worksheet in the workbook?

Amit Shah
Amit Shah used Ask the Experts™
on
I need to perform worksheet TRIM function on all the columns of the worksheet in the workbook?

Below is the example:-
Open a Workbook (ABC.xlsx) on which i need to perform worksheet TRIM function. There is a vba code on the command button which is present on second workbook (XYZ.xlsx). But I am facing an issue that I am not able to activate the Workbook (ABC.xlsx) & worksheet (test) while running the VBA code from the command button on workbook (xyz.xlsx).

Below is the code for Reference ->

Dim r As Range
Set oExcel1 = CreateObject("Excel.Application")
Set oExcel1_Workbook1 = oExcel1.Workbooks.Open ("C:\NewFolder1\ NewFolder2\ NewFolder3\ABC.xlsx")
oExcel1.Application.Visible = True
Set oExcel1_Worksheet1 = oExcel1_Workbook1.Worksheets ("test")
ColCount1 = oExcel1_Worksheet1.Cells (1, oExcel1_Worksheet1.Columns.Count).End(xlToLeft).Column

For i = 1 to ColCount1
celladdres = oExcel1_Worksheet1.Cells(1,i).Address
rangeValue = replace(cellAddress,"$","")
Set r = Intersect(Range(rangeValue).EntireColumn, ActiveSheet.UsedRange)
''''''''' HERE I AM FACING ISSUE TO ACTIVATE THE (test) worksheet from (ABC.xlsx) workbook. As per the above code the ActiveSheet is the worksheet (Sheet1) of (xyz.xlsx) workbook and ActiveSheet.usedRange is giving value of worksheet (Sheet1) of (xyz.xlsx) workbook. Help with code to make (test) worksheet as active and get UsedRange from that worksheet. '''''''''
r.Value = Evaluate("IF(ROW(" & r.Address & "),IF(" & r.Address & "<>"""",TRIM(" & r.Address & "),""""))")
Next
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Ryan ChongSoftware Team Lead

Commented:
to activate a workbook, you can try:
Workbooks("yourExcel.xlsx").Activate

Open in new window

to activate a worksheet, you can try:
Worksheets("yourSheet").Select

Open in new window

Author

Commented:
Below is the code i tried but still i am not able to activate the worksheet which i want ->
oExcel1_Workbook1.Activate
oExcel1_Worksheet1.Activate
oExcel1_Worksheet1.Select
Set r = Intersect(Range(rangeValue).EntireColumn, ActiveSheet.UsedRange)

--- Still i am facing same issue. I am not getting UsedRange of the activated worksheet. It is reffering the worksheet where command button is present.
Could you please help
Ryan ChongSoftware Team Lead

Commented:
try:
....
Dim ws As Worksheet
    Set ws = Workbooks("ABC.xlsx").Worksheets("test")
    ws.Activate
Set r = Intersect(Range(rangeValue).EntireColumn, ActiveSheet.UsedRange)
...

Open in new window

or:
...
Dim ws As Worksheet
    Set ws = Workbooks("ABC.xlsx").Worksheets("test")
Set r = Intersect(Range(rangeValue).EntireColumn, ws.UsedRange)
...

Open in new window

you may also modify:
Range(rangeValue).EntireColumn

Open in new window

to:
ws.Range(rangeValue).EntireColumn

Open in new window

Author

Commented:
Thanks Ryan for the help.
Below is the answer which is working for me.

Dim r As Range
Set oExcel1 = CreateObject("Excel.Application")
Set oExcel1_Workbook1 = oExcel1.Workbooks.Open ("C:\NewFolder1\ NewFolder2\ NewFolder3\ABC.xlsx")
oExcel1.Application.Visible = True
Set oExcel1_Worksheet1 = oExcel1_Workbook1.Worksheets ("test")
oExcel1.Workbooks("ABC.xlsx").Activate
oExcel1_Workbook1.Worksheets("test").Activate

ColCount1 = oExcel1_Worksheet1.Cells (1, oExcel1_Worksheet1.Columns.Count).End(xlToLeft).Column

For i = 1 to ColCount1
celladdres = oExcel1_Worksheet1.Cells(1,i).Address
rangeValue = replace(cellAddress,"$","")
Set r = oExcel1.Intersect(oExcel1_Workbook1.Worksheets("test").Range(rangeValue).EntireColumn, oExcel1_Workbook1.Worksheets("test").UsedRange)
oExcel1_Workbook1.Worksheets("test").Select
r.Value = oExcel1.Evaluate("IF(ROW(" & r.Address & "),IF(" & r.Address & "<>"""",TRIM(" & r.Address & "),""""))")

Next
Software Team Lead
Commented:
ok, glad that u managed to solved the issues. let me know if my posts helped and led u to find the solution.

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial