DAO Recordset Loop

Hi
I'm attempting to loop through the values in a query (qryEmailRecipients) to establish if the value of a Yes/No field (Damage) is true.  If it is, then get the value of the 'emailaddress' field value.  Seems OK if all values of the Damage field are True but if one record has a False value, the code (I suspect) simply keeps looping.  Should I be testing for null?  

Set db = CurrentDb
Set rs = db.OpenRecordset("qryEmailRecipients")

Do While Not rs.EOF

If rs!damage = True Then
    strListEmail = strListEmail & ";" & rs!emailaddress
    rs.MoveNext
    
    Else
    End If
Loop


strListEmail = Mid(strListEmail, 2)

Open in new window

padrepio2Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Dale FyeCommented:
How about simply modifying line 2:

Set rs = db.OpenRecordset("SELECT * FROM qryEmailRecipients WHERE [Damage] = -1")

Then you can remove the IF/End If construct entirely.
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Rey Obrero (Capricorn1)Commented:
dale suggestion is the way to go, but if you want to know why your code is not working

-it is because the rs.MoveNext at line 8 is at the wrong location

- move the rs.MoveNext after  End If before Loop
0
padrepio2Author Commented:
Brilliant, thank you
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft Access

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.