Trouble grouping shapes in Word VBA

Bryce Bassett
Bryce Bassett used Ask the Experts™
on
This is driving me crazy.  It seems so easy, but I am obviously missing something.  I have a macro that lets the user select one or more photos, provide a caption, and then it is supposed to groups the photos, put the caption under the group, then group the caption with the grouped photos, so they can all be moved as one unit.

Everything works fine until the very last line of the macro.  It gives me an error saying "grouping is disabled for the selected shapes."  

Sub captionselectedphoto(control As IRibbonControl)

Dim shapesselected As Integer
Dim photos2caption As ShapeRange
Dim phototitle As String

shapesselected = Selection.ShapeRange.count

If shapesselected = 0 Then
    MsgBox "Please select one or more photos to caption, then try again"
    Exit Sub
End If

Set photos2caption = Selection.ShapeRange

If photos2caption.count > 1 Then photos2caption.Group
Application.ScreenRefresh

phototitle = InputBox("Photo title?")

Selection.InsertCaption Label:="Figure", TitleAutoText:="", _
    Title:=": " & phototitle, Position:=wdCaptionPositionBelow, ExcludeLabel:=0

Set captionbox = ActiveDocument.Shapes(ActiveDocument.Shapes.count)

MsgBox photos2caption.Name  'returns "Group 20"
MsgBox captionbox.Name      'returns "Text Box 9"

ActiveDocument.Shapes.Range(Array(photos2caption.Name, captionbox.Name)).Group

End Sub

Open in new window

As you can see, I stuck in a couple msgboxes near the end to tell me the shape names.  The return the expected names.  What is most maddening is that I can run this test macro and it does exactly what I want:
ActiveDocument.Shapes.Range(Array("Group 20", "Text Box 9")).Group

Open in new window

This is what I'm aiming for.  globegroup.jpgIs there something wrong with my syntax?  Can I not put variables in the array statement like this?  What am I doing wrong?
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®

Commented:
I am looking on my phone - how do you add the caption box?

Commented:
Oh scratch that I see the test.... try adding doevents before the group

Commented:
Yikes... weird.  So I made some small changes, namely the addition of...
Debug.Print "Activedocument.Shapes.Range(Array(""" & photos2caption.Name & """, " & """" & captionbox.Name & """)).Group"

Open in new window

after the 2 message boxes (& commented out the message boxes) but before attempting to group.

The code fails, press End.  Go to immediate window and run the debug.print line and it still fails.  

Now, select the caption box so the border is solid and run the debug.print line a 2nd time and the grouping fails again.

Now, instead, select the already grouped images BUT NOT the caption box and the grouping works.  (incidentally it also works if the caption box is selected....)
Ensure you’re charging the right price for your IT

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!

Commented:
Moral - word is weird.  You need to select photos2caption before you group (line 31)...
Sub captionselectedphoto()

Dim shapesSelected As Integer
Dim photos2caption As ShapeRange
Dim phototitle As String
Dim captionbox As Shape

shapesSelected = Selection.ShapeRange.count

If shapesSelected = 0 Then
    MsgBox "Please select one or more photos to caption, then try again"
    Exit Sub
End If

Set photos2caption = Selection.ShapeRange

If photos2caption.count > 1 Then photos2caption.Group


phototitle = InputBox("Photo title?")

Selection.InsertCaption Label:="Figure", TitleAutoText:="", _
    Title:=": " & phototitle, Position:=wdCaptionPositionBelow, ExcludeLabel:=0

Set captionbox = ActiveDocument.Shapes(ActiveDocument.Shapes.count)

'MsgBox photos2caption.Name  'returns "Group 20"
'MsgBox captionbox.Name      'returns "Text Box 9"

Debug.Print "Activedocument.Shapes.Range(Array(""" & photos2caption.Name & """, " & """" & captionbox.Name & """)).Group"
photos2caption.Select
ActiveDocument.Shapes.Range(Array(photos2caption.Name, captionbox.Name)).Group

End Sub

Open in new window

Bryce BassettFreelance VBA programmer

Author

Commented:
This works now.  Thank you so much for troubleshooting this!  I thought I had tried to reselect the photo group, but I guess not.

Commented:
Gotta admit it had me flummoxed for a while too.  Glsd to help

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial