procedure convert to select sql

Hi,
Can i convert attached procedure to select sql statement as there many variables and i am not sure what is going on with it.

Thanks
procedure.txt
sam2929Asked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

David ToddSenior Database AdministratorCommented:
Hi,

First I want to comment on this snippet
--CLEAR OUT FAITCAdmin.utab_R1A table based on user ID and location ID
DELETE FROM FAITCAdmin.utab_R1N
WHERE USERID = @vchUSER_ID

The comment doesn't match the code as LocationID is missing from the where clause.

Next your cursor curYR_TO_DT - the loop logic, and the placement of the fetches is awful! At first I thought there was no fetch inside the loop. It is possible for this loop to jam and not complete, as its possible for the if - endif - end to not execute a statement, and that way the fetch will be missed.

HTH
  David

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server 2008

From novice to tech pro — start learning today.