We help IT Professionals succeed at work.
Get Started

refactoring java code

Rohit Bajaj
Rohit Bajaj asked
on
120 Views
Last Modified: 2015-11-29
Hi,
Following is my main function :
 public static void main(String[] args) throws Exception {
        String env = System.getProperty("FLOCK_APPS_CONFIG");
        int port=0;
        try {
            InputStream in = new FileInputStream(env);
            Properties props = new Properties();
            props.load(in);
            PropertyConfigurator.configure(props);
            port = Integer.parseInt(props.getProperty("port"));
        }
        catch (Exception e)
        {
            logger.log(Level.SEVERE,"Error accessing config File : "+env,e);
            System.exit(1);
        }
        AppStart appStart = new AppStart(port);
        try {
            appStart.start();
            appStart.waitForInterrupt();
        } finally {
            appStart.stop();
        }
        System.exit(1);
    }

Open in new window


I want to know experts comment on this. If i can improve it in some way..
Some things that probably can be changed are :
1) I am assigning int port = 0
which actually does not make any sense as i want the port to be read from a file and if i cannot read it
applications stops.
2) there is one try catch block and one try finally

Is this code fine or there is some improvement scope in it ?

Thanks
Comment
Watch Question
CERTIFIED EXPERT
Distinguished Expert 2020
Commented:
This problem has been solved!
Unlock 2 Answers and 6 Comments.
See Answers
Why Experts Exchange?

Experts Exchange always has the answer, or at the least points me in the correct direction! It is like having another employee that is extremely experienced.

Jim Murphy
Programmer at Smart IT Solutions

When asked, what has been your best career decision?

Deciding to stick with EE.

Mohamed Asif
Technical Department Head

Being involved with EE helped me to grow personally and professionally.

Carl Webster
CTP, Sr Infrastructure Consultant
Ask ANY Question

Connect with Certified Experts to gain insight and support on specific technology challenges including:

  • Troubleshooting
  • Research
  • Professional Opinions
Did You Know?

We've partnered with two important charities to provide clean water and computer science education to those who need it most. READ MORE